Bug 45495 - FILEOPEN .pptx: rotated object shown without rotation
Summary: FILEOPEN .pptx: rotated object shown without rotation
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
3.3.0 release
Hardware: All All
: medium normal
Assignee: Lennard Wasserthal
URL:
Whiteboard: target:4.0.0
Keywords:
: 56121 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-02-01 04:36 UTC by sasha.libreoffice
Modified: 2016-02-19 04:09 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
presentation with rotated object (756.12 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2012-02-01 04:36 UTC, sasha.libreoffice
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sasha.libreoffice 2012-02-01 04:36:37 UTC
Created attachment 56442 [details]
presentation with rotated object

attachment contains:
1) on first slide slightly rotated picture
2) on second slide screenshot of first slide in MSO 2007 russian

Expected: picture on first slide is slightly rotated
Actually: no rotation

reproduced in LibO 3.3.4. and 3.6.0 master on Fedora 64 bit
Comment 1 bfoman (inactive) 2012-07-16 11:44:04 UTC
Confirmed with:
LO 3.5.5.3 
Build ID: own W7 debug build
Windows 7 Professional SP1 64 bit

Picture is not rotated, background in grey colors.
Comment 2 Lennard Wasserthal 2012-09-03 13:45:08 UTC
Custom shapes are also not saved rotated either and when you try to save a rotated custom shape or picture you end up with it notably shifted or sometimes not present, and other objects sometimes very distorted (turned a rhomb into a rectangle!)
Comment 3 Rainer Bielefeld Retired 2012-10-18 05:26:58 UTC
Still [Reproducible] with  "LibreOffice 3.6.3.1” German UI/ German Locale [Build-ID: f8fce0b] on German WIN7 Home Premium (64bit) 
Already a problem with 3.3.0

We have lots of FILEOPEN pptx bugs (nearby 50), and only this one (and an CRASH) what never worked better and bores nobody (see number of entries in CC) is a MAB? thats not comprehensible, I remove this one from MAB tracking Bug and leave a note at <http://wiki.documentfoundation.org/HardHacks#No_HardHack_at_all>

@Lennard Wasserthal:
<http://wiki.documentfoundation.org/BugReport#General_information> item 4!
Comment 4 Rainer Bielefeld Retired 2012-10-18 05:32:16 UTC
Related bugs seem to show that there might be a more general misunderstanding concerning rotation syntax in .pptx?

@Thorsten:
Please set Status to ASSIGNED and add yourself to "Assigned To" if you accept this Bug or forward the Bug if it's not your turf
Comment 5 Thorsten Behrens (CIB) 2012-10-26 20:09:39 UTC
Rodo, you were looking into this recently - cycles left to give this a quick go?
Comment 6 Lennard Wasserthal 2012-11-06 21:18:03 UTC
@Rainer Bielefeld

But both is the same bug!

WriteShapeTransformation is called without an rotate argument.
(from oox/source/export/shapes.cxx)
WriteShapeTransformation oox/source/export/drawingml.cxx accepts an rotate parameter and works if it is present, but it is a template so the program doesn't
Yield a warning.

Should I handle this?
I just have to find out where the transform can be read, perhaps from the import routines or the shapes directly.
Perhaps I can do it this weekend or earlier.
Comment 7 Rainer Bielefeld Retired 2012-11-07 05:08:06 UTC
@Lennard:
It would be great if you could  take this one. I changed "Assigned To:" so that every body knows that you are working on this issue.
Please assign back to list if you don't find the time or if insuperable obstacles appear.
Comment 8 Lennard Wasserthal 2012-11-11 10:27:51 UTC
Patch generated. 

https://gerrit.libreoffice.org/1030

The patch fixes also

bug 34897

bug 56121

so I guess I'll threat them as dupes.

There HAS some work to be done, though, arrows for example are twitched and their custom shape control points run to their limits when touched, up arrows are first-invisi-then-box exported, sheared stuff causes glitches and there were many todos in oox/source/export/shapes.cxx
good, I file that as new bug, unless already happened.
Comment 9 Lennard Wasserthal 2012-11-11 10:33:21 UTC
*** Bug 56121 has been marked as a duplicate of this bug. ***
Comment 10 sasha.libreoffice 2012-11-12 05:16:59 UTC
Thanks for fixing this bug
Comment 11 Not Assigned 2012-11-29 20:19:28 UTC
Lennard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a9fc1456719da3cecda6a97454bad0642e493035

fdo#45495 pptx Export saves rotation of pictures,shapes,text



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.