Take any dataset and apply Autofilter to it. (Data > Filter > Autofilter). Then click on any column head, and select "Standard Filter" option. The Standard Filter GUI pops up. Set any condition (does not matter what), and press OK. Now re-open the standard filter GUI. How would you reset the filter? Desired: 1. Provide a "Reset" button at bottom, which clears the entries. 2. Provide a X button against each row of filter, to delete it. (When all rows are deleted, the filter is effectively reset)
Hi @narayanaras, thanks for reporting. You are right, it is not too much obvious. Go to the field of the first condition and select -non- at the top. You can use the same way to delete from any particular condition the rest of condition. Change the status to New, and the importance from normal to enhancement.
Created attachment 148318 [details] Demo of the reset button in my patch.
Created attachment 148319 [details] Demo of the "X" buttons in my patch.
I am working on this. Above I have attached a demo of the reset ("Clear") button and the "X" buttons in my patch. I hope to check this with the design team later today.
Dear Martin van Zijl, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this.
Apologies for the delay. I decided to break this into two patches: 1) For just the "Reset" button. 2) For the "X" buttons. I just submitted the patch for the "Reset" (Clear) button.
Created attachment 161244 [details] Updated demo of Reset/Clear button.
Looks find Martin, thanks. Waiting for the patch for X buttons.
I also submitted also the for the "X" buttons. This is a WIP since there are still issues with it to fix.
(In reply to Martin van Zijl from comment #9) > I also submitted also the for the "X" buttons. This is a WIP since there are > still issues with it to fix. I meant to say "I also submitted the patch for the "X" buttons". I can't see how to edit comments in Buzgilla - it's strange.
Created attachment 161311 [details] Updated demo of "X" buttons.
UX Team -- please take a look at this enhancement. I have actually already coded this (almost complete), and you can see the video demos in the attachments. Let me know if you have any suggestions for changes, before I finalize it.
(In reply to Martin van Zijl from comment #12) > UX Team -- please take a look at this enhancement. Awesome! Nitpicking: the button looks a bit squeezed. If you use a standard image it might be better. Adding icon designers to get the right image.
(In reply to Heiko Tietze from comment #13) > (In reply to Martin van Zijl from comment #12) > > UX Team -- please take a look at this enhancement. > > Awesome! Nitpicking: the button looks a bit squeezed. If you use a standard > image it might be better. Adding icon designers to get the right image. We can use sc_delete.png/sc_delete.svg for this button. Anything, your work is brilliant Martin!!
(In reply to Rizal Muttaqin from comment #14) > (In reply to Heiko Tietze from comment #13) > > (In reply to Martin van Zijl from comment #12) > > > UX Team -- please take a look at this enhancement. > > > > Awesome! Nitpicking: the button looks a bit squeezed. If you use a standard > > image it might be better. Adding icon designers to get the right image. > > We can use sc_delete.png/sc_delete.svg for this button. > > Anything, your work is brilliant Martin!! Thanks for the tip. I will use "sc_delete.png" for the button instead of "x". I also added a tooltip that says "Remove". I've pushed the updated code to Gerrit, and I'll update the video demo shortly.
Created attachment 161384 [details] Video demo of "remove" buttons for individual conditions.
(In reply to Martin van Zijl from comment #16) > Created attachment 161384 [details] > Video demo of "remove" buttons for individual conditions. Coool!! Will happy to see this patch
Martin van Zijl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1ee221ad65ff5e3a725e80777406ac7f94ff3a72 tdf#76898 add ability to reset standard filter It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Patch for individual remove buttons is ready for review, but there is a minor outstanding bug I found. If you add a new row, but do not set the value field, then delete the previous row, the value field is suddenly filled. I will attach a demo. Should it be fixed before merging?
Created attachment 161550 [details] Outstanding bug with individual "remove" buttons.
(In reply to Martin van Zijl from comment #20) > Created attachment 161550 [details] > Outstanding bug with individual "remove" buttons. What exactly is the issue?
I tested with the patch a bit and it seems to be working as intended. The filter functionality itself has some interesting bugs, which might throw testers off. I was confused by bug 53430 just now.
(In reply to Buovjaga from comment #22) > I tested with the patch a bit and it seems to be working as intended. The > filter functionality itself has some interesting bugs, which might throw > testers off. I was confused by bug 53430 just now. I also found an existing bug relating to scrolling, which I raised on the Ubuntu bug tracker: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1881811. I think it will happen on other OS's too.
(In reply to Heiko Tietze from comment #21) > (In reply to Martin van Zijl from comment #20) > > Created attachment 161550 [details] > > Outstanding bug with individual "remove" buttons. > > What exactly is the issue? Issue is as follows. Say you have conditions: X = 1 OR X = 2 You start to add a new condition... AND X = But do not add a value on the right for this condition. Then you delete the second row (X = 2). The third row you started creating should be put in the second row now. Dialog should read: X = 1 AND X = But instead reads: X = 1 AND X = 0 Second row value on the right should be empty, but is zero (or another number). It is quite a minor issue, though.
Martin van Zijl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/937b780e3f696552fc686bf0c80c3050443b111a tdf#76898 standard filter: add buttons to remove conditions It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 98239 has been marked as a duplicate of this bug. ***
Martin, is this bug fixed? Can we close it as FIXED?
Both enhancements have been implemented: 1. The "bin" buttons have been added to the side of each filter in the Standard Filter dialogue. Commit is mentioned above. Verified as fixed in: Version: 7.1.4.2 / LibreOffice Community Build ID: a529a4fab45b75fefc5b6226684193eb000654f6 CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded 2. The "Clear Filter" button has been added to the AutoFilter dropdown. Verified as fixed in: Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: bb54d6d8241a06a6772052b77b67d6a4f686426c CPU threads: 8; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-06-11_20:14:38 Calc: threaded If there are remaining / new issues, new reports should be opened. Thanks Martin! :)
I'm not sure why I mentioned the dropdown's "Clear Filter" button in Comment 28, as this is not what this bug is about. That was added with bug 141559. Confirming that both the individual "Remove" buttons and the overall "Clear" button for the Standard Filter dialog were implemented in 7.1 Removing the Target:7.2.0 keyword. Added to release notes: https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F7.1&type=revision&diff=425739&oldid=417158