Problem description: Steps to reproduce: 1. download 4.3.0.3 and install 2. open spreadsheet 3. test spelling Current behavior:all words marked as suspect and needed to be added to dictionary Expected behavior: Operating System: Windows (other) Version: 4.3.0.2 rc
Confirmed: Windows 7 LibreOffice 4.3.0.3 rc, default English language install Note: Works fine in 4.3.0 beta1 Critical - major feature not working at all Highest MAB
See also: Bug 80363 - VIEWING EDITING: spellchecker works wrong if there are Cyrillic symbols in the path to Libre folder and duplicates Bug 81619 - SPELL: Spelling dictionaries not working Bug 81616 - EDITING: Spell Checker not working in Writer 4.3.0.3 (Win8) - Underlines everything!
this looks like a stopper issue. IMHO we cannot release 4.3.0 with this bug unfixed
Wait, this looks to have been caused with http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-3-0&id=012bdc381f1ee36a1ee1157c1821fdeb49066078 just before 4.3.0.3 was buttoned up. And, looks to have been corrected already with http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-3-0&id=24e9950f68ca57c454dbb35cf8562d82e76a42e7 @László, could you confirm that please. On Windows 7 sp1, 64-bit, en-US with Version: 4.3.1.0.0+ Build ID: 0ad283adb51b3a1bb777e6341e61541d4bffaa44 TinderBox: Win-x86@42, Branch:libreoffice-4-3, Time: 2014-07-21_07:26:59 it seems OK without all words highlighted, but no dictionary's to work against with this TB build. So, with a 4.3.0.4 re-roll, should be good.
(In reply to comment #4) > ... > > So, with a 4.3.0.4 re-roll, should be good. I think an RC4 is needed... are developers aware of this?
(In reply to comment #5) > (In reply to comment #4) > > ... > > > > So, with a 4.3.0.4 re-roll, should be good. > > I think an RC4 is needed... are developers aware of this? Yes, it's fixed now but I don't see the fix on libreoffice-4-3-0 branch, only on libreoffice-4-3. I don't think it's a show stopper, in fact there may be quite a few MABs in a .0 release. Nobody expects a perfect release. It is worth mentioning in the release notes that LibreOffice will not find its spellchecker dictionaries on Windows, and 4.3.1 will have a fix a month later. FYI on libreoffice-4-3 branch, it went wrong with 5536b127a105123de6f64dcf8f53dfa277faef3c. Fixes are: 24e9950f68ca57c454dbb35cf8562d82e76a42e7 and 0ad283adb51b3a1bb777e6341e61541d4bffaa44
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > ... > Nobody expects a perfect release. Ok, but the lack of a dictionary is a quite striking flaw that every user will notice as soon as it starts typing... it's a major feature lije Joel pointed out. > It is worth mentioning in the release notes that LibreOffice will not find > its spellchecker dictionaries on Windows, and 4.3.1 will have a fix a month > later. unfortunately a lot of people do not read release notes. prepare to see a lot of complains and critics about this. I still think that we should post-pone the 4.3.0 release of a few days and integrate that fix of the 4.3.1 inside the 4.3.0 for the reputation of LibO it would be better to wait one week more for 4.3.0 instead of releasing a version that will look so uncomplete and unprofessional. just my 2 cents. please discuss these with other devs and QA guys.
I have to agree with Tommy and suggest that this is a major blocker, normally .1 release will fix trivial issues and improvements to the (new) feature set, whereas a broken spell check (element that was working well before) will affect all users and in my opinion represents a significant application failure. As a fix exists, surely this is worth putting into an RC4 before public release.
always think about first time users... people who's using LibO for the very first time... the first impact with a non functioning spellchecker which is a basic feature of any word processor could be detrimental for LibO reputation.
*** Bug 81738 has been marked as a duplicate of this bug. ***
For 4.3.0 see: https://gerrit.libreoffice.org/10556 https://gerrit.libreoffice.org/10557 ESC decided that there will be RC4 (at least on Windows, which is affected by the bug).
Verified (on Windows 7 64-bit) with LibreOffice 4.3.0.4 Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0.