Bug Hunting Session
Bug 87695 (Sidebar-Track-Changes) - SIDEBAR: Improvements to new track changes sidebar tab
Summary: SIDEBAR: Improvements to new track changes sidebar tab
Status: NEW
Alias: Sidebar-Track-Changes
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
: 101118 127098 (view as bug list)
Depends on:
Blocks: Track-Changes Sidebar-New-Decks
  Show dependency treegraph
 
Reported: 2014-12-25 08:39 UTC by Yousuf Philips (jay) (retired)
Modified: 2019-08-26 07:20 UTC (History)
11 users (show)

See Also:
Crash report or crash signature:


Attachments
track change sidebar in MS Word (11.13 KB, image/png)
2014-12-25 08:39 UTC, Yousuf Philips (jay) (retired)
Details
Mockup for the new sidebar (114.26 KB, image/png)
2015-02-22 10:48 UTC, Heiko Tietze
Details
Modification of the new sidebar for threaded reviews (28.05 KB, image/png)
2015-02-22 10:51 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-12-25 08:39:35 UTC
Created attachment 111314 [details]
track change sidebar in MS Word

Now that Kendy was able to move the track changes dialog into the sidebar, some tweaking needs to be done to it.

1) The content need to fit in the default size of the sidebar, so the content size needs to resizable with the sidebar width. A minimum size of this sidebar tab should also be set, similar to the properties tab.

2) The change list needs to be changed from a column view to a row orientation, similar to the below.

Action
Author, Date/Time (12 hour version ideally)
Comment: Comment Text

The comment line would only be shown if a track change comment was added

3) As we have lots of vertical space, the filter tab could be moved into a content panel/section that is hidden by default and is positioned below the accept/reject buttons, so the user doesnt need to switch between tabs to filter out results.

4) New icon needs to be created for the sidebar as the current one symbolizes that the dialog will be popping up. :D

5) MS Word has summary content panel/section to show the total number of inserts, deletes, etc.
Comment 1 Cor Nouws 2014-12-27 17:56:57 UTC
Hi Jay,

I like the most of the ideas, though it's hard to predict how e.g. the list will look in real life.

One suggestion:

(In reply to Jay Philips from comment #0)

> 3) As we have lots of vertical space, the filter tab could be moved into a
> content panel/section that is hidden by default and is positioned below the
> accept/reject buttons, so the user doesnt need to switch between tabs to
> filter out results.

It looks more natural to have the filter pane (hidden) at the top. Once it expands the choices are made and the result listed below..
It's how I know more filter/search panels.
Comment 2 Yousuf Philips (jay) (retired) 2014-12-28 07:54:58 UTC
Hey Cor,

(In reply to Cor Nouws from comment #1)
> I like the most of the ideas, though it's hard to predict how e.g. the list
> will look in real life.

Yes it definitely is, so we'll have to see what the control looks like in this horizontal layout and then try to tweak it.

> It looks more natural to have the filter pane (hidden) at the top. Once it
> expands the choices are made and the result listed below..
> It's how I know more filter/search panels.

Was suggesting it at the bottom as then the result list wont be shifting up and down when you open and close the filter section.
Comment 3 Cor Nouws 2014-12-28 21:52:04 UTC
(In reply to Jay Philips from comment #2)
> Was suggesting it at the bottom as then the result list wont be shifting up
> and down when you open and close the filter section.

Shouldn't be any problem given the examples I gave. So OK to do it at top ?
Comment 4 Adolfo Jayme 2014-12-29 04:05:59 UTC
> Author, Date/Time (12 hour version ideally)

Err, we should not favor AM/PM artificially. It should use the format specified by the system’s locale.
Comment 5 Yousuf Philips (jay) (retired) 2014-12-29 08:02:49 UTC
(In reply to Adolfo Jayme (UX) from comment #4)
> Err, we should not favor AM/PM artificially. It should use the format
> specified by the system’s locale.

Every LO local i switched to always showed it in 24-hour mode. The date format would change but not the time format.
Comment 6 Yousuf Philips (jay) (retired) 2015-01-01 00:46:04 UTC
(In reply to Cor Nouws from comment #3)
> Shouldn't be any problem given the examples I gave. So OK to do it at top ?

Which ever position works best is always my preference. :D
Comment 7 Heiko Tietze 2015-01-29 12:12:57 UTC
I modified the mockup at https://docs.google.com/document/d/1UuZUJYOLPM3_LdW77OSAaUBpDhRg3iHSjo31DTUEEzk/ with some options for the list of changes.
My favorite is a list view (left option) but with expanded details on click as shown with the accordion. In this case threading wouldn't be available, and we need proper sorting. If the list of changes is sorted by the time of change and users go forward step by step, which means page by page, the position in the list might have annoying jumps.
Comment 8 Yousuf Philips (jay) (retired) 2015-02-03 21:24:53 UTC
Here is a better view of how MS Word has its track change review page and also how it shows tracked formatting changes in the document. http://i.imgur.com/4sGs3GP.png
Comment 9 Heiko Tietze 2015-02-22 10:47:27 UTC
After discussion in the UX team we came up with a solution described in a blog post at http://user-prompt.com/de/tracking-changes-with-libreoffice/

Mockup attached here as well.
Comment 10 Heiko Tietze 2015-02-22 10:48:59 UTC
Created attachment 113598 [details]
Mockup for the new sidebar
Comment 11 Heiko Tietze 2015-02-22 10:51:55 UTC
Created attachment 113599 [details]
Modification of the new sidebar for threaded reviews

In case we get threaded reviews (that is the change of a change), we should to show them in a tree. But this complicates some aspects and needs further work.
Comment 12 Yousuf Philips (jay) (retired) 2015-02-22 16:33:42 UTC
Hey Heiko,

Was checking the mockup and wanted to suggest the following.

* Have a text label for the list titled 'Changes'
* Move the 'sort by' button to the right
* Add the protect and compare buttons from the toolbar into the track changes section in place of the track change comment button
* Add 'Edit Comment...' entry to the list context menu as it is currently
* Would be nice if we could turn the accept and reject buttons into split buttons and the split parts having entries for accept and reject all.
Comment 13 Heiko Tietze 2015-02-24 14:25:02 UTC
I agree with *1-4 but *5, split button, might be confusing since it works as Accept/Reject (selected) by default. The function would be the same as for the split option if all items are selected 

Split buttons are good for clear alternatives but with a default in more than 80% (arbitrary number taken from the pareto rule). And I'd say Accept/Accept All has a 50/50 distribution.
Comment 14 Yousuf Philips (jay) (retired) 2015-02-24 20:58:49 UTC
(In reply to Heiko Tietze from comment #13)
> I agree with *1-4 but *5, split button, might be confusing since it works as
> Accept/Reject (selected) by default. The function would be the same as for
> the split option if all items are selected 

Without the split button, a user would have to right-click, click select all, then click the accept all button. This is with the assumption that they already know that their is right-click context menu. Having it as a split button, just gives users another means of achieving the same thing and is easily noticeable.

> Split buttons are good for clear alternatives but with a default in more
> than 80% (arbitrary number taken from the pareto rule). And I'd say
> Accept/Accept All has a 50/50 distribution.

There are normally two types of split buttons and one of them is to provide additional options of the same function that is put as the main button of the split button. An example of this is the paste button, where the drop down gives more options of pasting.
Comment 15 V Stuart Foote 2016-07-25 18:24:05 UTC
*** Bug 101118 has been marked as a duplicate of this bug. ***
Comment 16 Robinson Tryon (qubit) 2016-08-25 05:49:21 UTC Comment hidden (obsolete)
Comment 17 Cor Nouws 2016-09-19 16:30:58 UTC
Calc has track changes too.. but doesn't use the side bar .. interesting ;)
Comment 18 Timur 2017-06-14 16:14:35 UTC
Filter set in Sidebar is not selected if Manage Track Changes open separately. It should of course be the same. 

If I see well, Manage Track Changes (and in Sidebar) has simple Action now: + and X although there exist 4 separate actions;  Formats, Insertion, Deletion, Table Changes. So, there should be 4 different icons, not just 2. 

And I couldn't figure out how Table Changes is used. Not obvious and Help not of help: https://help.libreoffice.org/index.php?title=Common/Filter.
Comment 19 Xisco Faulí 2017-07-13 10:52:24 UTC
Setting Assignee back to default. Please assign it back to yourself if you're
still working on this issue
Comment 20 Heiko Tietze 2019-08-26 07:19:01 UTC
*** Bug 127098 has been marked as a duplicate of this bug. ***
Comment 21 Heiko Tietze 2019-08-26 07:20:15 UTC
(In reply to Heiko Tietze from comment #9)
> UX team came up with a solution in... http://user-prompt.com/de/tracking-changes-with-libreoffice/

It's replicated at https://design.blog.documentfoundation.org/2015/02/19/tracking-changes-with-libreoffice/