Bug 97630 - LibreOffice uses wrong attribute for feature "shrink-to-fit"
Summary: LibreOffice uses wrong attribute for feature "shrink-to-fit"
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
QA Contact:
URL:
Whiteboard: odf
Keywords:
: 85062 101519 106147 (view as bug list)
Depends on:
Blocks: ODF-spec
  Show dependency treegraph
 
Reported: 2016-02-07 22:35 UTC by Regina Henschel
Modified: 2017-02-23 09:30 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2016-02-07 22:35:00 UTC
The presentation object "Outline" has the feature, that the font-size is reduced, if the content does not fit into the frame area.

In "ODF 1.2 extended" this is written to file as 'draw:fit-to-size="shrink-to-fit"'. But the attribute 'draw:fit-to-size' has only the values true and false. And the attribute itself is the wrong one.

The correct attribute is "style:shrink-to-fit"
Read section 20.350
"The style:shrink-to-fit attribute specifies whether content is reduced in size to fit within a cell or drawing object. Shrinking means that the font size of the content is decreased to fit the content into a cell or drawing object."

The attribute "style:shrink-to-fit" is not only usable with <style:table-cell-properties> but also with <style:graphic-properties>. 

Therefore I do not see any need for extending the kind of the value of attribute 'draw:fit-to-size'. Instead use the correct attribute and retain the old behavior of 'draw:fit-to-size'.

Besides being conform to ODF1.2, the correct attribute would make it possible to solve issue #34467, and to bring this feature to UI, so that a user can freely decide, whether he wants to use this feature or not.
Comment 1 Buovjaga 2016-02-11 09:26:39 UTC
Setting to NEW.
Comment 2 tommy27 2016-11-19 08:37:39 UTC
Bug 34467 has been fixed in 5.3.0 alpha.
would you please retest to see if the current issue had positive side effects from this?
Comment 3 Regina Henschel 2016-11-20 19:09:30 UTC
It is not fixed and no positive side effect. The invalid attribute 'draw:fit-to-size="shrink-to-fit"' is still written in case Autofix_Text is on.

Tested in Version: 5.3.0.0.alpha1+
Build ID: 92c1128fb80b4e38df219ce60f018cfb1522b20a
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-11-19_23:45:40
Locale: de-DE (de_DE); Calc: group
Comment 4 Aron Budea 2017-02-23 00:03:06 UTC
*** Bug 101519 has been marked as a duplicate of this bug. ***
Comment 5 Aron Budea 2017-02-23 00:08:48 UTC
*** Bug 85062 has been marked as a duplicate of this bug. ***
Comment 6 Aron Budea 2017-02-23 00:12:55 UTC
*** Bug 106147 has been marked as a duplicate of this bug. ***
Comment 7 Michael Meeks 2017-02-23 09:30:16 UTC
This really bit me when I had (accidentally) left my setting to non-extended for a long period ... =)