Description: Activate HarfBuzz is bad for visible Math formula Steps to Reproduce: 1. create a new Writer document 2. type formula from attach 3. select text of formula 4. select menu item Insert > Object > Formula 5. text wiil change on OLE-object (formula Math) Actual Results: with HarfBuzz see attach "with HarfBuzz" Expected Results: without HarfBuzz see attach "without HarfBuzz" Reproducible: Always User Profile Reset: No Additional Info: Version: 5.3.0.0.alpha1+ Build ID: 32bdc5097013e7efd9c85e1b8df697880e66e925 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-11-04_23:30:30 Locale: ru-RU (ru_RU); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Created attachment 128511 [details] file Writer for checking render of formula add file ODT with formula
Created attachment 128512 [details] screenshot with HarfBuzz
Created attachment 128513 [details] screenshot without HarfBuzz
Confirming with on Windows 10 Pro 64-bit (1607) with Version: 5.3.0.0.alpha1+ Build ID: 32bdc5097013e7efd9c85e1b8df697880e66e925 CPU Threads: 8; OS Version: Windows 6.2; UI Render: default; Layout Engine: new; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-11-04_23:30:30 Locale: en-US (en_US); Calc: CL So with HarfBuzz layout fonts for both GDI based "default" and OpenGL based rendering are correct but scaling of the nodes for brackets differs--scaling with GDI is a bit oversize but scaling for the OpenGL is so large it extends the glyphs outside the bounding box of the node!
With HarfBuzz we always use DirectWrite if it is available independent on the use of OpenGL, so unless you are testing on Windows XP you should be always getting DirectWrite. Indeed, our DirectWrite renderer does not do text scaling, which also explains the HarfBuzz part of bug 99351.
Not reproducible under Linux / Ubuntu: Version: 5.3.0.0.alpha1+ Build ID: a04cda96c6b70314546a8126783e573e16c78e1d Threads CPU : 4; Version de l'OS :Linux 4.8; UI Render : par défaut; VCL: gtk3; Layout Engine: new; Ubuntu_16.10_x86-64 Locale : fr-FR (fr_FR.UTF-8); Calc: group Not reproducible with GTK2 backend. Bes regards. JBF
(In reply to Khaled Hosny from comment #5) > Indeed, our DirectWrite renderer does not do text scaling, which also > explains the HarfBuzz part of bug 99351. Is it by design to ignore the scaling under new HarfBuzz layout, or due to a transient state and to be fixed?
(In reply to Takeshi Abe from comment #7) > (In reply to Khaled Hosny from comment #5) > > Indeed, our DirectWrite renderer does not do text scaling, which also > > explains the HarfBuzz part of bug 99351. > Is it by design to ignore the scaling under new HarfBuzz layout, or due to a > transient state and to be fixed? On Windows we are reusing a DirectWrite-based renderer that was originally used only to render Graphite fonts, it turns out this renderer was incoplete and is missing at at least a couple of features (scaling and rotation), the new layout engine itself supports both just fine.
*** Bug 103745 has been marked as a duplicate of this bug. ***
Tim, Martin, * While you take a look at work needed on the DirectWrite renderer implementation for rotation (bug 100986) should we hope that scaling could also be tweaked? As here and in bug 99351 handling the glyphs in the sm Math Formula editor is very dependent on correct scaling--and since it is now all DirectWrite based with HarfBuzz we've got troubles in the module with composing the formula nodes.
*** Bug 103831 has been marked as a duplicate of this bug. ***
*** Bug 103827 has been marked as a duplicate of this bug. ***
*** Bug 103814 has been marked as a duplicate of this bug. ***
*** Bug 103846 has been marked as a duplicate of this bug. ***
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=30fefcf71417f8c8644f5c0d3cb28c8c7f92a6c7 tdf#103725: Fix horizontal scaling on Windows It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This should be fixed now, please verify all the duplicates are fixed, if any is not then it should be reopened as it is not a duplicate in this case.
*** Bug 100746 has been marked as a duplicate of this bug. ***
@Khaled, issues of duplicate bugs bug 100746 and bug 103745 are not appreciably corrected by commits closing this issue. Should they individually be reopened, or will you take another whack at this? Scaling issues can be seen in attachment 126046 [details] from tdf#100746, and the sample Starmath formula from tdf#103745: widevec {P_0 P_1} widehat {P_0 P_1} {x+y+z} overbrace {} {x+y+z} underbrace {} or the issues in scaling glyphs for formula node composition as in this Starmath: nroot{3}{27 over 2} cdot sqrt{9} although that is admittedly equally an issue with node composition in sm math module.
(In reply to V Stuart Foote from comment #18) > @Khaled, issues of duplicate bugs bug 100746 and bug 103745 are not > appreciably corrected by commits closing this issue. Should they > individually be reopened, or will you take another whack at this? I tested both before closing this and AFAICT they were fixed, but re-open if they are not fixed for you and attach screenshots.
Created attachment 128714 [details] screenshot with HurfBuzz from 13.11.2016 IMHO, bug not fixed (see attach)...
Created attachment 128722 [details] new HarfBuzz text layout with OpenGL and default rendering Yes still issues with scaling, and differences between default GDI+ rendering and OpenGL rendering. But the most annoying are with the scaling for nodes of the formula editor as can be seen in this clip. Will reopen bug 100746 and bug 103745
It looks fine on my machine, I can’t test OpenGL rendering on Windows though, my setup does not support it.
Bug 103827 is fixed for me. Win 7 Pro 64-bit Version: 5.3.0.0.alpha1+ Build ID: c5f5b3e5334c52502c1de28828a44ad469c68850 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; Layout Engine: new; TinderBox: Win-x86@39, Branch:master, Time: 2016-11-14_06:24:21 Locale: fi-FI (fi_FI); Calc: group
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea95ced269dceb72681f0e4a21d87499153d5781 Revert "tdf#103725: Fix horizontal scaling on Windows" It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5750d92b2136d60d698b41ef5760f2efac0ffce tdf#103725: Fix horizontal scaling on Windows It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d436065bc1c68fc2d90e73253d8c00503c72dfd0 tdf#103725: Default to GDI even with the new layout engine It will be available in 5.3.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This is now “fixed” by using GDI when OpenGL is disabled, so we should be in parity with the old layout engine. OpenGL issues should be tackled separately. People might need to retest any issue that was fixed by the use of DirectWrite and re-open them.
Created attachment 128830 [details] harfBuzz+OpenGL_17.11.2016 (where are my brackets?!) in Version: 5.3.0.0.alpha1+ Build ID: b223028d65d24ffcd8e27974c29c2744a5df6227 CPU Threads: 4; OS Version: Windows 6.1; UI Render: GL; Layout Engine: new; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-11-16_22:50:22 Locale: ru-RU (ru_RU); Calc: group TextEngine - new all rendering OpenGL - enable in Math formula disappeared all brackets
(In reply to kompilainenn from comment #28) > Created attachment 128830 [details] > harfBuzz+OpenGL_17.11.2016 (where are my brackets?!) > > in > Version: 5.3.0.0.alpha1+ > Build ID: b223028d65d24ffcd8e27974c29c2744a5df6227 > CPU Threads: 4; OS Version: Windows 6.1; UI Render: GL; Layout Engine: new; > TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-11-16_22:50:22 > Locale: ru-RU (ru_RU); Calc: group > > TextEngine - new > all rendering OpenGL - enable > > in Math formula disappeared all brackets You have OpenGL enabled. Khaled said: "OpenGL issues should be tackled separately"
Created attachment 128832 [details] wOpenGL rendering and 2016-11-17 build (In reply to kompilainenn from comment #28) on Windows 8.1 Pro 64-bit en-US with Version: 5.3.0.0.alpha1+ Build ID: b223028d65d24ffcd8e27974c29c2744a5df6227 CPU Threads: 8; OS Version: Windows 6.2; UI Render: GL; Layout Engine: new; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2016-11-16_22:50:22 Locale: en-US (en_US); Calc: CL Don't know, why the brackets are not showing for you. With DirectWrite based OpenGL rendering I still see the badly scaled OpenSymbol glyphs clipped to the bounding box of the node. With reworked default GDI rendering the glyphs are scaled to their bounding boxes. Deselect OpenGL and retest as the default rendering alone is intended to provide correct rendering with the new HarfBuzz layout. OpenGL rendering needs some work. Additional comments in bug 100746