Bug Hunting Session
Bug 104443 - Add 'Row' tab to Table Properties dialog
Summary: Add 'Row' tab to Table Properties dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Dialog Writer-Tables-Enhancements
  Show dependency treegraph
 
Reported: 2016-12-06 18:01 UTC by Mike Kaganski
Modified: 2018-10-22 21:12 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
(Mockup) New tab Rows in Dialogue table properties in Writer (45.34 KB, image/png)
2018-10-22 10:45 UTC, Roman Kuznetsov
Details
(Mockup Source) New Page tab in dialogue Table properties in Writer (16.28 KB, application/gzip)
2018-10-22 10:46 UTC, Roman Kuznetsov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2016-12-06 18:01:22 UTC
The "Allow row to break across pages and columns" checkbox is available in Table Format dialog (Text Flow tab). It is a per-row property, and works accordingly: if no cells are selected in current table, then it works for all rows; but if any cells are selected, then it shows/sets the property for those rows only. In case when the selection includes rows with different values of the property, the checkbox is set to "undefined" third state.

But that it works like that isn't evident on the tab. One can suppose that this is per-table property (I had supposed so for many ears until today, for one), despite the "row" is used in singular there.

The proposal is to also add the same checkbox to "Row height" dialog (available in menu Table->Size->Row Height...). The checkbox could fit there rather well, despite it's not directly a height-controlling property (still, it controls vertical layout of the row). Because the dialog is specifically row-oriented, the applicability of the property would be evident. And because the property is also accessible from Table Format dialog, so the Row Height dialog wouldn't need a rename (because the added option is just a convenience option).

Added checkbox should be disabled when whole table's property to break is disabled (just like it works on Text Flow tab of Table Format).

The duplication of functionality is not a problem here: there are a number of places where we duplicate functionality. E.g.: "Go to page" vs Navigator; Column Width vs Columns tab of Table Format; font settings on toolbar vs Character format etc.

An alternative could be to add a tab to Table Format dialog named Rows, and place row-specific (height and break) controls there.
Comment 1 Heiko Tietze 2016-12-11 09:41:15 UTC Comment hidden (no-value)
Comment 2 Heiko Tietze 2016-12-19 16:17:13 UTC
Doubt that adding a checkbox to one dialog solves unclear behavior somewhere else. Not saying such a checkbox makes no sense, though.

Ideally we get a preview of how the settings look like.
Comment 3 Cor Nouws 2016-12-20 08:16:34 UTC
I think the idea is well thought about and reasonable.
Only simpler that comes to my mind, is changing wording from 
"Allow row to break across.." to
"Allow (selected) row(s) to break across.."
Ahum..
Comment 4 Yousuf Philips (jay) (retired) 2017-05-02 19:24:21 UTC
(In reply to Mike Kaganski from comment #0)
> The "Allow row to break across pages and columns" checkbox is available in
> Table Format dialog (Text Flow tab). It is a per-row property, and works
> accordingly: if no cells are selected in current table, then it works for
> all rows; but if any cells are selected, then it shows/sets the property for
> those rows only. In case when the selection includes rows with different
> values of the property, the checkbox is set to "undefined" third state.

So this checkbox should be changed to only work at the table level and be labelled 'Allow all rows to break across pages and columns'.

> But that it works like that isn't evident on the tab. One can suppose that
> this is per-table property (I had supposed so for many ears until today, for
> one), despite the "row" is used in singular there.

Yes this confused me as well.

> The proposal is to also add the same checkbox to "Row height" dialog
> (available in menu Table->Size->Row Height...). The checkbox could fit there
> rather well, despite it's not directly a height-controlling property (still,
> it controls vertical layout of the row). Because the dialog is specifically
> row-oriented, the applicability of the property would be evident. And
> because the property is also accessible from Table Format dialog, so the Row
> Height dialog wouldn't need a rename (because the added option is just a
> convenience option).

No i doubt anyone would find it if it was put in that dialog.

> An alternative could be to add a tab to Table Format dialog named Rows, and
> place row-specific (height and break) controls there.

Yes this is one of the features that i've been meaning to suggest be added as it baffled me why we have a column tab but no row tab. Also i had seen a row tab in MS Word. - http://ic.ims.hr/office/word2003/slike/37/table-properties-in-word-2003.png
Comment 5 Roman Kuznetsov 2018-10-22 10:45:08 UTC
Created attachment 145898 [details]
(Mockup) New tab Rows in Dialogue table properties in Writer
Comment 6 Roman Kuznetsov 2018-10-22 10:46:19 UTC
Created attachment 145899 [details]
(Mockup Source) New Page tab in dialogue Table properties in Writer
Comment 7 Cor Nouws 2018-10-22 21:12:46 UTC
(In reply to Roman Kuznetsov from comment #5)
> Created attachment 145898 [details]
> (Mockup) New tab Rows in Dialogue table properties in Writer

@kompilanen: looks nice - how to indicate when whole table's property to break is disabled, so that per row the boxes for breaking are disabled too ?