Bug 118335 - Writer's Groupedbar. Wrong name of item Print preview in drop-down menu File
Summary: Writer's Groupedbar. Wrong name of item Print preview in drop-down menu File
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.1.0.0.beta2+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 124811 (view as bug list)
Depends on:
Blocks: Notebookbar-Groupedbar
  Show dependency tree / graph
 
Reported: 2018-06-23 20:22 UTC by Roman Kuznetsov
Modified: 2019-04-22 10:42 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2018-06-23 20:22:00 UTC 
Description:
Writer's Groupedbar. Wrong name of item Print preview in drop-down menu File. It is "Close preview" in 6.1 beta 2

Steps to Reproduce:
0. Make sure that you activated experimental features
1. Open Writer
2. Select menu View->User interface->Groupedbar
3. Open drop-down menu File and look at item "Close preview"

Actual Results:
Item has wrong name "Close preview"

Expected Results:
Item has correctly name "Print preview"


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Julien Nabet 2018-06-23 20:57:35 UTC 
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 2 andreas_k 2018-06-25 21:31:09 UTC 
GenericCommands.xcu


      <node oor:name=".uno:PrintPreview" oor:op="replace">
        <prop oor:name="Label" oor:type="xs:string">
          <value xml:lang="en-US">Print Pr~eview</value>
        </prop>
        <prop oor:name="TooltipLabel" oor:type="xs:string">
          <value xml:lang="en-US">Toggle Print Preview</value>
        </prop>
        <prop oor:name="PopupLabel" oor:type="xs:string">
          <value xml:lang="en-US">Close Preview</value>
        </prop>
        <prop oor:name="Properties" oor:type="xs:int">
          <value>9</value>
        </prop>
      </node>

it look like NB use PopupLabel how can I change the behavior that NB use the default name?
Comment 3 Maxim Monastirsky 2018-06-25 22:16:24 UTC 
(In reply to andreas_k from comment #2)
> it look like NB use PopupLabel how can I change the behavior that NB use the
> default name?

You can try this (didn't test, but it should work):

1) Extract the "Close Preview" string to a new command like this:

      <node oor:name=".uno:ClosePrintPreview" oor:op="replace">
        <prop oor:name="Label" oor:type="xs:string">
          <value xml:lang="en-US">Close Preview</value>
        </prop>
        <prop oor:name="TargetURL" oor:type="xs:string">
          <value>.uno:PrintPreview</value>
        </prop>
        <prop oor:name="Properties" oor:type="xs:int">
          <value>1</value>
        </prop>
      </node>

2) Link the menu icon of .uno:ClosePrintPreview to .uno:PrintPreview in various links.txt files.

3) Change the various sw/uiconfig/*/popupmenu/preview.xml to use .uno:ClosePrintPreview instead of .uno:PrintPreview. (and test it to make sure it still works).

4) Remove the PopupLabel of .uno:PrintPreview.
Comment 4 andreas_k 2018-07-13 21:09:20 UTC 
I don't know how to fix it, sorry. Should be fixed
Comment 5 Xisco Faulí 2018-07-14 10:59:25 UTC 
*** Bug 118737 has been marked as a duplicate of this bug. ***
Comment 6 Xisco Faulí 2018-07-17 19:16:52 UTC 
*** Bug 118763 has been marked as a duplicate of this bug. ***
Comment 7 Xisco Faulí 2018-07-17 19:59:45 UTC 
(In reply to Maxim Monastirsky from comment #3)
> (In reply to andreas_k from comment #2)
> > it look like NB use PopupLabel how can I change the behavior that NB use the
> > default name?
> 
> You can try this (didn't test, but it should work):
> 
Hi Maxim,
Any chance you could provide a fix for this issue?
Comment 8 Maxim Monastirsky 2019-04-22 10:42:39 UTC 
*** Bug 124811 has been marked as a duplicate of this bug. ***