Description: On macOS, default buttons (blue background) have a different text color than regular buttons. LibreOffice applications use the same text color for all buttons and the end result is that they don't look quite right alongside native macOS applications. Steps to Reproduce: Compare default (blue) buttons in LibreOffice to that of any Cocoa app. Actual Results: LibreOffice default buttons have black text Expected Results: LibreOffice default buttons should have white text Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info:
Created attachment 151139 [details] Patch which resolves this issue
Great you've already got a patch for this! Thought you might be interested in submitting your patch, see https://wiki.documentfoundation.org/Development/GetInvolved Everything is detailed in this page or its links. The whole process consists on these steps: - retrieve sources and build LO locally. - create an account gerrit and config. - send a message about license - create (already done in your case!) and submit your patch on gerrit Don't hesitate to ping if you need more help, there's also dev forum mailing list and dev irc.
Ah! Good catch, fun that nobody has paid attention before.
You should use #ifdef MACOSX, though, to match existing code, not #ifdef __APPLE__.
(In reply to Julien Nabet from comment #2) > Great you've already got a patch for this! > Thought you might be interested in submitting your patch, see > https://wiki.documentfoundation.org/Development/GetInvolved > > Everything is detailed in this page or its links. > > The whole process consists on these steps: > - retrieve sources and build LO locally. > - create an account gerrit and config. > - send a message about license > - create (already done in your case!) and submit your patch on gerrit > > Don't hesitate to ping if you need more help, there's also dev forum mailing > list and dev irc. Thanks! I sent the license email and set up Gerrit. I pushed my changes to it, is there anything I have to do to link this bug report to it? (In reply to Tor Lillqvist from comment #4) > You should use #ifdef MACOSX, though, to match existing code, not #ifdef > __APPLE__. Good to know, I changed the the patch on Gerrit to use that macro instead.
Probably the same/related bug 96359
(In reply to Andrew Hyatt from comment #5) > >... > > Thanks! I sent the license email and set up Gerrit. I pushed my changes to > it, is there anything I have to do to link this bug report to it? > ... Yes, you can just prefix the first line of your commit with the tdf. Eg: tdf#125088 ... Don't bother, I did it for you. If needed, you can use "amend" option to update a patch.
Andrew Hyatt committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/89775fd396e413daaf0e71710211075450bdc0ed%5E%21 tdf#125088 Make button text white for blue buttons on macOS It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A better solution would be to add a new color to the StyleSetting and set it to black by default and white in the macOS backend. No need to that ugly ifdef...
*** Bug 114989 has been marked as a duplicate of this bug. ***
Please don’t hardcode white; call the proper variable instead. This patch has caused bug 125610.
The commit above seems to have caused bug 125795 as well.
And also bug 127302 ...
Xisco Faulí committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/ebd7af9aebb5b76255aa299dd8047cb4266215a4%5E%21 tdf#125610: Revert "tdf#125088 Make button text white for blue buttons on macOS" It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Faulí committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/+/ab5da884b16aa54aab8e9773a6e8dbf24e752c36%5E%21 tdf#125610: Revert "tdf#125088 Make button text white for blue buttons on macOS" It will be available in 6.3.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 127531 has been marked as a duplicate of this bug. ***
As it seems my bug 127351 was a duplicate, the patch works for everything but when Graphite is selected as the MacOS highlight color. (white is used instead of graphite in LO)
*** Bug 127769 has been marked as a duplicate of this bug. ***
(In reply to Alex Thurgood from comment #18) > *** Bug 127769 has been marked as a duplicate of this bug. *** The same problem occurs with dark mode, per bug 127769.
*** Bug 129654 has been marked as a duplicate of this bug. ***
*** Bug 130410 has been marked as a duplicate of this bug. ***
*** Bug 129665 has been marked as a duplicate of this bug. ***
Andrew: do you want to give a try to Tomaz's suggestion from https://bugs.documentfoundation.org/show_bug.cgi?id=125088#c9 ? No obligation of course but if you don't feel like to do it, unassign yourself from the bug so other people may take it.
Already submitted a patch for this issue too: https://bugs.documentfoundation.org/show_bug.cgi?id=125532 For this patch extended style settings have been implemented to resolve missing white text tabs as well as on push buttons too. Patch is available for Gerrit review. As both patches will be conflicting, a decision is required which one to choose.
Changing priority to 'high' since the number of duplicates is 5 or more
Let's unassign since no feedback from Andrew since the revert. Moreover, Thorsten submitted a patch here: https://gerrit.libreoffice.org/c/core/+/87001
I put this one as the dup because the tdf referenced for the fix is tdf#125532 *** This bug has been marked as a duplicate of bug 125532 ***