Description: With LO 6.3 selected buttons are rendered with white characters correctly now. Selected tabs are still rendered with black characters (see screenshot). They should be rendered correctly with white characters too. Steps to Reproduce: (1) Open a LO application, e.g. Writer (2) Open a dialog with tabs, e.g. File / Properties Actual Results: Selected tabs are rendered with black characters Expected Results: Selected tabs are rendered with white characters Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info:
Created attachment 151713 [details] Screenshot
Confirming Version: 6.3.0.0.alpha1+ Build ID: 92b0b8d78d69bd917842b09af7888b402144baeb CPU threads: 4; OS: Mac OS X 10.14.4; UI render: default; VCL: osx; Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US Calc: threaded
A patch will be submitted to Gerrit in short. Patch should resolve the following issues (see screenshot attached): (1) White text on default buttons (currently black) (2) White text on action buttons (currently black) (3) White text on default and action buttons during roll-over or pressing (4) White text on selected tabs (currently black) Some additional colors have to be defined within settings.hxx and settings.cxx. These colors are set to black as default for all VCL backends. Changing to white is implemented within macOS specific VCL backend code. Thus other VCL backends should not be affected.
Created attachment 157235 [details] Screenshot with patch
Patch submitted to gerrit: https://gerrit.libreoffice.org/c/core/+/87001
*** Bug 130466 has been marked as a duplicate of this bug. ***
Uploaded a new revision of patch with some housekeeping: https://gerrit.libreoffice.org/c/core/+/89313
Created attachment 158288 [details] Screenshot 3
Created attachment 158289 [details] Screenshot 4
Current revision of patch contains a mimic to handle non key windows on macOS correctly. Attached screenshots 3 und 4 to show buttons, which have white text as long as called dialog is visible without this mimic. This kind of behaviour is handled by passing information about renderig text on controls to the backend. It has to be clarified whether is kind of handling is really needed. Maybe it could be an implementation problem of the buttons shown by the screenshots too.
Thorsten Wagner committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8d11b953c0a69f4f5eb5ca42dec3812a62d0cd0f tdf#125532: White text on default/action buttons and selected tabs on macOS It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thorsten: do you think we can consider tdf#125088 as dup of this one?
Yes, tdf#125088 is a dup.
*** Bug 125088 has been marked as a duplicate of this bug. ***
This fix caused a regression with KDE5/QT5 VCL backends on Linux when using Breeze Dark theme - see bug 133929.
Created attachment 165021 [details] screenshot, white text on grey default button macos catalina darkmode white text on grey button and almost invisible i previously reported in bug 127769, got fixed, and now happening again reopen? thanks.
(In reply to ted bug from comment #16) > Created attachment 165021 [details] > screenshot, white text on grey default button macos catalina darkmode > > white text on grey button and almost invisible > i previously reported in bug 127769, got fixed, and now happening again Version: 7.0.0.3 Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e CPU threads: 4; OS: Mac OS X 10.15.6; UI render: default; VCL: osx Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded > > reopen? > thanks.
Fix is sheduled for 7.0.2 and 7.1