Description: When an update to some extension is available, LibO tries to detect it and provide a notification. An icon should appear in the top right corner of the LibO window with a notification text staying up for a few seconds. The icon should provide a shorthand to update the extension when clicked. Unfortunately, at least with the kde5 VCL this does not work as it should. A notification text is shown for a few secs, but there is no icon. Because of the lack of the icon, when the notification text appears, it points at nothing. And the user may wonder how to update the extension (before resorting to tools->extension manager). Furthermore, because the notification stays up just a few secs, without the icon it is also very easy for the user to miss the notification. The issue is very similar to the one in bug 113205 (closed a few months ago). With respect to it the sole difference is that before 113205 was fixed the icon was in fact there, only not visible (hovering with the mouse on the top right corner of LibO used to make a small frame appear together with the notification text). Now that the issue is re-appearing (or was never totally fixed), there is no such behavior (hovering with the mouse on the place where the icon was supposed to be does nothing). I am sure that the issue is in 6.4.3.2 with the KDE5 VCL, but probably it was in LibO at least through all the whole 6.4 series, and maybe even before. As already suggested, it may even be the case that the issue was not fully fixed from start on the KDE5 VCL (unsure because I do not get extension updates notifications that often). Note that many extensions are distributed with LibO and get upgraded when you upgrade LibO, Hence, if you update LibO frequently, as I do, and only use use a few relatively stable external extensions, the notification is hardly ever used anyways. Furthermore, trying to reproduce the issue is hard even by purposely downgrading and extension, because the notification appearance time is hard to foresee. This is why the problem may easily go unnoticed. In a nutshell, to me the issue is more with the confusion deriving in users from the lack of the icon following the notification (and the fact that the UI may seem a bit erratic as a consequence), than with the lack of a proper notification and the possibility of missing extension updates. Issue seen on Version: 6.4.3.2 Build ID: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8 CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5; Locale: it-IT (en_US.UTF-8); UI-Language: en-US Calc: threaded Steps to Reproduce: Hard for me to reproduce the issue with user actions. Even purposely downgrading an extension does not cause the extension update notification to appear shortly and when it appears it is easy to miss it since it disappears soon. Actual Results: See description Expected Results: See description Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: See description
Note that checking for the availability of extension updates form the Extension Manager also is not a completely smooth experience (see also bug 132352).
Hai Sergio, could you please provide a screenshot?
(In reply to Rizal Muttaqin from comment #2) > Hai Sergio, could you please provide a screenshot? Setting to NEEDINFO OTOH, does it happen if you execute LibreOffice from commandline with 'SAL_USE_VCLPLUGIN=gen soffice' ?
Created attachment 166767 [details] Missing button in LibO 7.0.3.1
Added screenshot. Plus this is a KDE thing. With the VCL set to gen, you get the icon.
You can't confirm your own bugs. Moving it back to UNCONFIRMED until someone else confirms it.
I've created a dummy/demo patch to make the update button show up for testing purposes: https://gerrit.libreoffice.org/c/core/+/106922 With this patch in place, starting Writer and waiting a minute makes the issue reproducible with Version: 7.2.0.0.alpha0+ Build ID: 82d8d76b8a6bb0d7b6585411666f5421a99b6d34 CPU threads: 12; OS: Linux 5.9; UI render: default; VCL: kf5 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded and Version: 7.2.0.0.alpha0+ Build ID: 82d8d76b8a6bb0d7b6585411666f5421a99b6d34 CPU threads: 12; OS: Linux 5.9; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded
This looks similar to tdf#123549. At a quick glance, gtk3 and qt5 might have to override 'SalMenu::AddMenuBarButton' to implement the button to show in their native menu bars.
(In reply to Michael Weghorn from comment #7) > I've created a dummy/demo patch to make the update button show up for > testing purposes: > https://gerrit.libreoffice.org/c/core/+/106922 Note: this might need the '--enable-online-update' autogen option.
I will add gtk support for this
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4bf54eb22cfe604dc29c4f7e3ffa687324b19636 tdf#132350 gtk: implement extra update button in menubar It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/8d20a638c6a25555f2835966fa322f7ddcf9e92e tdf#132350 gtk: implement extra update button in menubar It will be available in 7.1.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I'll leave this open because the original report is for KDE and adding GTK support doesn't solve that.
Issue is still present on KDE. Should the bug title be edited to reflect the fact that the issue is now KDE specific?
(In reply to sergio.callegari from comment #14) > Issue is still present on KDE. > > Should the bug title be edited to reflect the fact that the issue is now KDE > specific? Done.
Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9ea767cb568cef1b142190d2adb0e301baa382e2 tdf#132350 Qt implement SalMenu button interface It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.