Bug 133023 - Disable "Automatic *bold*, /italic/, -strikeout- and _underline_", aka "markdown" feature by default
Summary: Disable "Automatic *bold*, /italic/, -strikeout- and _underline_", aka "markd...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL: http://document-foundation-mail-archi...
Whiteboard: target:7.5.0 target:7.4.0.0.beta2 inR...
Keywords:
: 133202 (view as bug list)
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2020-05-14 05:26 UTC by Heiko Tietze
Modified: 2023-06-01 15:41 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2020-05-14 05:26:51 UTC
Org-mode feature (*bold*, /italic/, -strikeout-, _underscore_) was introduced with 5.4(?) but lead to some confusion. Misbehavior was reported in bug 105230, bug 117011, bug 123015, bug 123146, bug 124747 (quick search on BZ), as well as [1].

So the RFE is to disable Tools > AutoCorrect > AutoCorrect Options > Options > Automatic *bold*...  by default. Should be ChangeUnderlineWeight in [2].

[1] https://lists.freedesktop.org/archives/libreoffice-qa/2020-May/010852.html
[2] https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Writer.xcs?r=74c882c3#4281
Comment 1 Buovjaga 2020-05-14 06:58:54 UTC
Yep, seems to be rather disruptive. Like Writer suddenly turning into a chat application
Comment 2 V Stuart Foote 2020-05-14 13:06:56 UTC
The legacy OOo era autocorrect (e.g. markdown like) feature was enriched at 5.2 with italic and strike through actions with:

https://gerrit.libreoffice.org/31076

What is gained by disabling by default? It is our legacy, and like most 'autocorruption' is a beloved annoyance for new users.  Clearly controllable from the 'Autocorrect Options' dialog.
Comment 3 Heiko Tietze 2020-05-14 13:25:37 UTC
We just disable it by default. Doubt many Benjamin users know this kind of formatting and are surprised, see list of bugs. Plus, the autocorrection is a direct formatting that we don't want to support actually.
Comment 4 Telesto 2020-05-14 21:34:39 UTC
+1 from me.. However, last time I proposed this I was shot down.. final say was a poll bug 121377
Comment 5 Heiko Tietze 2020-05-15 08:03:05 UTC
Thanks for the notes, Telesto & Stuart. Will bring this again to the design meeting for a second decision. Poll on Twitter was 54.5% against.
Comment 6 Telesto 2020-05-15 08:49:25 UTC
Point is that people who know what it does, actually want to enabled it. So the search for it. Or this group is also being unaware of the on off switch too..
The group of people who are typing and are surprise by the effect don't know where to look..

Another point is that the on off switch is actually rather hidden from the user, IMHO. But no clue how to solve that. A paragraph style with 'markdown'  enabled instead of global setting..
Comment 7 V Stuart Foote 2020-05-15 12:41:13 UTC
(In reply to Telesto from comment #6)
>... A paragraph style with 'markdown' enabled instead of global setting..

But the autocorrect applies not just to text runs in a Paragraph, but for all modules: Writer, Calc, Draw, Impress.  

Only the sm Formula editor where the parser for the Command window has its own attribute syntax but should probably be tweaked to support the *bold*, /italic/, -strikeout-, _underscore_ syntax, as alternative syntax.

Would be more than a simple paragraph style to fully implement a set of Markdown syntax--for display and output processing. I guess it could be some mix of RFC 7763, and some selection from RFC 7764
Comment 8 Marc Pare 2020-05-16 20:29:30 UTC
(In reply to Heiko Tietze from comment #5)
> Thanks for the notes, Telesto & Stuart. Will bring this again to the design
> meeting for a second decision. Poll on Twitter was 54.5% against.

Thanks for taking it up to the design team. IMO, as you know' I believe that this function should be set as with the default of OFF, "Tools-->AutoCorrect-->AutoCorrect Options-->Options" set with these switches OFF (default)

My arguments as stated in https://lists.freedesktop.org/archives/libreoffice-qa/2020-May/010852.html still stand. There is no problem with making the feature available should the user wish to have it, but it is not a feature that should come already turned on by default and causing confusion to the user who is expecting a return of exactly what is typed. Let's not add in frustration into the suite where it can be avoided.

Let me know if you need any more input for the design team's review.

Common sense should prevail and there should be no need for a poll.

Marc
Comment 9 Dieter 2020-05-18 17:24:54 UTC
I support the idea. Although I won't call me a Benjamin user, I wasn't aware of that setting and I can imagine, that it could be very annoying.
Comment 10 Telesto 2020-05-20 20:45:37 UTC
*** Bug 133202 has been marked as a duplicate of this bug. ***
Comment 11 V Stuart Foote 2020-05-20 21:15:26 UTC Comment hidden (off-topic)
Comment 12 Telesto 2020-05-21 07:10:49 UTC Comment hidden (off-topic)
Comment 13 V Stuart Foote 2020-05-21 12:37:58 UTC Comment hidden (off-topic)
Comment 14 Heiko Tietze 2020-05-28 12:39:51 UTC
Majority votes for switching off, and we received some tickets and requests about this. So let's switch markdown off for the Benjamins. The advanced users will be able to switch it on anyway.
Comment 15 Commit Notification 2022-07-04 15:53:57 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/de6f30bc459ba600193c0998b285afcfe0936c3e

Resolves tdf#133023 - Autocorrect "Automatic *bold*..." off by default

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 Commit Notification 2022-07-05 09:21:26 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/f3ee245f2a97562c265f03a7317791e557f83e65

Resolves tdf#133023 - Autocorrect "Automatic *bold*..." off by default

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Dieter 2022-08-08 06:46:09 UTC
VERIFIED with

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a56d0c34716f381accbd9d2e3040a62d3583d18d
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

Heiko, thanks for fixng it!