Description: DOCX: Frame with image is going down when pressing up and pressing down going up without image being in frame Steps to Reproduce: 1. Open the attached file 2. Select figure 3 frame 3. Press arrow down/arrow up Actual Results: Moving into the wrong direction Expected Results: Should move properly and not outside frame Reproducible: Always User Profile Reset: No Additional Info: Found in 7.1 and in 4.4.7.2 not in 4.3.7.2
Created attachment 163562 [details] Example file DOCX
Created attachment 163563 [details] Bibisect log Bisected to: source-hash-7596e26fd259ce5445212949403e7cd32303b2bd commit 7596e26fd259ce5445212949403e7cd32303b2bd Author: Miklos Vajna <vmiklos@collabora.co.uk> AuthorDate: Tue Jun 24 17:11:25 2014 +0200 Commit: Miklos Vajna <vmiklos@collabora.co.uk> CommitDate: Tue Jun 24 17:47:40 2014 +0200 Add SwTextBoxHelper::findShapes It builds a textbox -> shape map, so methods interested to pick the shape instead of a shape's textbox can call it and act accordingly if their textbox is in the map. Change-Id: I0f30d64a284eb461f462ed6c0a36c88271153f04
Created attachment 163564 [details] Source ODT file
Reproduced in Version: 7.1.0.0.alpha0+ Build ID: 58937aa4a50ecd681382f03331340da4c843b01e CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Adding Cc: to Miklos Vajna
The image no longer falls out of the shape in current master. The Down arrow moves it up and the Up arrow moves it down still.
Looks solved Version: 7.2.0.0.alpha0+ (x64) Build ID: f2171af6ce3516598d9f8bac8294025a21a5b1a2 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Spoke to soon (testing ODT instead of DOCX) :-( Version: 7.2.0.0.alpha0+ (x64) Build ID: f2171af6ce3516598d9f8bac8294025a21a5b1a2 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
I got a second additional commit in bug 139537 which might be of relevance
@Miklos FWIW: No clue how everything is connected.. so only informing.. bug 138951 might be related (NISZ is working on that)
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3303a4c5f21874453e634d84408c50e7a0055a4d tdf#135153 DOCX import: avoid line-of-text relation with to-para anchoring It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Telesto from comment #9) > @Miklos > FWIW: No clue how everything is connected.. so only informing.. bug 138951 > might be related (NISZ is working on that) Aha, makes sense to re-test that bug, then. This bug is meant to be fixed on master now.
Verified in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 4e1294b7d6f8de981147f15d4ca1b4e4853249eb CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Miklos, thanks for fixing this issue!!
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/ce5267c70e3fcde3211a80b69e9d242f23258853 tdf#135153 DOCX import: avoid line-of-text relation with to-para anchoring It will be available in 7.1.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.