Bug 136778 - Crash undo delete table in footnote
Summary: Crash undo delete table in footnote
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords: haveBacktrace
Depends on:
Blocks: Footnote-Endnote Crash-Assert CPU-AT-100% Crash-BigPtrArray
  Show dependency treegraph
 
Reported: 2020-09-15 15:44 UTC by Telesto
Modified: 2021-03-30 09:34 UTC (History)
6 users (show)

See Also:
Crash report or crash signature: BigPtrArray::Index2Block


Attachments
Example file (11.49 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-09-15 15:45 UTC, Telesto
Details
bt with debug symbols (9.34 KB, text/plain)
2020-09-29 19:08 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-09-15 15:44:32 UTC
Description:
Crash undo delete table in footnote

Steps to Reproduce:
1. open the attached file
2. Click inside the table in footnote
3. Delete the table
4. Undo

Actual Results:
Crash

Expected Results:
No crash (and ideally proper table support)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: abcc4eb907661e07ad850ccce7eb06f129da4286
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-09-15 15:45:03 UTC
Created attachment 165538 [details]
Example file
Comment 2 Thomas Lendo 2020-09-25 22:56:16 UTC
On Linux, LibreOffice is not crashing but hanging forever.

Version: 7.1.0.0.alpha0+
Build ID: 83aa172697c11a9550c27a28f8e62b523ec7086d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-09-10_21:26:34
Calc: threaded

Confirmed.
Comment 3 Thomas Lendo 2020-09-25 23:06:47 UTC
Version: 7.0.0.3
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: en-US

is also hanging forever with 100 % cpu.

But

Version: 6.3.0.4
Build ID: 057fc023c990d676a43019934386b85b21a9ee99
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: de-DE (de_DE.UTF-8); UI-Language: en-US

is crashing with Crash in: BigPtrArray::Index2Block
"This bug was filed from the crash reporting server and is br-24724571-81b4-45e1-a613-b4c7b65a9382."
Comment 4 Xisco Faulí 2020-09-29 10:07:20 UTC
Reproduced in

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 5.7; Render: default; 

Locale: en-US (en_US.UTF-8)
Comment 5 Xisco Faulí 2020-09-29 10:09:31 UTC
and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 6 Julien Nabet 2020-09-29 19:08:56 UTC
Created attachment 165955 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 7 Telesto 2020-12-20 18:59:03 UTC
BTW it's possible to 'insert' a table by copy a table in main document and pasting it in the footnote with RTF paste
Comment 8 Telesto 2021-01-15 10:54:13 UTC
Still around
Version: 7.2.0.0.alpha0+ (x64)
Build ID: f2171af6ce3516598d9f8bac8294025a21a5b1a2
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 9 NISZ LibreOffice Team 2021-03-29 12:16:47 UTC
This seems to be gone in todays nightly:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 387505095b484d4a6c47da5ab1b8474b450f0e9f
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Likely after:

https://git.libreoffice.org/core/commit/e11c51eefe8c3210cef2b5850f401ba67a401d01

tdf#95806 tdf#125877 tdf#141172 DOCX: fix tables in footnotes

(bibisect repo on Win is from 03-09, that version falls into endless loop upon deleting the table)
Comment 10 Xisco Faulí 2021-03-29 13:38:11 UTC
(In reply to NISZ LibreOffice Team from comment #9)
> This seems to be gone in todays nightly:
> 
> Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: 387505095b484d4a6c47da5ab1b8474b450f0e9f
> CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL:
> win
> Locale: en-US (hu_HU); UI: en-US
> Calc: CL
> 
> Likely after:
> 
> https://git.libreoffice.org/core/commit/
> e11c51eefe8c3210cef2b5850f401ba67a401d01
> 
> tdf#95806 tdf#125877 tdf#141172 DOCX: fix tables in footnotes
> 
> (bibisect repo on Win is from 03-09, that version falls into endless loop
> upon deleting the table)

I do confirm the issue is fixed by the mentioned commit
Comment 11 Commit Notification 2021-03-29 16:24:59 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ad146b4e73c0f661ea05d69fcb9a6af1b85a5fda

tdf#136778: sw_uiwriter3: Add unittest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 László Németh 2021-03-30 09:34:22 UTC
(In reply to Xisco Faulí from comment #10)

> I do confirm the issue is fixed by the mentioned commit

Xisco: many thanks for verifying it and for the unit test!