Description: Setting to repeat heading in writer tables no longer works Steps to Reproduce: 1.Insert a table into a newly created odt file spanning over more than one page 2.Add a heading 2.Right click into the table - select table properties 3.Choose repeat heading 1st row Actual Results: Nothing Expected Results: Heading should repeat in the second page Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.1.0.3 / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 12; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: el-GR (el_GR.UTF-8); UI: en-US Flatpak Calc: threaded
please clarify if you mark Insert Heading when you create a table? or you somehow make it later, how?
OK, I found steps. @reporter: it's important that you write all the details, so that we don't loose time on guessing. 0.Open new ODT 1.Table-Insert, spanning over more than one page (ex. 60 rows), mark Heading, unmark Repeat.. 2.Add some heading text (ex. h) and see that you don't see in on 2nd page 2.Right click into the table - select Table Properties 3.Choose Repeat Heading 1st row I confirm with those steps in LO 7.2+, both Windows and Linux, regression from 7.1. Note that save and reopen rectifies this, so minor issue. No problem if Repeat.. is marked when creating the table. Bibisect 7.1 Linux: commit 0bcdeefb5ed2399af63286c30298802513e6c58c Date: Tue Nov 3 00:47:07 2020 +0100 source f899c28f210c6565b7227d7665d449f194d2af8e previous source 587b8eb1d0c7959967299ebfcd03c52dc4b1cab4 author Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org> 2020-11-02 19:56:16 +0100 ndtbl: remove remaining use of ModifyNotification
I never new you can select insert heading when creating the table...and indeed if you do, the problem does not arise in 7.1. Nonetheless, prior to 7.1 you did not have to specify that the first row is a heading when creating the table. So, I actually refer to a regression between 7.1 and prior versions and not 7.2 and 7.1.
As it is now, it is impossible to add a heading to an existing table. Considering that when you use insert table over a tab separated lit of words, calc defaults to not using a heading, does anybody have a workaround for this..until it gets properly fixed?
(In reply to Timur from comment #2) > OK, I found steps. @reporter: it's important that you write all the details, > so that we don't loose time on guessing. > > 0.Open new ODT > 1.Table-Insert, spanning over more than one page (ex. 60 rows), mark > Heading, unmark Repeat.. > 2.Add some heading text (ex. h) and see that you don't see in on 2nd page > 2.Right click into the table - select Table Properties > 3.Choose Repeat Heading 1st row > > I confirm with those steps in LO 7.2+, both Windows and Linux, regression > from 7.1. > Note that save and reopen rectifies this, so minor issue. > > No problem if Repeat.. is marked when creating the table. > > Bibisect 7.1 Linux: > commit 0bcdeefb5ed2399af63286c30298802513e6c58c > Date: Tue Nov 3 00:47:07 2020 +0100 > source f899c28f210c6565b7227d7665d449f194d2af8e > previous source 587b8eb1d0c7959967299ebfcd03c52dc4b1cab4 > author > Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org> > > 2020-11-02 19:56:16 +0100 > ndtbl: remove remaining use of ModifyNotification I do confirm the issue started to hapeen after the mentioned commit. @Björn, could you please take a look at this issue ?
*** Bug 140827 has been marked as a duplicate of this bug. ***
*** Bug 142107 has been marked as a duplicate of this bug. ***
For regression bugs, I'd like to see a revert in 7.1.6 if not resolved by 7.1.5.
(In reply to Timur from comment #8) > For regression bugs, I'd like to see a revert in 7.1.6 if not resolved by > 7.1.5. Not so trivial at this point, git revert f899c28f210c6565b7227d7665d449f194d2af8e no longer works and the build fails with /home/xisco/libreoffice/sw/source/core/docnode/ndtbl.cxx:2909:30: error: ‘class SwTableFormat’ has no member named ‘ModifyNotification’ rTable.GetFrameFormat()->ModifyNotification( &aChg, &aChg ); ^~~~~~~~~~~~~~~~~~ make[1]: *** [/home/xisco/libreoffice/solenv/gbuild/LinkTarget.mk:301: /home/xisco/libreoffice/workdir/CxxObject/sw/source/core/docnode/ndtbl.o] Error 1 make: *** [Makefile:122: sw.build] Error 2
*** Bug 142330 has been marked as a duplicate of this bug. ***
Let's bumped the priority to highest
As a regression that's visible to users, it's highest, but it's not critical because save and reopen will fix it, or header can be created with table.
*** Bug 142474 has been marked as a duplicate of this bug. ***
Just wanted to be on the CC.
The problem is the ModifyNotification that was called on the frame didnt notify the observers of the frame as an observer pattern should, but instead used to force fed the hint down the throat of the message handler of the frame itself. Of course to do that, no fancy messaging is needed at all. I think I will provide a patch this weekend.
https://gerrit.libreoffice.org/c/core/+/118370
Bjoern Michaelsen committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/25e09087d8e2c5cecca1d548c69a263c7bf8b7ca tdf#140506: fix repeated table header switching It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bjoern Michaelsen committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/dd4d221f77501eb36c816ade48869d385462f18c tdf#140506: fix repeated table header switching It will be available in 7.1.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bjoern Michaelsen committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/3d98d35cfab126764ae5a35cee0a4da56baab648 tdf#140506: fix repeated table header switching It will be available in 7.2.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks for timely fix so that 7.1 is Ok.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/eac5977bfc11797eda356560a5e45c51108ef5a1 tdf#140506: sw: Add UItest It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Bjoern Michaelsen committed a patch related to this issue. It has been pushed to "libreoffice-7-1-5": https://git.libreoffice.org/core/commit/8d894294fa4cb006d1ddca846f8e44ed2b57d063 tdf#140506: fix repeated table header switching It will be available in 7.1.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks for fixing this. Verified in Version: 7.1.5.2 (x64) / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: threaded
Actual Results: No mouse-over effect Expected Results: A mouse-over effect, similar to the toolbar palette Reproducible: Always User Profile Reset: No Additional Info: http://www-look-4.com/ Version: 6.0.0.0.alpha0+ Build ID: 343d40206a929969e1755b073edae91cc4bd9751 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-07-26_05:51:20 Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Description: When hoovering in the (font) color picker in the toolbar a visual indication is giving which color is selected. Similar behavior doesn't exist in the Area Tab http://www.compilatori.com/ Steps to Reproduce: 1. Open Writer 2. Format -> Page -> Area tab -> Color button 3. Hoover over the palette. No mouse over effect Actual Results: No mouse-over effect Expected Results: A mouse-over effect, similar to the toolbar palette http://www.wearelondonmade.com/ Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.0.0.alpha0+ Build ID: 343d40206a929969e1755b073edae91cc4bd9751 http://www.jopspeech.com/ CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-07-26_05:51:20 Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Description: When hoovering in http://joerg.li/ the (font) color picker in the toolbar a visual indication is giving which color is selected. Similar behavior doesn't exist in the Area Tab Steps to Reproduce: 1. Open Writer 2. Format -> Page -> Area tab -> Color button 3. Hoover over the palette. No mouse over effect Actual Results: http://connstr.net/ No mouse-over effect Expected Results: A mouse-over effect, similar to the toolbar palette Reproducible: Always http://embermanchester.uk/ User Profile Reset: No Additional Info: Version: 6.0.0.0.alpha0+ Build ID: 343d40206a929969e1755b073edae91cc4bd9751 CPU threads: 4; OS: Windows 6.19; UI render: default; http://www.slipstone.co.uk/ TinderBox: Win-x86@42, Branch:master, Time: 2017-07-26_05:51:20 Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Description: http://www.logoarts.co.uk/ When hoovering in the (font) color picker in the toolbar a visual indication is giving which color is selected. Similar behavior doesn't exist in the Area Tab Steps to Reproduce: 1. Open Writer http://www.acpirateradio.co.uk/ 2. Format -> Page -> Area tab -> Color button 3. Hoover over the palette. No mouse over effect Actual Results: No mouse-over effect Expected Results: https://waytowhatsnext.com/ A mouse-over effect, similar to the toolbar palette Reproducible: Always User Profile Reset: No Additional Info: Version: 6.0.0.0.alpha0+ https://www.webb-dev.co.uk/ Build ID: 343d40206a929969e1755b073edae91cc4bd9751 CPU threads: 4; OS: Windows 6.19; UI render: default; TinderBox: Win-x86@42, Branch:master, Time: 2017-07-26_05:51:20 Locale: nl-NL (nl_NL); Calc: CL User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 http://www.iu-bloomington.com/