> There are only two hard things in Computer Science: > cache invalidation and naming things. > - Phil Karlton https://www.karlton.org/2017/12/naming-things-hard/ Due to the mentioned hard problem, our code base has lots of automated tests named like `tdf123456`, where tdf refers to this bug tracker and the number to the ID of a report. It would be nice to change this for the better, so readers of the code could get an idea of what a test is about at a glance. Doing a search like this reveals multiple things: git grep -Ei 'tdf[0-9]+' '*qa*.cxx' '*uitest*.py' Some of the names do include text hinting about the topic. Some of the test documents need to be renamed as well. Many Python UI test files are named like `tdf123456` and need to be renamed as well. To find only the lonesome cryptic names we may use this search: git grep -Ei 'tdf[0-9]+[\(\)"]' '*qa*.cxx' '*uitest*.py' The suggestion is to rename tests and files in the style of `tdf123456_hint_on_what_the_test_is_about` The task can be a nice opportunity for new developers to get familiar with automated testing. While thinking about a better name, read and understand the test code and the bug report and run the single test as explained in the wiki articles: https://wiki.documentfoundation.org/Development/Cpp_Unit_Tests https://wiki.documentfoundation.org/Development/UITests
Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/15ee592a791acd921ed5356f374f18f660e5fc4f tdf#168520 basic: rename testTdf149157* and testTdf149402* tests to It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 202945 [details] descriptions for 172 unamed .py For reference, attached the list of 172 unamed .py cd sw/qa/uitest && find -name tdf*.py | perl -pe 's/..//; ($i)=/(\d+).py$/; $d=`./wgetbz $i `; $_= "$d,$_" ' > desc.csv with ./wgetbz => wget -qO - "https://bugs.documentfoundation.org/buglist.cgi?bug_id=$1&ctype=csv&columnlist=short_desc,bug_id" | tail -1 see https://wiki.documentfoundation.org/QA/Bugzilla/Export
Created attachment 202946 [details] 170 unamed .py, with tentative identifiers (generated by gemini) e.g. calc_default_image_anchor_to_cell Make anchor to cell the default for copy-paste and drag-and-drop images in Calc writer_tests2/tdf133299.py template_manager_cannot_rename_user_categories Cannot rename user-defined categories in template manager writer_tests2/tdf146375.py insert_caption_separator_option_resets Insert - Caption - Options - Separator does not work (resets to previous values) writer_tests2/tdf153244.py
(In reply to fpy from comment #3) > Created attachment 202946 [details] > 170 unamed .py, with tentative identifiers (generated by gemini) > > e.g. > calc_default_image_anchor_to_cell Make anchor to cell the default for > copy-paste and drag-and-drop images in Calc writer_tests2/tdf133299.py > template_manager_cannot_rename_user_categories Cannot rename user-defined > categories in template manager writer_tests2/tdf146375.py > insert_caption_separator_option_resets Insert - Caption - Options - > Separator does not work (resets to previous values) > writer_tests2/tdf153244.py https://wiki.documentfoundation.org/Development/AI_policy "You must not use an LLM to solve easy hacks."
Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3e8a15d37d11ee05cb70a1a52e7070cdd887848a tdf#168520 - Rename tdf168478 to tdf168478_restore_multiple_cell_selection It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0bda7192ca2a4a46bd3a3a11e6d0cddb4f2f4889 tdf#168520 - Rename tdf117328 to tdf117328_restore_empty_cells It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Andreas Heinisch committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/091ad8440e15762daad5f20cabb12e201686b234 tdf#168520 - Rename tdf165846 to tdf165846_nu_min_value It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Okhuomon Ajayi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0b9bab04928312054cdeaf496d462fd8984029e3 tdf#168520: rename tdf89383 test to tdf89383_readonly_password_ooxml It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Okhuomon Ajayi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3eeb0700e66c155328a17de6757c4e8c543899fb tdf#168520: rename tdf126226 and tdf144691 tests to It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Okhuomon Ajayi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/70fae1572c4fb6e6ff9f6615f1b2b92bcbfdc107 tdf#168520: rename tdf120731, tdf124586, tdf125104 and tdf128431 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Okhuomon Ajayi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/87ffdf9e44259ed2bbec7a3c69dcb5d33e255061 tdf#168520: rename tdf126017, tdf126168 and tdf131041 tests to It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Okhuomon Ajayi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1baa44621b6121f73a7e987586c355005bcf28b4 tdf#168520: rename tdf141957, tdf150331 and tdf157569 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Okhuomon Ajayi committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2954ca548ed7575702a3dc66d37960a21bf89021 tdf#168520 Rename tdf101313, tdf107847, tdf118883, tdf124675 tests to It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e57dfc93ee689d50a195806f32945d4864577c2c tdf#168520 Rename UI test 133855.py with more speaking name It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/95cfca6c761c4dab9eaafa89aaadd767e2477b68 tdf#168520 Rename UI test for 153622 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2a640a4e790c745dc77c836d4d083dd8e21b07b7 tdf#168520 Rename UI test for 46138 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c9e67dc3fc67cc006eb421b63309992d48b7e55c tdf#168520 Rename UI tests for calc_tests2 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/79903c8428e8420fed4831749ccccd6fb051db78 tdf#168520 Rename UI tests for calc_tests3 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e3782c01b0dd8f25f95d2dcedee968b9ddcbb4e0 tdf#168520 Rename UI tests for calc_tests4 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/73021bbd6fc6cef059c58a20ee15ed78e298d919 tdf#168520 Rename UI tests for calc_tests6 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/964ae4e27d68ebf3f096e93f53128449ae5f4785 tdf#168520 Rename calc UI tests for conditional_format It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0f4b7e25d73cca0875ba7193e0098bd4be4e27c0 tdf#168520 Improve some recently changed UI test file names It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9358373c2c4342d0b31c286f3968f64c130e5686 tdf#168520 Improve UI test file name It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/42d9d2aeaca26c6693d76ffa160bbb7f0c382f3f tdf#168520 Rename UI tests in calc_tests8 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0124e2fe50f6cc949eaceeb81795479e5f82403c tdf#168520 Rename UI tests in calc_tests7 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Roman committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8eedfb9ef4e2ac8b18ff5a7d4496a92e6530de26 tdf#168520 Rename UI tests in calc_tests9 It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.