Bug 90864 - GALLERY: image titles not translated
Summary: GALLERY: image titles not translated
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 114447 (view as bug list)
Depends on:
Blocks: Gallery Not-Localizable
  Show dependency treegraph
 
Reported: 2015-04-25 14:32 UTC by Yousuf Philips (jay) (retired)
Modified: 2022-12-05 09:33 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-04-25 14:32:11 UTC
As the gallery uses the filename of the image as its tooltip, these tooltips in icon view and is name in detailed view are in english.
Comment 1 Joel Madero 2015-04-27 06:36:07 UTC
From my recollection we don't report translation issues so early in the cycle but I'll move to NEW and cc Sophie for guidance.
Comment 2 sophie 2015-04-27 06:42:08 UTC
Hi Jay, Joel, localization is not yet done for 5.0, so no need to report missing strings before at least the RC2. Maybe check if the strings are marked for translation to make sure they'll make their way to Pootle. I let you decide if you want to close the issue or let it open to monitor the translation. Sophie
Comment 3 Yousuf Philips (jay) (retired) 2015-04-27 07:29:05 UTC
I'm presuming the gallery filenames have never been translated, which is why i've brought this issue up. ;D

I just opened 4.4.2 in french and the gallery file tooltips are in english.
Comment 4 sophie 2017-12-01 10:03:01 UTC
(In reply to Yousuf Philips (jay) from comment #3)
> I'm presuming the gallery filenames have never been translated, which is why
> i've brought this issue up. ;D
> 
> I just opened 4.4.2 in french and the gallery file tooltips are in english.

Great, thanks :) Sophie
Comment 5 Yousuf Philips (jay) (retired) 2017-12-13 22:45:46 UTC
*** Bug 114447 has been marked as a duplicate of this bug. ***
Comment 6 Xisco Faulí 2020-03-09 13:28:14 UTC
Please add keyword 'needsUXEval' and CC 'libreoffice-ux-advise@lists.freedesktop.org' if input from UX is needed.
Comment 7 Buovjaga 2020-12-01 12:22:01 UTC
The way to implement this would be to include the gallery item titles and their localisations inside the gallery packages. I guess if the gallery code renovation is finished, this will become a more pleasant task: https://gist.github.com/aditya-sahu/b36dfe02c4f58b869bde18d47030a04a

The current code for reading the titles seems to be in
svx/source/gallery2/galobj.cxx

void SgaObjectSvDraw::ReadData( SvStream& rIn, sal_uInt16& rReadVersion )
{
    SgaObject::ReadData( rIn, rReadVersion );

    if( rReadVersion >= 5 )
        aTitle = read_uInt16_lenPrefixed_uInt8s_ToOUString(rIn, RTL_TEXTENCODING_UTF8);
}

and then read_uInt16_lenPrefixed_uInt8s_ToOUString and friends in
include/tools/stream.hxx

/// Attempt to read a pascal-style length (of type prefix) prefixed sequence of
/// 8bit units to an OString, returned OString's length is number of units
/// successfully read.
Comment 8 Buovjaga 2020-12-01 14:09:21 UTC
Let's re-evaluate this with l10n people first. It might turn out to be wontfix.
Comment 9 Buovjaga 2020-12-13 12:08:47 UTC
(In reply to Buovjaga from comment #8)
> Let's re-evaluate this with l10n people first. It might turn out to be
> wontfix.

Not much discussion in the l10n list, but all the translators want the titles to be translated. I still maintain that this should only be done after the switch to the new gallery package format.
Comment 10 Martin Srebotnjak 2020-12-13 12:11:49 UTC
Exactly.
Please do extend/design the new gallery package format with the translation support.