"Quotation" style is not applied by menu operation. 1. Start Writer. 2. Enter characters and select it. 3. Select Menu "Styles-Quotation". It does not function. Env. Version: 5.1.0.0.alpha1 Build ID: a8e4f75fe264f6ece37c154951cff53f2f4fa3e4 Locale:ja-JP (ja_JP.utf8) Debian wheezy
also reproduced in the following environment. Version: 5.1.0.0.alpha1 (Win_x86) Build ID: a8e4f75fe264f6ece37c154951cff53f2f4fa3e4 Locale: ja-JP (ja_JP) Windows 8.1 on 64bit-CPU
On pc Debian x86-64 with master sources updated today, I don't reproduce this. When I select "Quotations" style, the text is indented. Perhaps locale UI dependent?
This problem occurs not with "Quotations" but with "Quotation". Character Styles. Also we couldn't apply "Default Caracter" style after other slyles. It looks not to occur when using interface language "English(USA)" with Locale:ja-JP. So, maybe language dependent.
On pc Debian x86-64 with master sources updated yesterday, I don't reproduce this with French UI or Italian UI. Perhaps I missed something or would it be a specific bug to certain UI locales?
I was reproduced in the following versions. Version: 5.1.0.0.beta2 Build ID: 53054959a12edc6510f51b94ddc9b73d27aedaf6 Locale: ja-JP (ja_JP.UTF-8) Debian GNU/Linux 8.2 (jessie) x86-64 I don't reproduce in the English version. Version: 5.1.0.0.beta2 Build ID: 53054959a12edc6510f51b94ddc9b73d27aedaf6 Locale: en-US (ja_JP.UTF-8) Debian GNU/Linux 8.2 (jessie) x86-64
I can reproduce with Swedish localization on Windows. The problem seems to appear because the English string was changed from Citation to Quotation at some point but not completely. The internal name is still Citation making the command in the menu work only when the local name of the style is Quotation. I asked for guidance on the developers list.
@Maxim: Your thoughts on this?
(In reply to Yousuf Philips (jay) from comment #7) > @Maxim: Your thoughts on this? Each built-in style has 2 names. One is "internal" non-localizable name, and another "display" name which can be translated (and some styles have also a third name, i.e. the label we give to style commands in *Commands.xcu). In order to work with all locales, the .uno:StyleApply command should get the internal name. So "Quotation" is the display name, and should be replaced with the internal name which is "Citation". wrt "Default Style" (comment 3 and Bug 108301 comment 0), Writer seems to return the translatable name also when asking for the internal name. So we need to change that, so it won't return it unless we explicitly ask for the display name.
(In reply to Maxim Monastirsky from comment #8) > Each built-in style has 2 names. One is "internal" non-localizable name, and > another "display" name which can be translated (and some styles have also a > third name, i.e. the label we give to style commands in *Commands.xcu). In > order to work with all locales, the .uno:StyleApply command should get the > internal name. So "Quotation" is the display name, and should be replaced > with the internal name which is "Citation". So where can i find these internal names so i can correct all of them. > wrt "Default Style" (comment 3 and Bug 108301 comment 0), Writer seems to > return the translatable name also when asking for the internal name. So we > need to change that, so it won't return it unless we explicitly ask for the > display name. So i guess i should reopen bug 108301 for that issue right?
(In reply to Yousuf Philips (jay) from comment #9) > So where can i find these internal names so i can correct all of them. The Add commands dialog uses the right names. You can insert a toolbar button, and then look at the xml. > > wrt "Default Style" (comment 3 and Bug 108301 comment 0), Writer seems to > > return the translatable name also when asking for the internal name. So we > > need to change that, so it won't return it unless we explicitly ask for the > > display name. > > So i guess i should reopen bug 108301 for that issue right? Currently bug 108301 seems like a mix of different issues with commands, labels etc. I don't mind if we reopen bugs, but each bug needs to be concentrated on a single issue.
(In reply to Maxim Monastirsky from comment #10) > The Add commands dialog uses the right names. You can insert a toolbar > button, and then look at the xml. Roger. > Currently bug 108301 seems like a mix of different issues with commands, > labels etc. I don't mind if we reopen bugs, but each bug needs to be > concentrated on a single issue. Well Thomas created bug 108449 think that was the issue and you closed it, so please create a new bug with the specific issue that needs to be addressed, as you know best. :D
Patch is in, but wont be able to be backported as it would trigger retranslation. https://gerrit.libreoffice.org/#/c/38655/
Yousuf Philips committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=90b083bd8e922ec4adf245aedfff14c6c6c01bf6 tdf#95489 use internal name for quotation character style It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Yousuf Philips (jay) from comment #12) > Patch is in, but wont be able to be backported as it would trigger > retranslation. > https://gerrit.libreoffice.org/#/c/38655/ According to https://wiki.documentfoundation.org/ReleasePlan/5.4, Hard English string & UI freeze is planned next week. Doesn't it mean this patch could be backported to 5.4 branch?
(In reply to Julien Nabet from comment #14) > According to https://wiki.documentfoundation.org/ReleasePlan/5.4, Hard > English string & UI freeze is planned next week. Doesn't it mean this patch > could be backported to 5.4 branch? Comment 12 was related to 5.3, so yes it will be in 5.4, but had problem backporting it in gerrit, so have to see what is going wrong.
5.4 patch - https://gerrit.libreoffice.org/40552
Yousuf Philips committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9ab228fdd6efe9a7873e3de1bb2357531a79feac&h=libreoffice-5-4 tdf#95489 use internal name for quotation character style It will be available in 5.4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Yousuf Philips committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb5a864f3b4aba6e5fb0ec5cc2617d94ab4d9c23&h=libreoffice-5-4 tdf#95489 fix internal name for quotation character style It will be available in 5.4.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Just simplify targets.
Still "Default Style" and "Quotation" character styles don't work over menu Styles. They work with Styles & Formatting sidebar. "Quotation" works with context menu. "Default Style" still doesn't work over menu, toolbar and context menu, but I think that's another bug. "Quotation" character style in menu Styles still is invisible, but I also think that's another bug. Version: 5.4.2.1 (x64) Build-ID: dfa67a98bede79c671438308dc9036d50465d2cb CPU-Threads: 8; Betriebssystem:Windows 6.19; UI-Render: Standard; Gebietsschema: de-AT (de_DE); Calc: group
All I mentioned in comment 20 (which was a test with 5.4.2 RC1, German UI) works well in Version: 6.0.0.0.alpha0+ (2017-Sep-21) Build ID: 46fa042b94a0364c09482e8a09f8874119db231c CPU threads: 4; OS: Linux 4.10; UI render: default; VCL: gtk3; Locale: de-DE (de_DE.UTF-8); Calc: group except of the Default character style--that issue is covered in bug 108461. Don't know why it didn't work before. One note: Instead of Quotation being invisible in menus, now it's only shown with the English string "Quotation" in menu, context menu, style formatting toolbar. Both in 5.4.2 RC1 and 6.0.0 (2017-Sep-21).
*** Bug 113460 has been marked as a duplicate of this bug. ***
*** Bug 111546 has been marked as a duplicate of this bug. ***