Description: the following toolbars are visible which should be not visible, cause the functionality is already in the different notebookbar implementations impress - master toolbar - table toolbar draw - master toolbar - table toolbar - media toolbar - Steps to Reproduce: 1. clear profile 2. use tabbed NB 3. select context to show the specific toolbars Actual Results: show toolbars Expected Results: don't show toolbars cause NB has the functionality Reproducible: Always User Profile Reset: No Additional Info:
*** Bug 122087 has been marked as a duplicate of this bug. ***
Let's set to NEW
Dear andreas_k, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
*** Bug 147800 has been marked as a duplicate of this bug. ***
*** Bug 122270 has been marked as a duplicate of this bug. ***
*** Bug 147516 has been marked as a duplicate of this bug. ***
*** Bug 139624 has been marked as a duplicate of this bug. ***
*** Bug 141369 has been marked as a duplicate of this bug. ***
In sfx2/source/appl/appserv.cxx SID_TOOLBAR_MODE, it saves the current list of toolbars into UserToolbars, and disables all toolbars - BUT ONLY FOR THE CURRENT APPLICATION. This is why the Draw/Impress toolbars are not disabled during "Apply to All" private:resource/toolbar/toolbar is a UserToolbar that is configured by default as true in officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu So that is why the long toolbar shows up by default. Also DrawWindowState.xcu. The 4-button presentation toolbar shows up because DrawViewShell::ChangeEditMode turns it on for Impress when not in Master or Handout mode.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1ff817faad79952e6271bab178d41cae2a0d9ecd tdf#126095 impress notebookbar: don't force Master/Presentation toolbars It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Comment 10's patch fixes the small presentation toolbar (View - toolbars - presentation) with New/Duplicate/Delete/Layout slide from showing up in Impress. The bigger Drawing toolbar (View - Toolbars - Drawing) I don't know how to solve properly. It is being loaded in Impress/Draw, but if we default it to false (as suggested in comment 9), then it loads as not visible for the "default" menu, which of course must not happen. Basically, it needs to default off, but be added as a UserToolbar in the config. Or else we need to completely ignore the configmgr and just always show it in the default menu. But probably the best solution is to leave it as it is. The user who is annoyed just has to turn it off once, and it will stay off. But I'll leave the bug report open in case anyone wants to fix it.
It's not just a matter of turning it off once. You are showing elements of another UI in the Tabbed UI. It looks amateurish and half-baked. I disagree with closing this bug for that matter.
And by the way, the person who reported the bug was one of the developers of the Tabbed UI. If you know how to fix it, it would be nice to send a commit to do it?
Please disregard previous comments, when I opened the bug it didn't show your latest comments. I'm sorry.
I ran the latest dev version and now it shows the Drawing and Presentation toolbars on first boot of Impress with the Tabbed UI enabled.
Tested in latest dev release in safe mode without user profile, selecting Tabbed UI and observed the following: 1 - Drawing and Standard toolbar do not appear any longer. 2 - Master Toolbar and Table toolbar do no appear any longer as well. 3 - Master Toolbar and Table toolbar do not appear in Draw any longer.
Justin, any chance you could you do the same for the table toolbar that pops up when a table is selected in Draw/Impress? It still pops up with: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 46d7119b8be03968017e59d882e5671350304e15 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded (In reply to Pedro from comment #16) > Tested in latest dev release in safe mode without user profile, selecting > Tabbed UI and observed the following: > 1 - Drawing and Standard toolbar do not appear any longer. > 2 - Master Toolbar and Table toolbar do no appear any longer as well. > 3 - Master Toolbar and Table toolbar do not appear in Draw any longer. Pedro, did you test by turning the Tabbed UI on _from outside Draw/Impress_ ? Because when doing that, I can still see the Table toolbar pop up when a table is selected, and the Drawing toolbar always displayed.
(In reply to Stéphane Guillou (stragu) from comment #17) > Justin, any chance you could you do the same for the table toolbar that pops > up when a table is selected in Draw/Impress? I guess this would fix bug 142489 as well.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1de07de0cb063760474df70d0e4b6a7976ac2a8a related tdf#126095 sd notebookbar: give room to .uno:AVMediaToolBox It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e58e251756ecb0312cb6891d4df23e17ef8f6fcb tdf#126095 sd notebookbar: don't force table/media toolbar It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Stéphane Guillou (stragu) from comment #17) > Justin, any chance you could you do the same for the table toolbar that pops > up when a table is selected in Draw/Impress? The first three are now avoided: graphicobjectbar: for calc/writer the default is to be visible, but for draw/impress, it is set to be not visible officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu <node oor:name="private:resource/toolbar/graphicobjectbar" oor:op="replace"> <prop oor:name="Visible" oor:type="xs:boolean"><value>false</value> mediaobjectbar: for draw it is visible, but for impress it is not visible tableobjectbar: for draw/impress it is visible These remaining ones are not impacted. Perhaps they should be if they are visible... textobjectbar: for draw/impress it is not visible -(connected with a table, but not with a textbox) extrusionobjectbar (3d stuff) for draw/impress it is visible (I don't know how to trigger this - inserting a 3-d object doesn't call it.) fontworkobjectbar: for draw/impress it is visible (but I don't see it coming up. It DOES come up for the regular menu. So how is notebookbar suppressing this one?) bezierobjectbar: for draw/impress it is visible (but I don't know how to trigger this)
*** Bug 156341 has been marked as a duplicate of this bug. ***
Setting severity back to "normal" given the number of duplicates. I will test soon with a build that includes your patches but we might have to eventually close this one and open follow-up reports for remaining issues. Thanks Justin!
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/cdbd4139790383052f004def482f32fdec604fbb Revert "tdf#126095 sd notebookbar: don't force table/media toolbar" It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
comment 20 was reverted by comment 25 because of regression bug 161212.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/5777b30375df6b34568cf88cc3701513635eace1 Revert "tdf#126095 sd notebookbar: don't force table/media toolbar" It will be available in 24.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-24-2-4": https://git.libreoffice.org/core/commit/df737dc40e47322f1d6f2a3a3fbd08373125eafd Revert "tdf#126095 sd notebookbar: don't force table/media toolbar" It will be available in 24.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.