Download it now!
Bug 132880 - Area properties don't match color handling the outline shape receives
Summary: Area properties don't match color handling the outline shape receives
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Draw-UX Shapes
  Show dependency treegraph
 
Reported: 2020-05-09 17:10 UTC by Telesto
Modified: 2020-08-02 21:10 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-05-09 17:10:31 UTC
Description:
Area properties don't match color handling the outline shape receives

Steps to Reproduce:
1. Open Draw
2. Insert a shape -> from say the drawings sidebar
3. Change the color of the shape (color bucket at the left, set to any color)
4. Select another shape from the sidebar and draw to canvas -> blue.. will bucket being another color

Actual Results:
Color bucket setting doesn't match screen result

Expected Results:
Should be the same


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha1 (x64)
Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI: en-US
Calc: threaded
Comment 1 Regina Henschel 2020-05-09 19:11:12 UTC
If you want a change not for only one shape, then you need to change the style instead of applying changes directly.

Most shapes use the style "Default", some shapes the derived style "Object without fill". You need to change these styles, if you want, that new drawn shapes look different than now. Only text boxes use direct formatting in addition to style "Default". [In my opinion, that is an error. Text boxes should use the style "Object with no fill and no line"-style.]
Comment 2 Telesto 2020-05-09 19:34:51 UTC
(In reply to Regina Henschel from comment #1)
For the record.. this is somewhat of a follow up based on bug 132878 comment 1

No, not at all. The Sidebar -> Shapes deck shows only icons for the shape outline as drawn from the Icon theme set--they are not meant to be WYSIWYG preview of the resulting object.

The Shape style, or Line/Area properties, as set will control what color handling the outline shape receives when instantiated on canvas.

IMHO => NAB and invalid.
Comment 3 Maxim Monastirsky 2020-05-09 21:14:31 UTC
In addition to what Regina said: If you set a color when no shape is selected, then it will become the default for newly inserted shapes. This can be done with either the toolbar button, or with the Format > Area... menu command. With your steps, there is already a selected shape, so only that shape gets the color change. Otherwise, each time you will change the color of some shape, it will become the default for newly inserted shapes, which might not always be the desired result.

wrt the color shown on the toolbar button: This toolbar button is a split button, meaning it has two clickable areas: (a) A dropdown arrow, which opens the palette window, and (b) The main part of the button, which allows applying the last selected color to other shapes with a single click. Now, given this function of the main part, it must always show the last selected color and *not* the currently active one, as otherwise it won't be clear what color will be applied when clicking the button.
Comment 4 Telesto 2020-05-10 19:13:33 UTC
Thanks for all the explaining.. I certainly missed a few points... 

However, combining two settings in one button is quite confusing.. 
(a) If you set a color when no shape is selected, then it will become the default for newly inserted shapes. 
(b) if there is already a selected shape, so only that shape gets the color change. 

Otherwise, each time you will change the color of some shape, it will become the default for newly inserted shapes, which might not always be the desired result. -> However this causes the situation that can't see what the color is, which will be inserted..

Let there be user benjamin (me).. I'm not aware/ of not working with styles.
Because I can't set the settings before insertion (except for color, which not working as expected).. I end up with inserting a shape -> clicking it.. and changing the settings.. I'm even such an idiot that do this quite often for every shape separately after insertion

In my view it's lacking a setting to set the color/border in advance.. before insertion..

And format -> area is not a button I expected to work as a global setting :-). Another issue: I can't see on screen what is set.. If i choose an area fill or something like that..

And the it's even more confusing
1. Go to Format -> Area -> Area -> Bitmap tab (select one) (without a shape selected)
2. Insert a shape.. no reconsider.. I want a color instead of bitmap.. Select the shape and click color fill (left sidebar).. not working
3. Now I can correct it using the sidebar -> properties deck..

A partial fix would be.. show the Area/line properties deck also without a shape selected.. 

And/or replace the color picker button in the left sidebar. for a formatting bar which appears in Writer when clicking a shape. Except it's is always available in Draw; not context depended as in Writer
Comment 5 Maxim Monastirsky 2020-05-10 19:45:19 UTC
(In reply to Telesto from comment #4)
> And the it's even more confusing
> 1. Go to Format -> Area -> Area -> Bitmap tab (select one) (without a shape
> selected)
> 2. Insert a shape.. no reconsider.. I want a color instead of bitmap..
> Select the shape and click color fill (left sidebar).. not working
See Bug 90853. This is a bug, and should be fixed regardless of the outcome of this discussion.

> A partial fix would be.. show the Area/line properties deck also without a
> shape selected.. 
Yes, might be a good idea.

> And/or replace the color picker button in the left sidebar. for a formatting
> bar which appears in Writer when clicking a shape. Except it's is always
> available in Draw; not context depended as in Writer
There is already such toolbar in Draw: It's called "Line and Filling", and it used to be visible by default in the distant past.
Comment 6 Telesto 2020-05-10 19:56:44 UTC
(In reply to Maxim Monastirsky from comment #5)
> There is already such toolbar in Draw: It's called "Line and Filling", and
> it used to be visible by default in the distant past.

I should have checked that too :-), but hidden/ disabled because..
Comment 7 Telesto 2020-05-10 20:14:22 UTC
(In reply to Telesto from comment #6)
> (In reply to Maxim Monastirsky from comment #5)
> > There is already such toolbar in Draw: It's called "Line and Filling", and
> > it used to be visible by default in the distant past.
> 
> I should have checked that too :-), but hidden/ disabled because..

Probably because it's context depend.. and the one/off is really annoying.. and no place to put it .. if floating.. and wasting a lot of space with the 'bar' above it.. 

Context toolbars can be nice.. but also a pain in the ass. Disable the elements within the toolbar, not the toolbar itself.. Is sometimes really helpful. The resizing of paper size/ sidebar .. and everything when it toggles on/off..

However I vented my issue with context depended toolbars already.. 

Hmm.. the tabbed toolbar types seems the only functional workaround..
Comment 8 Heiko Tietze 2020-05-11 08:55:56 UTC
Can we resolve the question as WFM?
Comment 9 Telesto 2020-05-11 09:43:48 UTC
(In reply to Heiko Tietze from comment #8)
> Can we resolve the question as WFM?

Based on the title/ initial issue, yes. However, I still want to note that there is a workflow issue. Comment 4/5.. to be noted somewhere. The Line and Filling toolbar is really lacking in no-tabbed mode.
Comment 10 Maxim Monastirsky 2020-05-11 09:46:00 UTC
(In reply to Heiko Tietze from comment #8)
> Can we resolve the question as WFM?
There might be a real UX issue here: It isn't obvious from the default UI which color is used when drawing new shapes, and how to change it. It used to be less of a problem when the "Line and Filling" toolbar was visible by default. But then that toolbar was hidden by default in favor of a default visible sidebar (see Bug 87676 and Bug 90090). The problem is that the sidebar doesn't show the area and line content panels when no shape is selected, and so it isn't a full replacement for the toolbar. A suggestion was made in comment 4 to make the area/line sidebar content panels visible by default, even when no shape is selected. What do you think about this?
Comment 11 Heiko Tietze 2020-05-11 10:39:24 UTC
(In reply to Maxim Monastirsky from comment #10)
> It isn't obvious from the default UI which color is used when drawing 
> new shapes, and how to change it.

The color pickers can either show the current color or allow to quickly apply the last option. And since I see what color is used, I definitely prefer the second option. This applies also to other modules such as Writer and font color, for example.

The drawing style is a more tricky thing since you have to select the canvas first and double-click a style to use this as the next default. Kind of easter egg; we could improve this with a checkbox (or the like) that defines the actual default (see also bug 47295). But it's also possible to change the default, which is in Benjamin's capabilities.

Actual issue is the contextual dual use of the sidebar for object and page properties. If we'd have placed the page stuff on an extra deck (or better don't have it at the sidebar as this is not an option which frequently needs attention) we could always show the properties deck.

Showing the Line & Filling toolbar again is not an option.
Comment 12 Telesto 2020-05-11 10:58:09 UTC
(In reply to Heiko Tietze from comment #11)

I would love the comment on this, but I read it already 3 times, without knowing what is being discussed exactly. So only a partly respons

> (In reply to Maxim Monastirsky from comment #10)
> > It isn't obvious from the default UI which color is used when drawing 
> > new shapes, and how to change it.
> 
> The color pickers can either show the current color or allow to quickly
> apply the last option. And since I see what color is used, I definitely
> prefer the second option. This applies also to other modules such as Writer
> and font color, for example.
> 
> The drawing style is a more tricky thing since you have to select the canvas
> first and double-click a style to use this as the next default. Kind of
> easter egg; we could improve this with a checkbox (or the like) that defines
> the actual default (see also bug 47295). But it's also possible to change
> the default, which is in Benjamin's capabilities.
> 
> Actual issue is the contextual dual use of the sidebar for object and page
> properties. 

Yes

>If we'd have placed the page stuff on an extra deck (or better
> don't have it at the sidebar as this is not an option which frequently needs
> attention) we could always show the properties deck.

Agree

> Showing the Line & Filling toolbar again is not an option.
Please don't state.. but give a motivation.. why not (something in the area of comment 7?)
Comment 13 Heiko Tietze 2020-05-11 11:34:59 UTC
(In reply to Telesto from comment #12)
> I would love the comment on this, but I read it already 3 times, without
> knowing what is being discussed exactly. So only a partly respons
>
> > The color pickers can either show the current color or allow to quickly
> > apply the last option...

Some reasoning why we better keep the color picker as they are.

> > The drawing style is a more tricky thing since you have to select the canvas
> > first...

"Use styles" is the standard reply. You can set the drawing styles which is used next by clicking the document canvas first (not any object) and then double click any node in the styles sidebar. I added a note how to improve this.

> > Showing the Line & Filling toolbar again is not an option.
> Please don't state.. but give a motivation.. why not (something in the area
> of comment 7?)

We hide the toolbar intentionally. That hasn't changed. And showing it again would be just a workaround as the actual problem lies in the sidebar deck.

=> still WFM
Comment 14 Telesto 2020-05-11 11:44:08 UTC
(In reply to Heiko Tietze from comment #13)
> We hide the toolbar intentionally. That hasn't changed. And showing it again
> would be just a workaround as the actual problem lies in the sidebar deck.

I proposed the sidebar deck.. but even that isn't working properly. I want to 'pick' a setting on inserting a shape. And I'm using the shape deck to 'pick' shapes.. So I would prefer direct access.. There is no issue when using the Tabbed bar.. 

Can it not be added to the standard toolbar? Yes, can be done by customizing.. but by default.
Comment 15 Maxim Monastirsky 2020-05-11 12:36:34 UTC
(In reply to Heiko Tietze from comment #11)
> And since I see what color is used, I definitely
> prefer the second option. This applies also to other modules such as Writer
> and font color, for example.
Not entirely the same. In Writer, once you set font color, you can continue typing text with the selected color until you change it again. And you see the actual text color on the document canvas. But when it comes to drawing shapes, you can't see the color of a shape *before* you draw it. And setting a color for a shape applies only to that shape, and not to any further shape.

I also would like to add that this isn't just about color. Shape filling might be also of gradient, hatching etc. which isn't possible to set from the current toolbar button. In addition, there are other properties like line style, arrow heads or shadow, which users might want to set in advance.

> Actual issue is the contextual dual use of the sidebar for object and page
> properties. If we'd have placed the page stuff on an extra deck (or better
> don't have it at the sidebar as this is not an option which frequently needs
> attention) we could always show the properties deck.
Good point. We do have separate page deck in Writer, so why not have something like this in Draw?

> Showing the Line & Filling toolbar again is not an option.
Agree on this. Given that we go with the sidebar enabled by default, the toolbar will mostly duplicate the settings found in the sidebar. If anything, the sidebar is the place to show these settings whenever we want them.
Comment 16 Maxim Monastirsky 2020-05-11 12:49:51 UTC
(In reply to Telesto from comment #14)
> I proposed the sidebar deck.. but even that isn't working properly. I want
> to 'pick' a setting on inserting a shape. And I'm using the shape deck to
> 'pick' shapes.. So I would prefer direct access..
You must switch to another deck also for changing settings after shape insertion.
So there is a problem anyway, that we can't show several decks at the same time - see Bug 85905. I guess that's why we still have the drawing toolbar at the left, although it duplicates the shapes deck with the same set of available shapes.
Comment 17 Heiko Tietze 2020-06-14 12:32:28 UTC
The color picker switches to the default when no object is selected. It could just keep the last used configuration. And changing the style could also affect the last used configuration.

So for example, the first inserted object would be in blue but after changing this to red we don't switch back to blue on click at the canvas or at toolbars. So the next objects takes the red. If the user clicks on a green object, this green is kept for the next object.
Comment 18 Heiko Tietze 2020-07-21 13:14:39 UTC
*** Bug 134928 has been marked as a duplicate of this bug. ***