Bug 153458 - Connecting to database: wrong cursor position for dropping data to Calc sheet
Summary: Connecting to database: wrong cursor position for dropping data to Calc sheet
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks: KDE, KF5
  Show dependency treegraph
 
Reported: 2023-02-08 07:30 UTC by Robert Großkopf
Modified: 2023-04-08 10:22 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
See the wrong position in LO 7.5.0.3 - doesn't allow data dropping when reaching row 1 or row 2. (42.12 KB, image/png)
2023-02-08 07:30 UTC, Robert Großkopf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2023-02-08 07:30:43 UTC
Created attachment 185200 [details]
See the wrong position in LO 7.5.0.3 - doesn't allow data dropping when reaching row 1 or row 2.

Open a new Calc document.
Open the database browser (View → Data Sources).
Take a table of Data Sources, click with left mouse button, press the button and drag to the Calc sheet.
Cursor has position at A1, but data couldn't be dropped.
Same with position A2.
Cursor has to reach bottom of position A2. Then data will be dropped - starting at A1.
Cursor should allow to drop data directly when reaching the sheet (A1).

This bug apperas unter OpenSUSE 15.3 with 

Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded

Doesn't appear in LO 7.4.5.1 on the same system.
Comment 1 Stéphane Guillou (stragu) 2023-02-23 07:00:28 UTC
Reproduced with:

Version: 7.5.0.3 (X86_64) / LibreOffice Community
Build ID: c21113d003cd3efa8c53188764377a8272d9d6de
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Same with kf5 (cairo+wayland).

But not with gtk3 VCL.

Not reproduced in:

Version: 7.4.5.1 / LibreOffice Community
Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 Michael Weghorn 2023-02-23 08:33:12 UTC
This is a regression, bibisected to:

commit afc828b9833b7a612369e95606ba56d41ef2c369
Author: Jan-Marek Glogowski <glogow@fbihome.de>
Date:   Sat May 28 23:47:21 2022 +0200

    VCL expect correct frame size for native menubars

Adding CC: to Jan-Marek Glogowski
Comment 3 Michael Weghorn 2023-02-23 10:38:48 UTC
tdf#136901 comment 5 mentions another drag'n'drop scenario in Calc that behaves similarly with kf5:

> Everything works fine with gtk3 and gen (first two tests in the screencast) but
> for qt5/6 [...] I have to place the cursor way below the tabs to 
> evoke the drag handler (otherwise the sheet scrolls).
Comment 4 ady 2023-03-11 05:50:46 UTC
(In reply to Michael Weghorn from comment #3)
> tdf#136901 comment 5 mentions another drag'n'drop scenario in Calc that
> behaves similarly with kf5:

FWIW, tdf#136901 comment 5 is by now off-topic for that bug report.
Comment 5 Commit Notification 2023-03-29 10:46:23 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f51b220b953ec71fb742f799fbe645a93cf3d944

tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Michael Weghorn 2023-03-29 10:53:41 UTC
Fixed now by reverting the commit that caused the regression, s. more details in the commit message.
Comment 7 Commit Notification 2023-04-07 16:41:49 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/0d2e22e1700aca42246924c2083c2271a9ad0d79

tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Stéphane Guillou (stragu) 2023-04-08 10:22:10 UTC
Fix verified in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ad5756f0529a80fbb537979bcfd9de7a83a69805
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded