Bug 154043 - Change object layer via drag and drop has target shifted down (KF5-only)
Summary: Change object layer via drag and drop has target shifted down (KF5-only)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Layers KDE, KF5
  Show dependency treegraph
 
Reported: 2023-03-07 14:35 UTC by JirkaZ
Modified: 2023-04-08 10:20 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description JirkaZ 2023-03-07 14:35:40 UTC
Description:
Let's have an LO Draw document with three objects, each placed in its own layer (object 1 is in a layer named layer 1, etc.).

Up to now, it was possible to change the layer on an object by clicking on the object, holding the mouse button down until the selection marks changed, and holding the button down "carried" the object to the target layer tab.

In version 7.5.1.2 this stopped working, instead the object just moved to another location in the document and the layer stayed the same (as if I had used a simple drag & drop).

Steps to Reproduce:
described above

Actual Results:
no layer change

Expected Results:
layer change as in earlier LO Draw versions


Reproducible: Always


User Profile Reset: No

Additional Info:
Kubuntu 18.04 LTS with Ubuntu version of LO.
Comment 1 JirkaZ 2023-03-22 07:28:27 UTC
I could possibly make a video, but it's too big and I can't put it as an attachment.

Anyone else have the same experience?
Comment 2 Stéphane Guillou (stragu) 2023-03-22 08:47:39 UTC
Thank you for the report Jirka.

I can still long-press then drag-and-drop objects between layers with the gtk vcl, but with the kf5 vcl, I can see the same issue as you:

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Checking with the linux-64-7.5 bibisect repository, the problem was introduced by the same commit that caused e.g. bug 153458 and bug 153800 :

commit afc828b9833b7a612369e95606ba56d41ef2c369
author	Jan-Marek Glogowski <glogow@fbihome.de>	Sat May 28 23:47:21 2022 +0200
committer	Jan-Marek Glogowski <glogow@fbihome.de>	Tue Jun 21 17:26:06 2022 +0200
VCL expect correct frame size for native menubars
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135082

Michael and Stephan, copying you in as reviewers, given that Jan-Marek has been less active. This looks like the sixth kf5 regression report linked to it: https://bugs.documentfoundation.org/buglist.cgi?keywords=regression&keywords_type=allwords&list_id=1575864&longdesc=afc828b9833b7a612369e95606ba56d41ef2c369&longdesc_type=allwordssubstr&query_format=advanced&resolution=---
Comment 3 JirkaZ 2023-03-22 18:31:09 UTC
Thank you for the affirmative response. Is there any hope of fixing the bug in the near future?
Comment 4 Michael Weghorn 2023-03-24 08:56:51 UTC
(In reply to Stéphane Guillou (stragu) from comment #2)
> Michael and Stephan, copying you in as reviewers, given that Jan-Marek has
> been less active. This looks like the sixth kf5 regression report linked to
> it:
> https://bugs.documentfoundation.org/buglist.
> cgi?keywords=regression&keywords_type=allwords&list_id=1575864&longdesc=afc82
> 8b9833b7a612369e95606ba56d41ef2c369&longdesc_type=allwordssubstr&query_format
> =advanced&resolution=---

I already spent some time looking into some of the issues. While I could come up with a fix for the wrong drag'n'drop position, that's not the case for other regressions introduced by the commit and I don't fully understand the underlying overall direction of the change at this point.

I'd suggest to revert the commit for now. (Of course with the option to bring it back in a revised form in case Jan-Marek has the time to look into this at some point.)

Some more details in the commit message of the suggested Gerrit change to do the revert; opinions and input either there or here would be appreciated:
https://gerrit.libreoffice.org/c/core/+/149495
Comment 5 Commit Notification 2023-03-29 10:46:21 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f51b220b953ec71fb742f799fbe645a93cf3d944

tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-04-07 16:41:47 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/0d2e22e1700aca42246924c2083c2271a9ad0d79

tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Stéphane Guillou (stragu) 2023-04-08 10:20:21 UTC
Fix verified in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ad5756f0529a80fbb537979bcfd9de7a83a69805
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded