Bug 153800 - Calc sheet tab drag-and-drop target area has shifted vertically (kf5-only)
Summary: Calc sheet tab drag-and-drop target area has shifted vertically (kf5-only)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.1.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:7.6.0 target:7.5.3
Keywords: bibisected, bisected, regression
: 155291 (view as bug list)
Depends on:
Blocks: KDE, KF5 Sheet-Tabs-Bar
  Show dependency treegraph
 
Reported: 2023-02-24 12:12 UTC by Rafael Lima
Modified: 2023-05-14 08:41 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2023-02-24 12:12:48 UTC
Dragging Calc sheet tabs has stopped working in kf5.

Steps to reproduce:

1) Create a new Calc document
2) Add a few sheets using the + button
3) Try do drag one of the tabs to a different location
4) Notice that the tabs won't move.

In the console I get multiple warning messages saying:
warn:vcl:7708:7708:vcl/source/window/dndeventdispatcher.cxx:185: rejecting drag over due to missing listeners.

Only happens with kf5. Works well with gen and gtk3.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 29d795b772cb75ee1d12cc6bcd4d905f1c520a79
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 Stéphane Guillou (stragu) 2023-03-12 21:47:05 UTC
Reproduced in:

Version: 7.5.1.2 (X86_64) / LibreOffice Community
Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 082d009b6a156faa74c9966b0dffc5fa6ce22287
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Not in:

Version: 7.4.6.2 / LibreOffice Community
Build ID: 5b1f5509c2decdade7fda905e3e1429a67acd63d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

One has to drag and drop *below* the tabs for it to work. I noticed that because dragging over the tabs makes the sheet scroll down.

Heiko had noticed the same thing in https://bugs.documentfoundation.org/show_bug.cgi?id=136901#c5

Same root cause as bug 153458, introduced by:

commit afc828b9833b7a612369e95606ba56d41ef2c369
author	Jan-Marek Glogowski <glogow@fbihome.de>	Sat May 28 23:47:21 2022 +0200
committer	Jan-Marek Glogowski <glogow@fbihome.de>	Tue Jun 21 17:26:06 2022 +0200
tree b60ec391ff6f93f85eb4f88d756c2f70b79b674c
parent dbaf5f6fad2ec10f69cf46f9cb697b8760c2a01f
VCL expect correct frame size for native menubars
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135082

Jan-Marek, can you please have a look?
Comment 2 Commit Notification 2023-03-29 10:46:25 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f51b220b953ec71fb742f799fbe645a93cf3d944

tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Michael Weghorn 2023-03-29 10:52:46 UTC
Fixed now by reverting the commit that caused the regression, s. more details in the commit message.
Comment 4 Commit Notification 2023-04-07 16:41:51 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/0d2e22e1700aca42246924c2083c2271a9ad0d79

tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Stéphane Guillou (stragu) 2023-04-08 10:14:42 UTC
Verified in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ad5756f0529a80fbb537979bcfd9de7a83a69805
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 6 Stéphane Guillou (stragu) 2023-05-14 08:41:58 UTC
*** Bug 155291 has been marked as a duplicate of this bug. ***