Bug 164392 - New Options -> Appearance LO Theme panel not restoring System default colors from os/DE
Summary: New Options -> Appearance LO Theme panel not restoring System default colors ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.8.0
Keywords:
: 165413 165529 165746 (view as bug list)
Depends on:
Blocks: UI-Theming LibreOffice-Themes
  Show dependency treegraph
 
Reported: 2024-12-20 14:56 UTC by V Stuart Foote
Modified: 2025-03-14 20:16 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2024-12-20 14:56:19 UTC
Not clear why, but with no Color Theme installed, using the 'System'|'Light'|'Dark' radio buttons to select color theme is not restoring the os/DE provided colors when returning to the 'System' radio buttons (rb).

Now no restart, and the 'Items' listbox in 'Customizations' goes inactive.

Choosing either 'Light' or 'Dark' Appearance rb, then setting rb to 'System' and Themes still on "Automatic" setting:

The 'Document background' is now "Black" not "Automatic" but also apparently the 'Font color' also "Black" rather than "Automatic".

Seems like we have a state where we don't restore colors back to os/DE provided colors for the "Automatic" theme and 'System' DE. Colors are set, but should roll back to "Automatic".

Noticed also, that any change to the Theme would require a restart, but no similar restart without a color theme and just "Automatic". 

Issue may be a simple as forcing the restart, without a color theme set, when just the change is made between the 'System'|'Light'|'Dark' radio buttons?

And, even with a color theme (Lime Theme) installed, changing the theme back to the Automatic lb entry--the Appearance options and Customization items don't restore the color values from os/DE. The Items lb remains inactive but the showing "Document bacground" shows Dark with a 'Black' color swatch. Can't see the 'Font color' item--but either automatic or black we get black or black on the document.


=-testing-=
Version: 25.2.0.1.0+ (X86_64) / LibreOffice Community
Build ID: 468d47bdf44a772e989a0adbeb5bb097e3cb4f31
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 1 Heiko Tietze 2025-01-06 07:21:12 UTC
The radio buttons control what flavor of colors is used: light or dark. If you overwrite some item it happens for this variant, meaning you don't change the background for the light variant if dark is chosen. In order to reset some value you need to pick the right radio button and change the item to automatic.

NAB?
Comment 2 Sahil Gautam (allotropia) 2025-01-06 08:47:35 UTC
> Now no restart, and the 'Items' listbox in 'Customizations' goes inactive.

> The 'Document background' is now "Black" not "Automatic" but also apparently the 'Font color' also "Black" rather than "Automatic".

> 
Noticed also, that any change to the Theme would require a restart, but no similar restart without a color theme and just "Automatic".

because the latest patches haven't been reviewed and merged.
Comment 3 V Stuart Foote 2025-01-31 13:05:57 UTC
Seems resolved with https://gerrit.libreoffice.org/c/core/+/179406 against a 25.8 release

https://git.libreoffice.org/core/commit/924c7de80afa47a93705e5d073c35f2d81f4ed5a

Though some lingering issues with the 'Automatic' color values are being passed back in from os/DE for some of the widgets, notably scroll-bars in os/DE 'Light' color mode, or when the 'Light' RB mode.
Comment 4 nobu 2025-02-25 14:43:33 UTC
*** Bug 165413 has been marked as a duplicate of this bug. ***
Comment 5 V Stuart Foote 2025-03-02 00:55:20 UTC
*** Bug 165529 has been marked as a duplicate of this bug. ***
Comment 6 V Stuart Foote 2025-03-02 11:12:27 UTC Comment hidden (obsolete)
Comment 7 V Stuart Foote 2025-03-02 21:31:32 UTC Comment hidden (obsolete)
Comment 8 V Stuart Foote 2025-03-14 20:16:53 UTC
*** Bug 165746 has been marked as a duplicate of this bug. ***