Bug 165149 - LibreOffice_25.2.0.3_Win_x86-64.msi installation doesn't install VCRUNTIME140_1.dll
Summary: LibreOffice_25.2.0.3_Win_x86-64.msi installation doesn't install VCRUNTIME140...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
25.2.0.1 rc
Hardware: All All
: highest critical
Assignee: Christian Lohmaier
URL:
Whiteboard: target:25.8.0 target:25.2.1
Keywords: regression
: 164738 165327 165376 165450 (view as bug list)
Depends on:
Blocks: Installer-Windows
  Show dependency treegraph
 
Reported: 2025-02-09 18:05 UTC by Mike Kaganski
Modified: 2025-02-27 08:27 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2025-02-09 18:05:24 UTC
On a just-installed Windows 10 (nothing else installed), install LibreOffice_25.2.0.3_Win_x86-64.msi. Try to launch it.

=> failure "because VCRUNTIME140_1.dll was not found".

It was the same with LibreOffice_25.2.0.1_Win_x86-64.msi; and the same problem is with the new LibreOffice_25.2.1.1_Win_x86-64.msi.

The MSI package definitely contains the feature for vcruntime140_1.dll; but for some reason, it doesn't get installed.

Installation from LibreOffice_24.8.5.1_Win_x86-64.msi works fine.
Comment 1 Mike Kaganski 2025-02-09 20:39:52 UTC
For some reason, some bits from scp2/source/ooo/vc_redist.scp (the ones about the condition [VC_REDIST=1], as well as added permanent attribute) are not added to the MSI, even though the MSM file itself is added. Something broken about ComponentCondition and Attributes_Add processing? Some installer machinery changes lately? I seem to recall someone doing something with our Perl machinery.
Comment 2 Mike Kaganski 2025-02-09 20:51:28 UTC
Last commits in solenv/bin/modules/installer, that made into 25-2:
 b2cb093d8bd8fbfa4204cb10daec52ec6c283e04 1cabb20fad8303d16e25957ee245970f37ad2f82

The latter one looks related:

> replace a couple manual calls to cygpath with PathFormat
> 
> this fixes using the MSM merge modules in the wsl-as-helper case and
> avoids "cygpath not found" error lines when doing the compiler tests
> when running configure.
> 
> Also capture and report the output of failed msidb calls in the
> isntaller code and simplify the path-mangling to windows-style
Comment 3 Mike Kaganski 2025-02-10 06:16:32 UTC
Workaround: download and install manually the latest VS redistributable from MS:

https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist
Comment 4 Radish 2025-02-11 20:13:41 UTC Comment hidden (obsolete)
Comment 5 Mike Kaganski 2025-02-11 20:19:59 UTC Comment hidden (off-topic)
Comment 6 Radish 2025-02-11 21:27:23 UTC Comment hidden (off-topic)
Comment 7 Mike Kaganski 2025-02-12 05:30:41 UTC
It may also report lack of MSVCP140_ATOMIC_WAIT.dll
Comment 8 Xisco Faulí 2025-02-12 09:41:51 UTC
Hi Cloph,
I was wondering if the safest move would be to revert 1cabb20fad8303d16e25957ee245970f37ad2f82 in libreoffice-25-2 branch...
Comment 9 Christian Lohmaier 2025-02-12 15:14:37 UTC
nah, full-revert shouldn't be necessary - small enough to dissect that one to find out why things are falling apart and then address those.

Changes to actually respect the return code of the commands and other stuff is helpful/should stay.

It is easy to isolate the change in configure and the only difference that one can have is to add an additional slash at the MSM path – but that doesn't make a difference in the logic applied.

Also rearranging quoting of the commands / removing "if ( $^O =~ /cygwin/i )" conditionals and always applying it are also safe...

So the most likely culprit is the escaping of the * used in the commands, currently looking into that.

I think there's enough time to only fix what broke since the tag for 25.2.1 rc2 is next week. I it also was on the other branch I'd also go with a full revert and fix later…
Comment 10 Commit Notification 2025-02-12 21:59:34 UTC
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7fa9691dc204cef02b14141697f1a68330dcdf30

tdf#165149 fix installing Visual Studio C++ runtime dlls/merge modules

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2025-02-18 10:52:52 UTC
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/a9529e0bd56fbebf23f03ef8f95efe9d94bcf7a1

tdf#165149 fix installing Visual Studio C++ runtime dlls/merge modules

It will be available in 25.2.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2025-02-18 10:53:56 UTC
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "libreoffice-25-2-1":

https://git.libreoffice.org/core/commit/b1686d0d58bca337662559b68f9646788fa7195f

tdf#165149 fix installing Visual Studio C++ runtime dlls/merge modules

It will be available in 25.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 m_a_riosv 2025-02-19 00:42:13 UTC
*** Bug 165327 has been marked as a duplicate of this bug. ***
Comment 14 rushaidkdy 2025-02-21 14:18:59 UTC Comment hidden (spam)
Comment 15 V Stuart Foote 2025-02-21 18:11:04 UTC
*** Bug 165376 has been marked as a duplicate of this bug. ***
Comment 16 Xisco Faulí 2025-02-24 15:43:33 UTC
*** Bug 165418 has been marked as a duplicate of this bug. ***
Comment 17 Julien Nabet 2025-02-26 22:24:49 UTC
*** Bug 165450 has been marked as a duplicate of this bug. ***
Comment 18 Julien Nabet 2025-02-27 08:27:52 UTC
*** Bug 164738 has been marked as a duplicate of this bug. ***