Bug 64432 - EDITING: Input fields in protected section cannot be properly edited (summary: comment 14)
Summary: EDITING: Input fields in protected section cannot be properly edited (summary...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: BSA target:5.1.0 target:5.0.4 target:...
Keywords: bibisected, bisected, regression
: 64763 77205 80806 84543 92158 95091 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-05-10 14:52 UTC by katonkar
Modified: 2016-10-25 19:17 UTC (History)
13 users (show)

See Also:
Crash report or crash signature:


Attachments
Test Document (10.83 KB, application/vnd.oasis.opendocument.text)
2013-05-20 10:07 UTC, katonkar
Details
test odt from 4.1.0beta2 on Linux (8.13 KB, application/vnd.oasis.opendocument.text)
2013-06-10 11:54 UTC, Cor Nouws
Details

Note You need to log in before you can comment on or make changes to this bug.
Description katonkar 2013-05-10 14:52:47 UTC
Problem description: 
If you write protect a section in a Writer document which contains input fields, an edit of those fields in this protected area will not be displayed until you press F9 or go into the page preview.

Steps to reproduce:
1. Insert an Input Field
2. Create a section
3. Write protect the section

Current behavior:
Changes to the fields are not being displayed.

Expected behavior:
Update fields after editing.
Operating System: Windows 7
Version: 4.0.3.3 rc
Last worked in: 3.6.5.2 release
Comment 1 ign_christian 2013-05-18 05:13:08 UTC
Could you please explain detailed steps to reproduce? You also can attach sample doc & screenshot to make others easier to test.
Comment 2 birquito 2013-05-19 16:19:30 UTC
see my added bug report: Bug 64763 - EDITING: No actualisation of changes in fields in an re-opend file wich was created from an .ott-file (edit) 
There is a file attached to see the explained behaviour.
Comment 3 ign_christian 2013-05-20 02:56:51 UTC
Still guessing whether it's related to Bug 64763 ?

I think we need more info. What file format? Related to protection?
So it's better if reporter provide us sample doc.
Comment 4 katonkar 2013-05-20 10:07:17 UTC
Created attachment 79565 [details]
Test Document
Comment 5 katonkar 2013-05-20 10:11:15 UTC
I guess it's related to BUG 64763 .
Comment 6 ign_christian 2013-05-20 13:05:16 UTC
*** Bug 64763 has been marked as a duplicate of this bug. ***
Comment 7 ign_christian 2013-05-20 13:09:17 UTC
confirmed reproducible on LO 4.0.3.3 (Win7 Home Premium 32bit)

I think it's a bug, changes should be shown immediately & it's not happen on 3.6.5.2.
Comment 8 Cor Nouws 2013-06-10 11:48:56 UTC
(In reply to comment #7)
> confirmed reproducible on LO 4.0.3.3 (Win7 Home Premium 32bit)
> 
> I think it's a bug, changes should be shown immediately & it's not happen on
> 3.6.5.2.

I cannot reproduce this on 4.0.3.3 and 4.1.0beta2 on Linux

- writer document
- some paragraphs
- create user field
- create and insert input field
- select paragraphs
- create section and protect that
- click on input field
- edit value in popup, click OK
  > changed value is shown in the field
Comment 9 Cor Nouws 2013-06-10 11:53:46 UTC
interesting ... I see that the test document from comment #4 with me also shows the same bug..
I will attach a test document from my computer.
Comment 10 Cor Nouws 2013-06-10 11:54:42 UTC
Created attachment 80616 [details]
test odt from 4.1.0beta2 on Linux
Comment 11 birquito 2013-06-21 15:08:26 UTC
It seems that in 4.0.4 the bug no longer exists.
Comment 12 ign_christian 2013-06-21 15:28:55 UTC
With Katonkar file I still can reproduce that on LO 4.0.4.2 (Win7 32bit), but it's not reproducible if section unprotected.

But with Cor Nouws file I can't reproduce, though it's protected. Strange..?
Comment 13 birquito 2013-06-21 15:44:59 UTC
Sorry - i have to correct myself: I changed my personal files a few weeks ago and forgot to write protect the section - sorry sorry sorry.
Comment 14 Matthew Francis 2015-01-16 13:10:18 UTC
As this is apparently the earliest of a set of duplicate bugs, moving all relevant discussion here.

The behaviour has changed several times without reaching a complete fix. As of current 4.5 master, there is still a remaining issue that while text can be inserted into a text field in a protected section, it cannot be deleted.

Title adjusted to suit.
Comment 15 Matthew Francis 2015-01-16 13:10:54 UTC
*** Bug 77205 has been marked as a duplicate of this bug. ***
Comment 16 Matthew Francis 2015-01-16 13:12:17 UTC
*** Bug 80806 has been marked as a duplicate of this bug. ***
Comment 17 Matthew Francis 2015-01-16 13:14:05 UTC
*** Bug 84543 has been marked as a duplicate of this bug. ***
Comment 18 Matthew Francis 2015-01-16 13:17:20 UTC
(Investigation copied over from bug 84543)


The following commit is where the behaviour appears to have changed most recently, which is probably the one that is significant in this instance.

Openoffice 4.1.1 (Aug 13 2014) allows both the adding and deleting of text within the input fields, so possibly this was mis-merged, or there was a follow-up fix which hasn't yet been applied


commit 961315f0838197e71e9bd49169afe673466e5eb8
Author: Oliver-Rainer Wittmann <orw@apache.org>
Date:   Thu Feb 20 11:01:04 2014 +0000

    Resolves: #i124243# allow in-place editing of Input Fields...
    
    in protected areas (e.g. protected sections)
    
    (cherry picked from commit 1708b9bee77ab0e8762bbb6886b778b93428a2b0)
    
    Conflicts:
    	sw/inc/pam.hxx
    	sw/source/core/crsr/crsrsh.cxx
    	sw/source/core/crsr/pam.cxx
    	sw/source/core/edit/edfcol.cxx
    	sw/source/core/edit/ednumber.cxx
    	sw/source/ui/docvw/edtwin.cxx
    
    Change-Id: Iedcb31a824a9147bccb14314608749121c70d952
Comment 19 Matthew Francis 2015-01-16 13:21:51 UTC
- Added a Cc: back to caolanm@redhat.com as the committer for the AOO merge mentioned above

- Added a See Also for bug 82746, which may be the same underlying issue but relates to input fields outside protected sections.
Comment 20 birquito 2015-04-27 13:08:01 UTC
If 80806 is a duplicate, of this one, so the bug was solved for about a year and came back with the 4.2.5.2. Version. With 4.1.6.2. all still working normaly. I doubt that this is a duplicate because since this bug was described the field handling changed. Until at least 4.1.6.2. changeing fields worked via an opend dialog window. Since 4.2.5.2. the changes had to be done within the field not via dialog window. So maybe this one is a solved bug and a new one apeared?! With AOO 4.1.1. all is working correct.
Comment 21 birquito 2015-08-28 16:03:41 UTC
Still same frustrating behaviour with LO 5.0.1.2 64bit.
Comment 22 birquito 2015-09-26 15:45:55 UTC
Same with 5.0.2.2 64bit.
Comment 23 Kulo 2015-10-14 08:37:18 UTC
*** Bug 92158 has been marked as a duplicate of this bug. ***
Comment 24 Cor Nouws 2015-10-15 20:41:57 UTC
*** Bug 95091 has been marked as a duplicate of this bug. ***
Comment 25 Commit Notification 2015-10-20 12:58:14 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "libreoffice-4-4":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb0d47c372366da812e8dd1a54f772f1d43e9310&h=libreoffice-4-4

tdf#64432: enable delete and backspace in editable elements within protections

It will be available in 4.4.7.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 26 Kulo 2015-10-22 07:39:52 UTC
What about LO 5.0.x ? Will this patch also be pushed to LO 5.0?
Comment 27 Oliver Specht (CIB) 2015-10-22 08:38:40 UTC
(In reply to Kulo from comment #26)
> What about LO 5.0.x ? Will this patch also be pushed to LO 5.0?

It's already pushed to 5.0.4., see comment #3 of issue 95091 (one of the duplicates).
Comment 28 Commit Notification 2015-10-23 06:36:10 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "libreoffice-4-4-6":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=536a614b53f7597faaa3abc0c61db6f3dde4501f&h=libreoffice-4-4-6

tdf#64432: enable delete and backspace in editable elements within protections

It will be available in 4.4.6.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 29 birquito 2015-11-18 12:47:51 UTC
Works form me with 4.4.6 - at last.
Waiting for 5.0.4 to test it.
Comment 30 Helge Kreutzmann 2015-12-12 17:39:02 UTC
Works for me in 4-4-6 both with the files I reported the duplicate (84543) as well with documents from work which showed the same issues. All tests done under Linux.
Comment 31 Cor Nouws 2015-12-12 18:30:41 UTC
@helge, Thanks for testing 
@oliver, thanks for fixing

I confirm the fix in 4.4.7.1
Comment 32 Robinson Tryon (qubit) 2015-12-17 07:14:29 UTC Comment hidden (obsolete)