* Open Draw * File > Export ... * File Format: EPS * Save LibreOffice crashes Tested using Windows 7 x64 with LibreOffice Version: 5.1.0.0.alpha1+ Build ID: 6a626955eb8b803fa58a58baafaa2a06ab4761f2 TinderBox: Win-x86@39, Branch:master, Time: 2015-05-30_07:46:48 Locale: nl-BE (nl_BE)
I can confirm with Version: 5.1.0.0.alpha1+ Build ID: ef2e135cfb8f107a154aaab9b54f2dfca0edf6a0 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-05-28_23:58:34
Created attachment 116200 [details] bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this.
Michael/Noel: with this patch, no crash and eps export seems ok: diff --git a/filter/source/graphicfilter/eps/eps.cxx b/filter/source/graphicfilter/eps/eps.cxx index 1cc70b9..ff573ed 100644 --- a/filter/source/graphicfilter/eps/eps.cxx +++ b/filter/source/graphicfilter/eps/eps.cxx @@ -116,7 +116,7 @@ private: SvStream* mpPS; const GDIMetaFile* pMTF; GDIMetaFile* pAMTF; // only created if Graphics is not a Metafile - ScopedVclPtr<VirtualDevice> pVDev; + ScopedVclPtrInstance<VirtualDevice> pVDev; double nBoundingX1; // this represents the bounding box double nBoundingY1; Is it a right fix?
*** Bug 91772 has been marked as a duplicate of this bug. ***
In vcl/README.lifecycle, I noticed this: - VirtualDevice aDev; + ScopedVclPtrInstance<VirtualDevice> pDev; May we blindly apply this to all these instances: http://opengrok.libreoffice.org/search?q=%22ScopedVclPtr%3CVirtualDevice%3E%22&project=core&defs=&refs=&path=&hist= ?
No - please don't blindly apply that; in many cases the VirtualDevice is correctly constructed in the constructor for these; and duplicating that will create a lot of problems. Best to work out which commit this was included in (many of them have been audited), and then re-check each instance - to ensure that there is no construction of the VirtualDevice. Thanks though for isolating a fix; will review & commit !
Julien Nabet committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c709da10fb2585a1f8b7d1a96b33d3fe5486d7f5 tdf#91782 - fix VirtualDevice allocation crasher in eps filter. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
It'd be great to test & close etc. if fixed =)
Marking fixed for now; thanks !
backporting 5.0 will be made? this bug in LO 5.0.0.5 is reproduced
*** Bug 93344 has been marked as a duplicate of this bug. ***
Gerrit review for 5.0 branch: https://gerrit.libreoffice.org/#/c/17688/
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-5-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6071bab93bae55cf037d1c31c63879cab66ad0d9&h=libreoffice-5-0 tdf#91782 - fix VirtualDevice allocation crasher in eps filter. It will be available in 5.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-5-0-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=23eec7bbf0cfbf6bdff4d98cdea77eb35ae6b5c4&h=libreoffice-5-0-1 tdf#91782 - fix VirtualDevice allocation crasher in eps filter. It will be available in 5.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 93471 has been marked as a duplicate of this bug. ***
*** Bug 93429 has been marked as a duplicate of this bug. ***
*** Bug 93585 has been marked as a duplicate of this bug. ***
*** Bug 93235 has been marked as a duplicate of this bug. ***
SUCCESSFUL eps export of chart in Calc LO Version: 5.0.1.2.0+ Build ID: 00m0(Build:2) Locale: en-US (en_US.UTF-8) on Linux OpenSuse 13.2 KDE Plasma 5.3.95.