Download it now!
Bug 108145 - Notebookbar background color should be defaulting to toolbar color
Summary: Notebookbar background color should be defaulting to toolbar color
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.4.0.0.alpha1+
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 106485 123827 124851 (view as bug list)
Depends on:
Blocks: Notebookbar-Theming
  Show dependency treegraph
 
Reported: 2017-05-27 03:53 UTC by Volga
Modified: 2019-05-14 09:29 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample (118.21 KB, application/vnd.oasis.opendocument.text)
2017-06-01 09:11 UTC, Volga
Details
Theming (75.17 KB, image/png)
2018-10-22 07:33 UTC, andreas_k
Details
Dark Personas Theme (78.02 KB, image/png)
2018-10-22 09:41 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Volga 2017-05-27 03:53:25 UTC
Description:
The default foreground color used on the Notebookbar looks lighter than the color used in toolbar, but the default background color looks darker than toolbar.

Steps to Reproduce:
-

Actual Results:  
-

Expected Results:
-


Reproducible: Always

User Profile Reset: No

Additional Info:
Version: 5.4.0.0.beta1 (x64)
Build ID: 8672113ead4e403c55e31b1d9a3d1e0f3b299577
CPU threads: 4; OS: Windows 6.19; UI render: default; 
Locale: zh-CN (zh_CN); Calc: group


User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
Comment 1 Yousuf Philips (jay) (retired) 2017-05-27 12:34:39 UTC
Hi Volga,

Can you send a screenshot of your regular toolbars and the notebookbar, as it has looked fine for me since bug 103235 was fixed.

Note: Notebookbar will have a single color similar to the menubar and wont have a gradient like toolbars.
Comment 2 Volga 2017-06-01 09:11:03 UTC
Created attachment 133779 [details]
Sample

OK Yousuf,

I send a file to you to describe which areas on Notebookbar mode should be looks like.
Comment 3 Yousuf Philips (jay) (retired) 2017-06-01 13:52:47 UTC
(In reply to Volga from comment #2)
> Created attachment 133779 [details]
> Sample

Thanks for the screenshot, but i'm not able to reproduce this on Linux or Windows in 5.5 daily. What version are you running?

@Stuart, @Buovjaga, @Xisco: Can either of you guys repo this?
Comment 4 Volga 2017-06-02 03:24:33 UTC
(In reply to Yousuf Philips (jay) from comment #3)
> Thanks for the screenshot, but i'm not able to reproduce this on Linux or
> Windows in 5.5 daily. What version are you running?
Oh, I forgot to report I just run LibO 5.4 beta1 on Windows 10.
Comment 5 V Stuart Foote 2017-06-02 05:46:20 UTC
(In reply to Volga from comment #0)
> Description:
> The default foreground color used on the Notebookbar looks lighter than the
> color used in toolbar, but the default background color looks darker than
> toolbar.

On Windows 10 Pro 64-bit en-US with
Version: 5.5.0.0.alpha0+ (x64)
Build ID: 6517fd2107a5a71290afad8850da0eab51519bc6
CPU threads: 8; OS: Windows 6.19; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2017-06-01_23:17:13
Locale: en-US (en_US); Calc: CL

The "foreground" color for an active tab _is_ lighter than the inactive tabs. While the inactive tabs have the same gray as used for the the toolbars. But I think both of those are implemented correctly.

As an aside, checking with a theme applied (Tools -> Options -> Personalization) would expect the "foreground" of the active tab would pick up a color when applying a theme--as is the tabbed Notebookbar does not style well when applying a theme.

Regards the separation of the menu bar (when active) from the Notebookbar, agree with Volga that the frame border is not needed and is visually jarring. We don't have a widget border separating the Standard toolbar from the Menu bar in default modes--so I think the decoration is not needed above the notebook bar modes when the menu bar is enabled.

Unfortunately, the "Groupedbar Full" and "Groupedbar Compact" modes will not toggle the menu bar active (bug 107158) so can not check border appearance and offset of the Menu bar in those modes. But if present it should be removed there as well. Think that would be an issue on its own.
Comment 6 Volga 2017-06-09 14:57:36 UTC
(In reply to V Stuart Foote from comment #5)
> The "foreground" color for an active tab _is_ lighter than the inactive
> tabs. While the inactive tabs have the same gray as used for the the
> toolbars. But I think both of those are implemented correctly.
Now I agree with you, but the default foreground for active tab looks a bit dull, is it possible to implement gradient effect in there?
 
> Regards the separation of the menu bar (when active) from the Notebookbar,
> agree with Volga that the frame border is not needed and is visually
> jarring. We don't have a widget border separating the Standard toolbar from
> the Menu bar in default modes--so I think the decoration is not needed above
> the notebook bar modes when the menu bar is enabled.
Yeah that’s right. BTW I found menu button (three dashes) on the notebookbar not joined with tab when I see attachment 133779 [details] again.
Comment 7 QA Administrators 2018-10-20 02:53:04 UTC Comment hidden (obsolete)
Comment 8 andreas_k 2018-10-22 07:33:05 UTC
Created attachment 145892 [details]
Theming

Hi,

From my point of view the theming is ok in 6.2 (alpha 1) My only suggestion would be to have the right menu button without boarders.
Comment 9 andreas_k 2018-10-22 09:41:40 UTC
Created attachment 145897 [details]
Dark Personas Theme

Tabbed toolbar didn't work with dark personas theme.
Comment 10 andreas_k 2018-10-23 19:28:29 UTC
*** Bug 106485 has been marked as a duplicate of this bug. ***
Comment 12 Heiko Tietze 2019-05-14 09:29:28 UTC
*** Bug 123827 has been marked as a duplicate of this bug. ***
Comment 13 Heiko Tietze 2019-05-14 09:29:45 UTC
*** Bug 124851 has been marked as a duplicate of this bug. ***