Bug 121877 - Tabbed UIs do not use theme color - keeps the default application color
Summary: Tabbed UIs do not use theme color - keeps the default application color
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 123254 124217 135522 137647 (view as bug list)
Depends on:
Blocks: Notebookbar-Theming Options-Dialog-Colours
  Show dependency treegraph
 
Reported: 2018-12-03 11:49 UTC by Pedro
Modified: 2022-09-09 15:49 UTC (History)
13 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Active tab with White background, while Tab name row shows user selected persona. (32.25 KB, image/png)
2018-12-03 11:49 UTC, Pedro
Details
Persona selected in Single toolbar. the background of active tab should be similar (26.11 KB, image/png)
2018-12-03 11:51 UTC, Pedro
Details
personas dark theme (22.65 KB, image/png)
2019-08-07 09:50 UTC, andreas_k
Details
themed tabbed UI in LO 7.2.4.1 on Ubuntu 18.04 using system dark theme (195.30 KB, image/png)
2021-12-22 02:43 UTC, stragu
Details
Related to Experimental Windows Dark Theme in 7.4 (104.38 KB, image/jpeg)
2022-03-17 10:51 UTC, Pedro
Details
Tabbed UI tabs assume same theme as dialog tabs (67.02 KB, image/png)
2022-03-20 09:45 UTC, Pedro
Details
LO 7.4 alpha0+ with theme on (39.18 KB, image/png)
2022-03-21 04:24 UTC, stragu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro 2018-12-03 11:49:28 UTC
Created attachment 147235 [details]
Active tab with White background, while Tab name row shows user selected persona.

Steps to reproduce:
1 - Select Tabbed UI,
2 - For ease of perception select a different persona (also visible with default gray).

When selecting the tabbed UI, the color of the tab in focus is not the default color of LibreOffice but instead it is a white color. In any other UI, the color is default gray or an user-select persona.

Instead, when a persona is selected, the row with the different tab categories assumes the selected persona (or default gray

Proposal:

The tab in active focus should get the default theme look or an user selected persona, while the tab name row should have the white color.
I believe this is only an issue in Windows.
Comment 1 Pedro 2018-12-03 11:51:54 UTC
Created attachment 147236 [details]
Persona selected in Single toolbar. the background of active tab should be similar
Comment 2 Heiko Tietze 2018-12-03 12:10:25 UTC
Would be nice to apply themes also to the tabs. Many similar requests around this in META bug 107191.

*** This bug has been marked as a duplicate of bug 107345 ***
Comment 3 Pedro 2018-12-09 10:18:18 UTC
Heiko, sorry but I reverted this because it is not a duplicate of 107345.
Thomas want the tabs to not look like tabs.

This bug refers to having the tabs show the color of the user selected persona or of the rest of the app (instead of having a white background).
Comment 4 Xisco Faulí 2018-12-10 16:01:05 UTC Comment hidden (obsolete)
Comment 5 Heiko Tietze 2018-12-10 16:02:53 UTC
Muhammet, what do you think about this request? Guess is hard to implement for all plugins.
Comment 6 Heiko Tietze 2019-02-18 11:08:47 UTC
*** Bug 123254 has been marked as a duplicate of this bug. ***
Comment 7 andreas_k 2019-04-10 21:11:32 UTC
(In reply to Pedro from comment #1)
> Created attachment 147236 [details]
> Persona selected in Single toolbar. the background of active tab should be
> similar

If you check other office suites like MSO or SoftMaker they have the active tab without color and the not activated tab's are colored. I also suggest to have it as it is now, but the not activated tabs get also the background color.
Comment 8 andreas_k 2019-08-07 09:50:54 UTC
Created attachment 153196 [details]
personas dark theme

if you use dark personas theme where the text color is white this is a real issue, that should be solved.
Comment 9 Timur 2019-09-12 09:52:28 UTC
*** Bug 124217 has been marked as a duplicate of this bug. ***
Comment 10 Locness 2019-12-28 10:27:34 UTC
On macOS it's working fine, except for the tabs - [bug 129665](https://bugs.documentfoundation.org/show_bug.cgi?id=129665)
Comment 11 V Stuart Foote 2020-08-07 19:12:05 UTC
*** Bug 135522 has been marked as a duplicate of this bug. ***
Comment 12 V Stuart Foote 2021-08-13 17:44:54 UTC
*** Bug 137647 has been marked as a duplicate of this bug. ***
Comment 13 stragu 2021-12-22 02:42:01 UTC
Reproduced with both Tabbed and Tabbed Compact UIs:

Version: 7.2.4.1 / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Note that the sidebar doesn't match the themes used in Options > LibreOffice > Personalization either.

Given that other reports affecting Linux were marked as duplicates, I am marking this one as affecting all OSs and changing the summary accordingly.

I agree that the them should be used better in the tabbed UIs (see how bad it looks currently in the screenshot in the next comment), but I guess the design team needs to decide what is best:
- applying the theme colour to both parts (tab title bar and active tab)
- applying the theme colour to only the tab title bar

In any case, there should still be a clear distinction between the active tab and the rest of the titles at the top.
Comment 14 stragu 2021-12-22 02:43:43 UTC
Created attachment 177075 [details]
themed tabbed UI in LO 7.2.4.1 on Ubuntu 18.04 using system dark theme

This is using the preinstalled theme "Green": only a rectangle around the active tab is visible.
Comment 15 Pedro 2022-03-17 10:51:56 UTC
Created attachment 178934 [details]
Related to Experimental Windows Dark Theme in 7.4

For Caolan, this bug has this impact on the Windows Dark theme implementation.
Comment 16 John Mills 2022-03-17 11:34:40 UTC
I would like to second my request if possible for this to be implemented, theming in Windows lags behind Linux. The dark mode is an expected feature of modern desktop software. With greater than 90% of users of LibreOffice being windows users this addition would make a big difference. The tabbed UI, or I guess any of the notebook bar layout are essential components of LibreOffice and hence the full darkmode should be available in all supported UI options.

Importantly I would like to express my thanks for the continued work of the LibreOffice developers for improving this great software.

Kind regards,

John
Comment 17 Pedro 2022-03-20 09:45:32 UTC
Created attachment 178991 [details]
Tabbed UI tabs assume same theme as dialog tabs

So, Caolán showed that the tabs of the Tabbed UI behave the same as the tabs from dialogs (ex. Bullets and Numbering dialog or Paragraph dialog).
This is why the tabs do not assume the theme color. And I am not sure if they should assume it. The dialog tabs shouldn't use theme colors and with tabs from Tabbed UI being the same... I am inclined to say this should not be an issue anymore.
If anyone else wants to chime in, they are welcome.
Comment 18 stragu 2022-03-21 04:24:41 UTC
Created attachment 178998 [details]
LO 7.4 alpha0+ with theme on

Unfortunately, I still see the bad use of "Options > LibreOffice > Personalization > LibreOffice Themes > Preinstalled Theme" when using the tabbed interface in the latest Linux build:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 59a7c40255b836ed75e64686fabb3e9938b755f0
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded