Download it now!
Bug 115439 - High DPI mode: SVG icons should be preferred over PNG versions when available
Summary: High DPI mode: SVG icons should be preferred over PNG versions when available
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.4.4.2 release
Hardware: All All
: high enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 105489 105778 105950 106191 106682 110356 110457 114444 115912 117158 117846 120851 122536 123480 (view as bug list)
Depends on: 130678
Blocks: HiDPI Icon-Themes-Code-SVG
  Show dependency treegraph
 
Reported: 2018-02-04 13:08 UTC by bugzilla2
Modified: 2020-10-10 03:00 UTC (History)
27 users (show)

See Also:
Crash report or crash signature:


Attachments
Breeze SVG icons in HiDPI screen (LO 6.4.2.2 in Ubuntu 20.04/Arch/Fedora 32) (4.81 KB, image/png)
2020-04-25 06:55 UTC, carlosjosepita
Details
Blurry Elementary SVG toolbar icons (309.13 KB, image/png)
2020-09-02 19:42 UTC, moosetrax
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bugzilla2 2018-02-04 13:08:45 UTC
Description:
In the current Icon-Sets there are already some Icons that exist in png AND svg versions. During my research for Bug 114699 I noticed, that the png versions can be deleted and LibO then uses the svg-versions of those Icons. Result is, that those Icons looks WAY better (perfectly sharp, no alias) then the upscaled png-versions.

So the question is, why does LibO still prefer the png-versions over the svg-ones?

Steps to Reproduce:
Open Writer (for example) and look at the icons.

Actual Results:  
They look badly (at least on HiDPI Screns). 

Expected Results:
The svg-icons should be used instead which look way better.


Reproducible: Always


User Profile Reset: No



Additional Info:


User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.121 Safari/537.36 Vivaldi/1.95.1077.41
Comment 1 andreas_k 2018-02-24 18:18:09 UTC
Hi

I know that libreoffice can use svg icons but the rendering is bad. So if you tell me that the svg rendering work well this is awesome. I will test it.

In the past only the breeze icon theme was available in svg so it wasn't to important to force the svg bug for me.

For 6.0 I update the elementary icon theme and with 6.1 an additional icon theme will be ready and available in svg.

Thanks for the feedback and please test as much as possible.
Comment 2 andreas_k 2018-02-24 18:57:06 UTC
It would be really awesome if the svg support would work perfect but we are not there. As long as the png files look better they have to be generated.

In windows the svg support is better than on linux fyi, but also not perfect.

If needed I can upload the breeze_svg and elementary_svg icon theme to the extension webpage.
Comment 3 Heiko Tietze 2018-02-25 07:40:49 UTC
There are still a few issues but there is light at the end of the tunnel http://nabble.documentfoundation.org/Re-minutes-of-ESC-call-tt4229391.html#a4229645
Comment 4 bugzilla2 2018-02-26 11:51:49 UTC
Well, for me (on Windows) the SVG Rendering was perfect, but I tested only a few Icons that were available in the Tango-Set (I only deleted the PNGs where SVG where present). So, absolutely possible, that some icons don't render right, when there are attributes missing in the SVG.

But if a patch already exists, and only needs testing, Icon Sets could soon be delivered in SVG at least on Windows :)

PS: Does anybody have a link to Tango Icon Set in SVG? Would be interesting to see how many icons really are broken...
Comment 5 andreas_k 2018-02-26 21:10:37 UTC
Tested the svg icon theme on linux work really good for me. In Virtualbox I had problem on a linux guest system. don't know why.

When I have time I'll upload the svg icon themes to the extension webpage.
Comment 6 andreas_k 2018-02-26 21:17:07 UTC
(In reply to andreas_k from comment #5)

wrong icon theme the rendering on linux is way not perfect.
Comment 7 Tomaz Vajngerl 2018-02-27 01:05:06 UTC
Yes, gtk3 backend has issues (because we use his way of doing HiDPI), which I know how to resolve (already did a proof-of-concept) but I need some spare time to implement it properly. The issue is described in ESC minutes...
Comment 8 Buovjaga 2018-03-07 16:49:36 UTC
*** Bug 115912 has been marked as a duplicate of this bug. ***
Comment 9 Buovjaga 2018-03-07 16:51:05 UTC
*** Bug 105489 has been marked as a duplicate of this bug. ***
Comment 10 Buovjaga 2018-03-07 16:51:51 UTC
*** Bug 105778 has been marked as a duplicate of this bug. ***
Comment 11 Buovjaga 2018-03-07 16:51:56 UTC
*** Bug 105950 has been marked as a duplicate of this bug. ***
Comment 12 Buovjaga 2018-03-07 16:52:00 UTC
*** Bug 106191 has been marked as a duplicate of this bug. ***
Comment 13 Buovjaga 2018-03-07 16:52:05 UTC
*** Bug 106682 has been marked as a duplicate of this bug. ***
Comment 14 Buovjaga 2018-03-07 16:52:09 UTC
*** Bug 110356 has been marked as a duplicate of this bug. ***
Comment 15 Buovjaga 2018-03-07 16:52:14 UTC
*** Bug 110457 has been marked as a duplicate of this bug. ***
Comment 16 Buovjaga 2018-03-07 16:52:17 UTC
*** Bug 114444 has been marked as a duplicate of this bug. ***
Comment 17 Xisco Faulí 2018-06-06 10:10:01 UTC
Dear Tomaz Vajngerl,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assigned it back to yourself if you're still working on this.
Comment 18 Buovjaga 2018-06-08 12:34:46 UTC
*** Bug 117158 has been marked as a duplicate of this bug. ***
Comment 19 Buovjaga 2018-06-18 07:43:00 UTC
*** Bug 117846 has been marked as a duplicate of this bug. ***
Comment 20 Matt 2018-08-09 01:40:42 UTC
Wasn't work just done to introduce new icons in 6.1?  Would it have made sense to work this as part of that?

Is calling this an enhancement accurate?  It's a bug for hi dpi screens, which are really common nowadays. I would think when the interface breaks even if not functionally broken that it's an issue from a usability perspective.  I love LibreOffice, but I keep reverting back to 5.2 so that the UI isn't broken.
Comment 21 Regina Henschel 2018-10-28 12:13:37 UTC
*** Bug 120851 has been marked as a duplicate of this bug. ***
Comment 22 V Stuart Foote 2018-10-31 03:03:14 UTC
*** Bug 105489 has been marked as a duplicate of this bug. ***
Comment 23 Regina Henschel 2018-11-02 16:06:17 UTC
Please notice bug 121130. [Nevertheless, I support to release the svg-themes as soon as possible.]
Comment 24 andreas_k 2018-12-21 11:47:43 UTC
Definitly true but only when the renderer give us the same quality as the png one.
Comment 25 V Stuart Foote 2019-02-15 13:32:08 UTC
*** Bug 122536 has been marked as a duplicate of this bug. ***
Comment 26 V Stuart Foote 2019-02-15 13:32:32 UTC
*** Bug 123480 has been marked as a duplicate of this bug. ***
Comment 27 Xisco Faulí 2019-11-29 12:39:43 UTC
Changing priority to 'high' since the number of duplicates is 5 or higher
Comment 28 andreas_k 2019-11-29 13:25:32 UTC
(In reply to andreas_k from comment #24)
> Definitly true but only when the renderer give us the same quality as the
> png one.

As long as the quality didn't work, I will block the patch.
Comment 29 Matt 2020-02-04 22:09:44 UTC
Just updated to Version: 6.4.0.3 (x64)
Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8

First build since tracking the blurry/poorly rendered icons on high dpi screens that I've seen the issue fixed.  

On a high dpi monitor (4k), seeing every SVG icon set render as expected, nice and crisp.

Not sure if my comment belongs here or a related issue. Just wanted to share.
Comment 30 Heiko Tietze 2020-02-05 10:44:19 UTC
(In reply to Matt from comment #29)
> Not sure if my comment belongs here or a related issue. 

Thanks for the feedback. SVG is indeed the future, and once we have finished the testing phase we will switch completely.
Comment 31 eisa01 2020-02-20 21:14:06 UTC
SVG icons are rendered blurry on macOS, so adding bug #130678 as a dependency
Comment 32 carlosjosepita 2020-04-25 06:52:02 UTC
> Just updated to Version: 6.4.0.3 (x64) Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8

> First build since tracking the blurry/poorly rendered icons on high dpi screens that I've seen the issue fixed.  

Well, lucky you. I'm on Ubuntu 20.04, LO 6.4.2.2 (also tested this in Arch and Fedora 32) and SVG icons are still blurry like in barely-recognizable-blurry.
Comment 33 carlosjosepita 2020-04-25 06:55:03 UTC
Created attachment 159915 [details]
Breeze SVG icons in HiDPI screen (LO 6.4.2.2 in Ubuntu 20.04/Arch/Fedora 32)
Comment 34 Jan-Marek Glogowski 2020-06-17 00:23:40 UTC
This is the typical chicken-egg problem: LO's SVG rasterizer / icons broken => default to PNG. Everybody uses PNG (and some complain about blocky icons in HiDPI) => nobody fixes the LO's SVG rasterizer / icons. Some more background info is in bug 133877 comment 11.

And OTOH people can manually select an SVG icon set, so the pressure to fix this isn't really high.

While the SVG icons easily look better when scaled, the PNG icons definitely look better in 100% / non-scaled in Linux.

And it also doesn't help that gtk3 always scales the rasterized icons, so you get the worse 100% SVG icons scaled to HiDPI.
Comment 35 Nate Graham 2020-06-17 02:09:45 UTC
In general I think people with high DPI screens would prefer to use SVG icons and live with or report a small number of bugs with a small number of mid-rendered icons then live with 100% of all icons being pixelated and ugly. Perhaps making the SVG renderer default only for high DPi users of SVG-compatible icon themes would make everyone happy: high DPI users get nicer icons overall, while devs get more user eyeballs (and bug reports, and potential contributors) using the SVG renderer.

FWIW all the icons look flawless to me with the Breeze SVG icon theme and a global 250% scale scale factor
Comment 36 bugzilla2 2020-06-17 09:06:33 UTC
(In reply to Jan-Marek Glogowski from comment #34)
> This is the typical chicken-egg problem: LO's SVG rasterizer / icons broken
> => default to PNG. Everybody uses PNG (and some complain about blocky icons
> in HiDPI) => nobody fixes the LO's SVG rasterizer / icons. Some more
> background info is in bug 133877 comment 11.

I totally agree on that, the main problem is the SVG Rasterizer (I guess that's the same as a SVG Renderer?). But there are plenty of free OpenSource SVG Renderers out there: Inkscape, Chromium, Firefox aso... all support SVG Rendering. Isn't it possible to use the code of those, if the LibO renderer is so hard to fix?

I know its easy to talk like that when you are not a developer, so just my two cents on that ;)
Comment 37 Rizal Muttaqin 2020-07-01 05:23:38 UTC
Just for your information. As an icon designer and mauntainer now all icon themes have SVG versions. So I would say its safe if in some point we reach perfect SVG support, than the PNG version can be removed or moved to the extension sites.
Comment 38 stragu 2020-07-25 07:18:29 UTC
*** Bug 131946 has been marked as a duplicate of this bug. ***
Comment 39 Paul Menzel 2020-08-12 11:16:10 UTC
In Debian Sid/unstable with GNOME 3.36.4 and LibreOffice 7.0.0, I switched the icon theme from *Elementary* to *Elementary (SVG)*, and the icons still look blurry on a HiDPI monitor connected over HDMI.
Comment 40 moosetrax 2020-09-02 19:42:42 UTC
Created attachment 165049 [details]
Blurry Elementary SVG toolbar icons

Blurry SVG icons with LibreOffice 7.0.0.3 on Cinnamon 4.2.4 at resolution Cinnamon 4.2.4.
Comment 41 moosetrax 2020-09-02 19:45:08 UTC
(In reply to moosetrax from comment #40)
> Created attachment 165049 [details]
> Blurry Elementary SVG toolbar icons
> 
> Blurry SVG icons with LibreOffice 7.0.0.3 on Cinnamon 4.2.4 at resolution
> Cinnamon 4.2.4.

Editing to provide resolution information for previous comment: 3840x2160