Description: In libreoffice table with checkboxes on first page gone. In mso and onlyoffice all look ok. Steps to Reproduce: 1.open my doc 2. 3. Actual Results: The whole document was melted Expected Results: Everything should look normal Reproducible: Always User Profile Reset: No Additional Info: User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Created attachment 140342 [details] doc with truble
Can you add an attachment that shows how the document should looks like?
Created attachment 140353 [details] Screenshot this doc in other office (look ok)
Created attachment 140359 [details] Compare DOCX in MSO and LO Bugzilla is not "document based", like "this document doesn't display nice". Bugzilla is "issue based", so a single issue must be pointed at, after a search for not being a duplicate. Bug report is not correct but issue exists: table content from .DOCX shown as text in Writer This docx is old 2007 format but that's not the reason.
This behavior started in 4.3. But also wasn't correct before. So not a regression but bibisect would be useful.
I do not know what the problem is. I hope it's just fixed. There are many rtf with a similar problem. In them, too, the tables disappear, although they are present in openoffice 4.1.5 or mso or onlyoffice. Attach an example? Is this the same problem? All these rtf are generated by the Russian program consultant +
> There are many rtf with a similar problem. In them, too, the tables > disappear, although they are present in openoffice 4.1.5 or mso or > onlyoffice. Attach an example? Is this the same problem? > All these rtf are generated by the Russian program consultant + I would open a new bug report for the rtf problem. See also the meta-bug 112765 about RTF Table bugs and enhancements
Used bibisect43max to identify commit cf33af732ed0d3d553bb74636e3b14c55d44c153 Author: Lubos Lunák CommitDate: Wed Apr 23 14:57:36 2014 +0200 handle w:gridBefore by faking cells (fdo#38414) Docx's w:gridBefore means that there should be this given space in the table grid before any cells come. But writer requires tables to be rectangular, so the space needs to be faked using cells without border. So far so good, but now reality in the form of the retarded overdesigned writerfilter comes. The internal representation of table data (and not just one actually) is pretty non-obvious and hard to modify, seems to be modelled just to follow the parser data the way it comes. Moreover dmapper gets notified of w:gridBefore only after cells in the row have been already processed. So after futile attempts to add the fake cells somehow in dmapper I've eventually given up and hacked up input handling to fake input as if the fake cells were actually there (which was tedious to find out as well, but at least it's reasonably doable). https://cgit.freedesktop.org/libreoffice/core/commit/?id=cf33af732ed0d3d553bb74636e3b14c55d44c153
*** Bug 122608 has been marked as a duplicate of this bug. ***
(In reply to Justin L from comment #8) > Used bibisect43max to identify commit > cf33af732ed0d3d553bb74636e3b14c55d44c153 > Author: Lubos Lunák > CommitDate: Wed Apr 23 14:57:36 2014 +0200 > > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=cf33af732ed0d3d553bb74636e3b14c55d44c153 Adding Cc: to Luboš Luňák
Another example: attachment 148176 [details] DOCX from Bug 122608 that should look like attachment 148177 [details] PDF.
*** Bug 111679 has been marked as a duplicate of this bug. ***
Also DOCX attachment 135443 [details] from 111679 Bug.
*** Bug 120512 has been marked as a duplicate of this bug. ***
*** Bug 120256 has been marked as a duplicate of this bug. ***
regression from LibreOffice 4.3, I don't think it deserves high priority at this point...
(In reply to Xisco Faulí from comment #16) > regression from LibreOffice 4.3, I don't think it deserves high priority at > this point... It's actually a quite bad one when looking at the consequences. Several duplicates too - I'd say high priority is warranted.
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/da1f71edfc72928b07a569b98e2766a8a7de9d2a tdf#116194 DOCX import: fix missing tables with w:gridBefore It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fixed in the following commits: https://gerrit.libreoffice.org/plugins/gitiles/core/+/b2c6d2d961a6113d0f111fab45ae12a40d389a23%5E%21 https://gerrit.libreoffice.org/plugins/gitiles/core/+/b2c6d2d961a6113d0f111fab45ae12a40d389a23%5E%21 Their descriptions: ----------------------------------------------------------------- tdf#116194 DOCX import: fix missing tables with w:gridBefore Regression from the commit cf33af732ed0d3d553bb74636e3b14c55d44c153 "handle w:gridBefore by faking cells (fdo#38414)" This patch replaces the previous fix with a better solution, fixing tdf#38414 on the proposed DomainMapper level. (Note: to reject the old fix completely, its follow-up commit w:gridAfter will be handled in a similar way.) Now the related regressions, tdf#111679, tdf#120512 and the complex forms of tdf#116194, tdf120256 and tdf#122608 are fixed, too. ---------------------------------------------------------------- fdo#38414 tdf#44986: DOCX table import: handle gridBefore/After without serious regressions, ie. losing the import of complex forms with multiple or nested tables. Complete the fix for tdf#116194 (DOCX import: fix missing tables with w:gridBefore) with handling gridAfter on DomainMapper level. This consists of also rejections (except their unit tests) of commit cf33af732ed0d3d553bb74636e3b14c55d44c153 (handle w:gridBefore by faking cells (fdo#38414)) and commit 1d1748d143ab4270a2ca1b5117852b1b1bb4c526 (Related: tdf#44986 DOCX import: handle w:gridAfter by faking cells)
Sorry, https://gerrit.libreoffice.org/plugins/gitiles/core/+/da1f71edfc72928b07a569b98e2766a8a7de9d2a%5E%21
László Németh committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/70274f86cdc1c023ffdd0130c262c1479262d76b tdf#116194 DOCX import: fix missing tables with w:gridBefore It will be available in 6.4.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
attachment 140342 [details] from this bug opens with table. There's small difference in table cell content, but that's some other bug, maybe bug 94801. attachment 148176 [details] DOCX from Bug 122608 is also OK. Also DOCX attachment 135443 [details] from 111679 Bug that looked like attachment 135444 [details]. And attachment 145601 [details] from 120512. Attachment 145308 [details] from bug 120256 now has table, but may not be quite correct so I'll reopen. László and NISZ, *thanks* for this major fix (and fix^2) that affects many users. I set Verified. Note: there's the nasty attachment 123770 [details] from bug 104347 that's marked as regression from tdf#44986 but explained that's not, the commit just uncovered an existing layout problem. So it's still wrong.
@Timur: many thanks for the detailed verification and your kind feedback! I'll checked the suggested bug 104347, I've already fixed a similar problem a few months ago, and I hope, with the upcoming table fixes, we will be able to fix that, too. Thanks again for your help!
Hi @László please consider looking into #120256 and complete your great work. Thanks :-)
*** Bug 125312 has been marked as a duplicate of this bug. ***
*** Bug 129729 has been marked as a duplicate of this bug. ***
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5087a64842b3e4c96905cc8a9304ec0154ea0d11 NFC tdf#116194 writerfilter: cleanup unused gridBefore pieces It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.