I honestly don't know what this would take, but it would be nice if LibreOffice for Mac supported the Mac OS X 10.7 ("Lion") native full-screen mode. The Mac OS fullscreen mode integrates the fullscreen window into the desktop spaces, making switching between the fullscreen window and other applications very easy.
I know this is low priority, especially since it's for Mac OS only, but I figure I can at least ask... :)
More info can be found at http://developer.apple.com/library/mac/documentation/General/Conceptual/MOSXAppProgrammingGuide/FullScreenApp/FullScreenApp.html
I think I already did a short writeup on my quick experimentation with adding support for Lion full-screen mode somewhere but can't find it any more;)
So, some time ago (right after Lion was released) I played a bit with adding support for the nice full-screen feature. Basically, getting it working in a quick-and-dirty way was easy, but then getting all the details right is more of a challenge, and would require some user experience expert input... Mainly, to decide how the existing LO full-screen feature should interact with the Lion-style full-screen feature. Not at all? Be superseded by it, but keep the same keyboard shortcut? Etc...
Anyway, in case somebody wants to continue hacking on this, I will attach a couple of diffs.
Created attachment 51649 [details]
If I recall correctly, this short diff makes the full-screen button (icon) appear for LO's document windows (and it works).
The code still compiles fine against the 10.4 SDK, and should as far as I see not attempt to use any feature not present on earlier OSes on them.
Created attachment 51650 [details]
Second patch, hack in progress
This is more hackish, I try to make LO modify its UI when it enters or leaves full-screen mode (like the existing View:Full Screen does). A third patch related to this will follow. This did not really work nicely yet when I stopped hacking on this.
(Basically, it is frustrating to work on stuff like making LO on the Mac more Mac-like when one knows that the NeoOffice people have already been doing that for some time, and they for instance already have support for Lion's new stuff. Duplicating work just because of licensing differences is not especially inspiring. At least not if you would do it in your spare time just for fun.)
Created attachment 51651 [details]
Third patch, hack in progress
Here then handle the "TOGGLEFULLSCREEN" app event the previous patch generates.
[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
*** Bug 43936 has been marked as a duplicate of this bug. ***
Until when is it expected? Can it implemented in LibO 3.6?
A lot of applications currently use the full-screen option merely as just that, a full-screen interface. Nothing custom, of course. Just a few lines to support it.
Since your code apparently works, can we at least push the first patch to get basic full-screen support?
I think that the question in comment #8 is for you, therefore I add you to the CC list ;-)
Status back to NEW: it was just set to NEEDINFO by Björn's bulk operation (see comment #5) and never reset as appropriate.
@Andreas: Read my comments. I have done nothing for this since.
As I said, "this did not really work nicely yet when I stopped hacking on this", so I don't feel like pushing such a work in progress. I also said "in case somebody wants to continue hacking on this"...
I don't have the inspiration to work any more on this issue in my own time, and I am not allocated to work on Mac stuff in my work.
*** Bug 58471 has been marked as a duplicate of this bug. ***
May be some of the AOOo tricks can work for LibO, too?
What AOO tricks? Do you have any pointers to code or discussion?
Sure cf. the equivalent AOO bug:
This is blocking on Kendy doing some work here I think :-) Kendy ?
Well, that AOO commit doesn't look that much more impressive than my old patches above;) Note the // TODO: implement something useful comments inside the #if 0 blocks.
The difficulty here is not the code to just enable full-screen as such (a dozen or so lines), but to decide how this kind of full-screen state should interact with LO's existing non-system full-screen feature. See comment #1.
> Well, that AOO commit doesn't look that much more impressive
> than my old patches above;)
Ah drat - I read too quickly and didn't notice them :-) certainly we should use your work instead. Presumably having something here is better than nothing, how do we move forward ? poke UX advise giving them a "this" vs. "nothing" option for 4.0 ? :-)
Actually the AOO patch looks a bit cleaner. Well, that was my first impression, based on the fact that it doesn't use objc_msgSend() to blindly send a message that isn't implemented before 10.7 like mine does, but checks with [NSWindow respondsToSelector:] and only if that is true, then uses [NSWindow performSelector:].
But when I try out how it behaves, there is some serious confusion in window state management and bad interaction with LO's own View:Full Screen. I'll check how my patch works, I don't recall any more. Maybe commit some suitable amalgamation of them...
Hmm, both my old patch and the AOO one work weirdly in some circumstances. Hard to say what to do... Just push in something so that we can brag "we have Mac OS X full-screen support", or actually think hard how it should interact with the current View:Full Screen thingie, and make sure that nothing weird happens?
(In reply to comment #20)
> Hard to say what to do... Just push in something so that we can brag "we
> have Mac OS X full-screen support", or actually think hard how it should
> interact with the current View:Full Screen thingie, and make sure that
> nothing weird happens?
"Do it right" should always prevail over "get it done". This shouldn't be a showstopper for anybody (certainly isn't for me, and I put the original bug in).
Actually, I think the AOO patch is quite buggy... it uses performSelector:withObject: to call the setCollectionBehavior method. That method takes an integer (NSWindowCollectionBehavior bit mask) as parameter, but it passes performSelector:withObject: an NSNumber object (pointer)... So presumably what actually happens in the AOO code is that the NSNumber pointer is interpreted as the bit mask, and (sometimes? always?) by coincidence it happens to have the "right" bit on that makes the full-screen decoration to appear. Heh.
So, either one should just use objc_msgSend() as in my patch to be on a lower level, or the verbose NSInvocation API. Hmm.
Tor Lillqvist committed a patch related to this issue.
It has been pushed to "master":
fdo#39983: Support Mac OS X 10.7 full-screen mode
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Created attachment 72070 [details]
Draw in Fullscreen mode
Freshly tested, working like a charm. :)
But one thing, an extra white area appears when taken to full screen mode (see screenshot), it would be great to get rid of that area to maintain a seamless full-screen experience.
Other than that perfect it seems.
When using the old full screen feature, LO switches to OS FS mode, but the small "Exit Full Screen" dialog box still stays open. So if I try to switch to normal mode using Mac OS X FS button, it exits full screen, but toolbars are not visible, and "Exit Full Screen" dialog is still open. I still have to press that button once more for toolbars to become visible.
I think LO Full Screen button should be removed, and replaced by the OS full screen functions totally.
Seems broken on Version 126.96.36.199.alpha0+ (Build ID: 69f2f50c99ba218b185d94b118b38ea92b6560a)
TinderBox: MacOSX-Intel@1-built_no-moz_on_10.6.8, Branch:master, Time: 2013-01-11_10:28:50.
View - Full Screen does not trigger it either. Just the usual old full screen feature.
The patch from comment #23 had to be reverted, see bug #58963. So yeah, we are back were we started.
(In reply to comment #27)
> The patch from comment #23 had to be reverted, see bug #58963. So yeah, we
> are back were we started.
In case of delay this fix to 4.1 you should update documentation page https://wiki.documentfoundation.org/ReleaseNotes/4.0
I've tested AOO latest builds and FS feature looks fine actually. The annoying extra bar above the main toolbar still exists but it shows all the toolbars, including the newly side pane, and works as expected. I'll test it further, and if there are any requests about specific tests, I can perform.
One thing, in AOO old FS feature and the OS X FS feature are still separate behaviours; this should be noted. So, this needs resolving, yeah.
Does the problem described in bug #58963 happen in AOO?
No, it does not occur. But after further playing with documents on AOO, I've realised that FS feature is not reliable as it should be. The FS icon has disappeared and I cannot find a way to make it re-appear. Before that it started acting totally random, if a document crashed and then recovered FS icon disappeared again. FS icon sometimes appeared on the start screen, sometimes not.
It would be great if someone else could test AOO behaviours, but at the moment I've changed my mind.
*** Bug 64152 has been marked as a duplicate of this bug. ***
We have progression here :)?
http://cgit.freedesktop.org/libreoffice/core/commit/?id=41d2036bee3279928903cdada115d3e3cd022a06 and http://cgit.freedesktop.org/libreoffice/core/commit/?id=4f3d79c1f54fb998119a099bad629804ad01eb36
Very exciting news.
I wonder how will this new implementation will behave with the existing FS mode. AOO completely messed it up, NeoOffice implementation with toolbars on seems pretty decent.
But I think existing FS feature should be completely disabled for Mac, unless we will have a "Reading Mode" kind of thing.
You do realize that "this new implementation" *is* the AOO one, right?
I haven't checked in detail, but I can tell that current implementation in AOO is not the most UX friendly one. But I still would not comment until I see this feature in LO master build.
Dumb question, but where are nightly Mac builds hosted? I'd like to play with the imported patch, but the directories at http://dev-builds.libreoffice.org/daily/master/ all seem to be empty. :/
Created attachment 83419 [details]
SS, missing toolbar
1.When switched to FS, a blank white bar is left at the top of the screen, which is very annoying to see.
2. When in OS X FS, clicking View - Full Screen switches to LO full screen view, expected behaviour would be turn off the OS X FS, or an option could be added for this to select between LO FS or OS X FS (turn off).
a. If we try to turn off the OS X FS by using the LO FS toolbar, then the only thing left is OS X blank texture screen.
b. Various scenarios in playing simultaneously with both features messes up the screen, SS attached.
3. When in LO FS, trying to switch to OS X FS does not work.
4. And two FS features at the same time will confuse users.
Also LO FS feature has a recent bug that removes the toolbars when turning it off, also that is very annoying. Added to See Also field.
So, it would be nice to address these issues, or to decide at least how will it behave, otherwise what's left will be a bad UX experience, and frustrated users I guess.
*** Bug 68284 has been marked as a duplicate of this bug. ***
It looks like this is fixed in LibreOffice 4.2 master version: 188.8.131.52.alpha0+
Build ID: 70ef99c447fcdb73ecadb8b3afd251ef8021a6cc
TinderBox: MacOSX-X86_64@43, Branch:master, Time: 2013-08-17_23:57:08
Should this bugs status be changed to closed/resolved fixed?
Read comment #35 and comment #36. I would not call this bug fixed until the full-screen mode actually works nicely, which it doesn't as Emir describes in comment #39.
Oké sorry for the noise then...
openOffice 4.0 has Full Screen on Mac OSX
@Erkan: Read comment #42. Maybe if you make your web browser full-screen you can see it better?
LibreOffice without "Full Screen" pictogram:
openOffice.org with "Full Screen" pictogram:
Full Screen pictogram can you see top right.
@Erkan: Did you notice the "4.2" in comment #41?
And I do think anybody interested in this bug is fully aware how the full-screen thingie in the status bar looks and works (in proper full-screen -aware applications, like Safari, Aperture, Xcode etc, to mention some of Apple's own).
Yes and I want try with LO 4.2 but nothing find on the website :/
(In reply to comment #48)
> Yes and I want try with LO 4.2 but nothing find on the website :/
You can find daily builds here.
Yes! this béta/dev for LO 4.2 has full screen (-:
Do you know when is LO 4.2 be release?
Changing target from 4.1 to 4.2.
@Tor: I know you said sth about this question earlier, but don't you think this bug here should be closed and the issues described by Emir in comment 39 put into into separate bug reports? Afaik that's the standard policy. If needed we can create a meta bug for OS X fullscreen bugs then.
works on master
In LibreOffice 4.2.4 the Mac OS X fullscreen mode is only accessible through the button on the righthandside of the top bar for the window, not through the View menu. In Neo Office there are 2 menu entries to switch to either mode (or was that Chrome?).
Is this intentional? Why is the (IMHO silly) traditional fullscreen mode with the floating 'fullscreen' button (*) still there?
If we could finalise the decision in this bug report to either 'leave as-is because...' or 'yes, will change' that would be great.
(*) The button says 'fullscreen' but switches to 'windowed' mode by the way.
@Nick: As I have said right from the start, yes, in order to "support" (personally I loathe that word, and would rather say "provide" perhaps) the OS X full-screen mode *properly*, "we" (meaning "anybody who is funded or otherwise bothers to do the work") should also get rid of LO's own full-screen mode, and correspoindingly make sure that when in the OS full-screen mode, corresponding changes to the UI are done, too. My personal opinion is that until that is done, we should just not bother with the OS X full-screen mode. It is not worth it as currently implemented.
@Tor: Your personal opinion aside about whether or not fullscreen mode is useful (*) the mode as is is useful to some. With the timesheet in a separate desktop I am already very happy!
You are talking about funding: with basic support done people can actually start whining about it, and whining will focus attention and funding. My statement tries to keep this issue alive and focus on the next little step that could be taken here.
(*) Personally I -love- fullscreen mode because I am easily distracted by other windows. I am a multi-tasker at heart and have been (currently there is tripwire processing a machine, a number of terminals with unfinished sysadmin stuff, mail, web surfing windows, spreadsheet with my timesheet, itunes backing up my phone, todo list, etc.)
I am not arguing that full-screen mode in applications is not useful. It is, very much so, *when implemented sanely*. I use full-screen mode about half of the time in an Aperture session, now and then in Safari, and all the time when viewing photos, for instance.
What I mean is that as currently implemented in LibreOffice, which is a quick hack, it is not necessarily that useful.
FWIW, in Yosemite, clicking on the Window expand button (green one), makes the application go fullscreen (and vice-versa).
However, we are still left with a blank bar at the top of the screen, see bug 76476 for that.
Comment #56 pretty much sums up my opinion, still.
Fullscreen is there. It doesn't work great, but it's there. Thus I suggest to kill this monster bug.
Any remaining issues (and there are a few) should be dealt with in separate bugs (following the "one problem per bug" rule).
The white top line bug is 10.8 specific. It's gone on 10.11 btw. So anybody effected should consider doing the free update to 10.11, which is recommended anyways since it has a ton of important security fixes.