Bug 73953 - UI Writer, enhancement request: Allow adjustment of comment bar width
Summary: UI Writer, enhancement request: Allow adjustment of comment bar width
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.5.2 release
Hardware: All All
: medium enhancement
Assignee: Samuel Mehrbrodt (allotropia)
URL:
Whiteboard: target:24.8.0 inReleaseNotes:24.8
Keywords:
: 95958 97341 119687 125632 149054 149405 (view as bug list)
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
 
Reported: 2014-01-23 03:26 UTC by tiamistiam
Modified: 2024-09-05 18:25 UTC (History)
18 users (show)

See Also:
Crash report or crash signature:


Attachments
Comment section Change width (71.82 KB, image/jpeg)
2019-02-10 18:43 UTC, Elshan
Details
Screenshot of the comments bar (71.82 KB, image/jpeg)
2019-02-10 18:48 UTC, Elshan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tiamistiam 2014-01-23 03:26:15 UTC
Allow the user to adjust the width of the comment bar independent of other settings. 

Right now the comment bar is a fixed size in print layout, and can only be adjust in web layout by zooming in to make text larger.
Comment 1 Jean-Baptiste Faure 2014-01-25 12:45:32 UTC Comment hidden (me-too)
Comment 2 Preston Maness 2014-08-28 04:00:53 UTC Comment hidden (me-too)
Comment 3 Maris Nartiss 2017-08-29 08:30:36 UTC Comment hidden (me-too)
Comment 4 Ted Lee 2018-07-13 17:51:53 UTC Comment hidden (me-too)
Comment 5 Lars Jødal 2018-09-04 13:31:24 UTC
*** Bug 119687 has been marked as a duplicate of this bug. ***
Comment 6 Elshan 2019-02-10 18:43:42 UTC
Created attachment 149069 [details]
Comment section Change width
Comment 7 Elshan 2019-02-10 18:48:31 UTC Comment hidden (me-too)
Comment 8 Dieter 2019-06-02 08:15:06 UTC
*** Bug 125632 has been marked as a duplicate of this bug. ***
Comment 9 DarkTrick 2019-06-04 03:09:29 UTC Comment hidden (me-too)
Comment 10 Gauthier 2020-11-06 08:41:28 UTC Comment hidden (me-too)
Comment 11 dww 2021-02-08 23:58:14 UTC
In sw/source/uibase/docvw/PostItMgr.cxx, function SwPostItMgr::GetSidebarWidth()

I edited the line

    tools::ULong aWidth = static_cast<tools::ULong>(nZoom * 1.8);

and changed it to 

    tools::ULong aWidth = static_cast<tools::ULong>(nZoom * 4.0);


This works nicely on my local build, giving me wider comments.  Seems that it should be easy enough to provide this value as a user preference rather than hard-compiled in.
Comment 12 DarkTrick 2021-02-09 01:54:48 UTC Comment hidden (off-topic)
Comment 13 Lars Jødal 2021-02-09 06:00:37 UTC
*** Bug 97341 has been marked as a duplicate of this bug. ***
Comment 14 poussier.un 2021-04-18 21:56:22 UTC Comment hidden (me-too)
Comment 15 Gauthier 2021-11-06 08:49:53 UTC Comment hidden (spam)
Comment 16 Simon Oosthoek 2023-05-23 19:01:53 UTC Comment hidden (me-too)
Comment 17 Lars Jødal 2023-05-24 06:17:35 UTC
*** Bug 97341 has been marked as a duplicate of this bug. ***
Comment 18 Lars Jødal 2023-05-24 06:19:33 UTC
*** Bug 149054 has been marked as a duplicate of this bug. ***
Comment 19 Lars Jødal 2023-05-24 06:21:28 UTC
*** Bug 149405 has been marked as a duplicate of this bug. ***
Comment 20 Lars Jødal 2023-05-24 06:23:24 UTC
*** Bug 95958 has been marked as a duplicate of this bug. ***
Comment 21 Commit Notification 2024-01-11 08:04:20 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ac2720dcbe4e51e7f6733a385b5f7b571c6431e9

tdf#73953 sw: Allow resizing the comment section

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Commit Notification 2024-01-11 13:02:16 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cf9d8631ee5d4b894425446a9e6a8c939ab0309c

Related tdf#73953 Increase default comment width

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 vena.cava@virgin.net 2024-01-12 09:26:00 UTC
I think it is a good idea for the comment box size to be adjustable. I have used the comment boxes and they can get very crowded. 

Also, when a text page with comment boxes is printed to pdf, there is a huge amount of waisted space on the right side of the page, which it is not possible to adjust. Should this be listed as a separate bug?

Also, comment boxes do not appear in print preview. There is no option to include or exclude comment boxes in the print preview. Should this be listed as a separate bug?
Comment 24 Rafael Lima 2024-01-12 11:35:58 UTC
*** Bug 159145 has been marked as a duplicate of this bug. ***
Comment 25 steve 2024-01-12 11:41:30 UTC
Testing this change in

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ba8f4bff6015013013df652efbfaf4d9ae10c881
CPU threads: 8; OS: macOS 13.6.3; UI render: Skia/Raster; VCL: osx
Locale: de-DE (en_DE.UTF-8); UI: en-US
Calc: threaded

Can confirm default width is wider which is a long overdue change. Thanks so much for that, Samuel. Sane defaults are a great thing.

What I had issues with to verify is to change comment width.

And after fiddling around for 10 minutes I found out, I need to enable ruler (shift + cmd + r on macOS to show ruler). Then I can drag the comment field in the ruler UI to change width.

I have nothing against allowing this behavior. But why make it so confusing and complicated to change width?

Here's a follow-up issue to implement an easier UX: https://bugs.documentfoundation.org/show_bug.cgi?id=159145

There is a remaining problem with redrawing background UI after changing width:
https://bugs.documentfoundation.org/show_bug.cgi?id=159146

Setting this to verified as the scope of the issue here is probably covered sufficiently.

Lets close this 10 year old issue and continue with the new issues for the remaining problems and enhancements.