Writer: Table > Properties > Background Format > Color > Highlighting Insert > Section > Background Calc: Format > Cells > Background Format > Page > Background On the positive side (apart from the nice palette (handling) improvements in 5.3): in these cases the palette can be selected in the properties panel in the side bar.
And another one: Tools > Options > Charts > Default Colors
Definitely, those dialogs should provide access to the color palettes (no UX advice needed). But I expect that a ticket has been filed. Jay is usually faster than us. (In reply to Cor Nouws from comment #0) > Writer: > Format > Color > Highlighting What format?
(In reply to Heiko Tietze from comment #2) > > Writer: > > Format > Color > Highlighting > > What format? Color with the c of Character :D - sorry
Yes the intent of the new single area tab was to replace all the background and highlighting tabs and disabling various tabs within it when applicable (e.g. we would only need the color tab for Format > Color > Highlighting). Of course the table background would be the trickiest, as you can change the background color of a cell or the table. Possible duplicate of bug 86564.
(In reply to Yousuf Philips (jay) from comment #4) > Possible duplicate of bug 86564. Sort of, in any case related. But that bug doesn't mention the palette selector as such? And it does not reflect the tremendous and, from what I see, nearly finished work here.
(In reply to Regina Henschel from comment #1) > And another one: Tools > Options > Charts > Default Colors And another one: Calc: context menu on sheet tab .. > Tab Color
The style editors, as opposed to direct formatting dialogs, also seem to be affected. Perhaps these are based on the same dialogs so, for example, a fix for Format > Cells > Background would also fix the "Background" tab of Calc's Cell Style editor, but thought I'd mention it in case not. However, the workaround to use the "properties" panel doesn't seem to be an option for editing styles...
Raising priority since many users are affected.
*** Bug 106244 has been marked as a duplicate of this bug. ***
*** Bug 104172 has been marked as a duplicate of this bug. ***
*** Bug 99806 has been marked as a duplicate of this bug. ***
*** Bug 105740 has been marked as a duplicate of this bug. ***
Heiko, bug 105740 seems to be different (a regression), and not related to this.
*** Bug 106534 has been marked as a duplicate of this bug. ***
Another places in LibO 5.3.0.3: Impress: Format > Character > Highlighting Draw: Format > Character > Highlighting
Another place in LibO 5.3.1.2: Writer: Edit > Find & Replace > Format > Highlighting
*** Bug 106741 has been marked as a duplicate of this bug. ***
*** Bug 107842 has been marked as a duplicate of this bug. ***
*** Bug 108527 has been marked as a duplicate of this bug. ***
*** Bug 108900 has been marked as a duplicate of this bug. ***
How difficult is this to fix? As a stopgap, could the broken tabs be changed to have just a single dropdown button (the one used in the toolbars, sidebard, and some dialogs)? This might not be ideal, but surely it's better to at least have something functional.
(In reply to Kenneth Hanson from comment #21) > How difficult is this to fix? Forwarding this question to Jim. Is it in your capabilities?
Hi All, It may take awhile but it is within my capabilities.
(In reply to Yousuf Philips (jay) from comment #4) > Yes the intent of the new single area tab was to replace all the background > and highlighting tabs and disabling various tabs within it when applicable > (e.g. we would only need the color tab for Format > Color > Highlighting). > Of course the table background would be the trickiest, as you can change the > background color of a cell or the table. > > Possible duplicate of bug 86564. This was a big help. Been making good progress. Format > Color > Highlighting has been adapted.
Here's another place another color palette cannot be selected (LibreOffice 5.3.1.2): Calc: Format > Page > Header (or Footer) > More > Background
Created attachment 137749 [details] Calc - Header&Footer - Background Color UI
Here is a patch that uses the Area tab with relevant buttons displayed according to background needs. Character, Sections, and Table for Writer are functional in this patch. The Edit Sections Options still has the bug of not displaying current background in the tab after a document has been closed and reopened. This is a bug in the sections code itself. Table background is only by cell. A workaround for the 'by cell, row or table' drop down in the old background tab is to select rows, columns, or entire table and then apply background. https://gerrit.libreoffice.org/#/c/44929/
(In reply to Jim Raykowski from comment #27) > Table background is only by cell. A workaround for the 'by cell, row or > table' drop down in the old background tab is to select rows, columns, or > entire table and then apply background. If the row or table is selected, would it be setting the color at the row and table level? What is the intended fix for this temporary workaround? If there isnt an intended fix for this, then table background should be left out of the fix.
(In reply to Yousuf Philips (jay) from comment #28) > (In reply to Jim Raykowski from comment #27) > > Table background is only by cell. A workaround for the 'by cell, row or > > table' drop down in the old background tab is to select rows, columns, or > > entire table and then apply background. > > If the row or table is selected, would it be setting the color at the row > and table level? What is the intended fix for this temporary workaround? If > there isnt an intended fix for this, then table background should be left > out of the fix. Hi Jay, It has been a while since I've looked at this. Table background is work in progress. In addition to not being able to set table background by row, or table there is the problem of after setting a bitmap background the image is not selected in the bitmap list when the table properties dialog is reopened. This can cause no image to be set if the OK button is pressed without first clicking on a bitmap in the list. It has to do with the new background tab needing loext:graphic-properties to reselect the image. At this time it is beyond my knowledge of how to do this. Maybe the best thing would be to abort the current patch and make separate commits under this bug report for each reported place that will use the new background tab? Using the new background tab for character highlighting is the only place that I feel is ready at this time.
(In reply to Jim Raykowski from comment #29) > Maybe the best thing would be to abort the current patch and make separate > commits under this bug report for each reported place that will use the new > background tab? Using the new background tab for character highlighting is > the only place that I feel is ready at this time. Please do this! :) This would allow for incremental progress, and also for parallelism in implementing that for different areas (if others would like, they could coordinate their work here with you).
(In reply to Jim Raykowski from comment #29) > Maybe the best thing would be to abort the current patch and make separate > commits under this bug report for each reported place that will use the new > background tab? Using the new background tab for character highlighting is > the only place that I feel is ready at this time. +1
Here is a link to a patch for the table properties background tab page based on the area tab page with set by cell, row, table. https://gerrit.libreoffice.org/#/c/48797/
(In reply to Jim Raykowski from comment #32) > Here is a link to a patch for the table properties background tab page based > on the area tab page with set by cell, row, table. > > https://gerrit.libreoffice.org/#/c/48797/ Please notice the discussion in bug 103602. For page exists a consensus to use <style:drawing-page-properties>. But for the other cases, e.g. tables, a consensus how and where to put the information in file format is still missing. Your proposal misses save and load totally. (In reply to Jim Raykowski from comment #29) > Using the new background tab for character highlighting is > the only place that I feel is ready at this time. I disagree. There exists not even a consensus, whether gradient, image, or hatch should be allowed for characters.
(In reply to Regina Henschel from comment #33) > (In reply to Jim Raykowski from comment #29) > > Using the new background tab for character highlighting is > > the only place that I feel is ready at this time. > I disagree. There exists not even a consensus, whether gradient, image, or > hatch should be allowed for characters. I support this to enhance the highlighting possibilities, but I assume this is the right place for it? We would flood this bug with discussions about a half dozen of different places where some want more filling options than before. It's better to only coordinate/collect the implementation here.
(In reply to Thomas Lendo from comment #34) > I support this to enhance the highlighting possibilities, but I assume this > is the right place for it? We would flood this bug with discussions about a > half dozen of different places where some want more filling options than > before. It's better to only coordinate/collect the implementation here. ... this is _not_ the right place ...
Created attachment 139448 [details] new highlight tab page for character dialog
Created attachment 139449 [details] new background tab page for Table Properties dialog
Hi All, As Jay noted in comment 4 the Area background tab page can be used as a base for the highlight and background tab pages by disabling various tabs within it (hatch, pattern, bitmap, etc). Attached are screen shots that show the purposed highlight tab page for the character dialog and background tab page for the table properties dialog.
(In reply to Jim Raykowski from comment #38) > Attached are screen shots that show the purposed highlight tab page for the > character dialog and background tab page for the table properties dialog. Look good & clear to me - thanks so far! (Tend to agree with Thomas in principle comment #34 - but since we are so far with these two ones... for practical reasons..)
My issue was that the palette for Calc: Format > Cells > Background Format > Page > Background had changed after LibreOffice version 5.2, losing colors I wanted and used. Easy to fix. Here's how to add an extra row of custom colors. Simply edit /opt/libreoffice/share/palette/standard.soc by adding before the final </office:color-table> line in that file the following example: <!-- My custom colors --> <draw:color draw:name="Blue 8" draw:color="#99ccff"/> <draw:color draw:name="Blue 9" draw:color="#CFE7F5"/> <draw:color draw:name="Pale green" draw:color="#ccffff"/> This will add an extra line to the palette accessible in the palette command above. The full version 5.2 palette follows: <?xml version="1.0" encoding="UTF-8"?> <office:color-table xmlns:office="http://openoffice.org/2000/office" xmlns:style="http://openoffice.org/2000/style" xmlns:text="http://openoffice.org/2000/text" xmlns:table="http://openoffice.org/2000/table" xmlns:draw="http://openoffice.org/2000/drawing" xmlns:fo="http://www.w3.org/1999/XSL/Format" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:meta="http://openoffice.org/2000/meta" xmlns:number="http://openoffice.org/2000/datastyle" xmlns:svg="http://www.w3.org/2000/svg" xmlns:chart="http://openoffice.org/2000/chart" xmlns:dr3d="http://openoffice.org/2000/dr3d" xmlns:math="http://www.w3.org/1998/Math/MathML" xmlns:form="http://openoffice.org/2000/form" xmlns:script="http://openoffice.org/2000/script"> <draw:color draw:name="Black" draw:color="#000000"/> <draw:color draw:name="Blue" draw:color="#000080"/> <draw:color draw:name="Green" draw:color="#008000"/> <draw:color draw:name="Turquoise" draw:color="#008080"/> <draw:color draw:name="Red" draw:color="#800000"/> <draw:color draw:name="Magenta" draw:color="#800080"/> <draw:color draw:name="Brown" draw:color="#808000"/> <draw:color draw:name="Gray" draw:color="#808080"/> <draw:color draw:name="Light gray" draw:color="#c0c0c0"/> <draw:color draw:name="Light blue" draw:color="#0000ff"/> <draw:color draw:name="Light green" draw:color="#00ff00"/> <draw:color draw:name="Light cyan" draw:color="#00ffff"/> <draw:color draw:name="Light red" draw:color="#ff0000"/> <draw:color draw:name="Light magenta" draw:color="#ff00ff"/> <draw:color draw:name="Yellow" draw:color="#ffff00"/> <draw:color draw:name="White" draw:color="#ffffff"/> <draw:color draw:name="Gray 80%" draw:color="#333333"/> <draw:color draw:name="Gray 70%" draw:color="#4c4c4c"/> <draw:color draw:name="Gray 60%" draw:color="#666666"/> <draw:color draw:name="Gray 40%" draw:color="#999999"/> <draw:color draw:name="Gray 30%" draw:color="#b3b3b3"/> <draw:color draw:name="Gray 20%" draw:color="#cccccc"/> <draw:color draw:name="Gray 10%" draw:color="#e6e6e6"/> <draw:color draw:name="Blue gray" draw:color="#e6e6ff"/> <draw:color draw:name="Red 1" draw:color="#ff3366"/> <draw:color draw:name="Red 2" draw:color="#dc2300"/> <draw:color draw:name="Red 3" draw:color="#b84700"/> <draw:color draw:name="Red 4" draw:color="#ff3333"/> <draw:color draw:name="Red 5" draw:color="#eb613d"/> <draw:color draw:name="Red 6" draw:color="#b84747"/> <draw:color draw:name="Red 7" draw:color="#b80047"/> <draw:color draw:name="Red 8" draw:color="#99284c"/> <draw:color draw:name="Magenta 1" draw:color="#94006b"/> <draw:color draw:name="Magenta 2" draw:color="#94476b"/> <draw:color draw:name="Magenta 3" draw:color="#944794"/> <draw:color draw:name="Magenta 4" draw:color="#9966cc"/> <draw:color draw:name="Magenta 5" draw:color="#6b4794"/> <draw:color draw:name="Magenta 6" draw:color="#6b2394"/> <draw:color draw:name="Magenta 7" draw:color="#6b0094"/> <draw:color draw:name="Magenta 8" draw:color="#5e11a6"/> <draw:color draw:name="Blue 1" draw:color="#280099"/> <draw:color draw:name="Blue 2" draw:color="#4700b8"/> <draw:color draw:name="Blue 3" draw:color="#2300dc"/> <draw:color draw:name="Blue 4" draw:color="#2323dc"/> <draw:color draw:name="Blue 5" draw:color="#0047ff"/> <draw:color draw:name="Blue 6" draw:color="#0099ff"/> <draw:color draw:name="Blue 7" draw:color="#00b8ff"/> <draw:color draw:name="Blue 8" draw:color="#99ccff"/> <draw:color draw:name="Blue 9" draw:color="#CFE7F5"/> <draw:color draw:name="Turquoise 1" draw:color="#00dcff"/> <draw:color draw:name="Turquoise 2" draw:color="#00cccc"/> <draw:color draw:name="Turquoise 3" draw:color="#23b8dc"/> <draw:color draw:name="Turquoise 4" draw:color="#47b8b8"/> <draw:color draw:name="Turquoise 5" draw:color="#33a3a3"/> <draw:color draw:name="Turquoise 6" draw:color="#198a8a"/> <draw:color draw:name="Turquoise 7" draw:color="#006b6b"/> <draw:color draw:name="Turquoise 8" draw:color="#004a4a"/> <draw:color draw:name="Green 1" draw:color="#355e00"/> <draw:color draw:name="Green 2" draw:color="#5c8526"/> <draw:color draw:name="Green 3" draw:color="#7da647"/> <draw:color draw:name="Green 4" draw:color="#94bd5e"/> <draw:color draw:name="Green 5" draw:color="#00ae00"/> <draw:color draw:name="Green 6" draw:color="#33cc66"/> <draw:color draw:name="Green 7" draw:color="#3deb3d"/> <draw:color draw:name="Green 8" draw:color="#23ff23"/> <draw:color draw:name="Yellow 1" draw:color="#e6ff00"/> <draw:color draw:name="Yellow 2" draw:color="#ffff99"/> <draw:color draw:name="Yellow 3" draw:color="#ffff66"/> <draw:color draw:name="Yellow 4" draw:color="#e6e64c"/> <draw:color draw:name="Yellow 5" draw:color="#cccc00"/> <draw:color draw:name="Yellow 6" draw:color="#b3b300"/> <draw:color draw:name="Yellow 7" draw:color="#808019"/> <draw:color draw:name="Yellow 8" draw:color="#666600"/> <draw:color draw:name="Brown 1" draw:color="#4c1900"/> <draw:color draw:name="Brown 2" draw:color="#663300"/> <draw:color draw:name="Brown 3" draw:color="#804c19"/> <draw:color draw:name="Brown 4" draw:color="#996633"/> <draw:color draw:name="Orange 1" draw:color="#cc6633"/> <draw:color draw:name="Orange 2" draw:color="#ff6633"/> <draw:color draw:name="Orange 3" draw:color="#ff9966"/> <draw:color draw:name="Orange 4" draw:color="#ffcc99"/> <draw:color draw:name="Violet" draw:color="#9999ff"/> <draw:color draw:name="Bordeaux" draw:color="#993366"/> <draw:color draw:name="Pale yellow" draw:color="#ffffcc"/> <draw:color draw:name="Pale green" draw:color="#ccffff"/> <draw:color draw:name="Dark violet" draw:color="#660066"/> <draw:color draw:name="Salmon" draw:color="#ff8080"/> <draw:color draw:name="Sea blue" draw:color="#0066cc"/> <draw:color draw:name="Chart 1" draw:color="#004586"/> <draw:color draw:name="Chart 2" draw:color="#ff420e"/> <draw:color draw:name="Chart 3" draw:color="#ffd320"/> <draw:color draw:name="Chart 4" draw:color="#579d1c"/> <draw:color draw:name="Chart 5" draw:color="#7e0021"/> <draw:color draw:name="Chart 6" draw:color="#83caff"/> <draw:color draw:name="Chart 7" draw:color="#314004"/> <draw:color draw:name="Chart 8" draw:color="#aecf00"/> <draw:color draw:name="Chart 9" draw:color="#4b1f6f"/> <draw:color draw:name="Chart 10" draw:color="#ff950e"/> <draw:color draw:name="Chart 11" draw:color="#c5000b"/> <draw:color draw:name="Chart 12" draw:color="#0084d1"/> </office:color-table> Or, you can create and add your own custom colors.
Will this make it into of the next releases? I'm currently editing colors using the fodt format and a text editor ... (I need to change the background for a character style).
*** Bug 116232 has been marked as a duplicate of this bug. ***
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=41f1a38b9e8b5e0567bf642d3e14a549e82ee0d9 tdf#105225 A table properties background tab page It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cac80ccacf917e7e80f75c3574cc2a300f1d775a tdf#105225 A character highlighting tab page based on the area tab page It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A polite ping to Jim Raykowski: Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing? Thanks
(In reply to Xisco Faulí from comment #45) > A polite ping to Jim Raykowski: > Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? > Otherwise, Could you please explain what's missing? > Thanks Only Writer table properties background and character highlighting have been done. Remaining requests gathered from comments are: Writer: Insert > Section > Background Edit > Find & Replace > Format > Highlighting Calc: Format > Cells > Background Format > Page > Background Format > Page > Header (or Footer) > More > Background Sheet > Sheet Tab Color Impress: Format > Character > Highlighting Draw: Format > Character > Highlighting All: Tools > Options > Charts > Default Colors
Here is a patch for Writer: Insert > Section > Background and Section context menu > Edit Section... https://gerrit.libreoffice.org/#/c/55149/
Hi All, I came across another place in Writer for this: Insert > Table of Contents and Index > Table of Contents, Index or Bibliography... > Background and Table of Contents context menu > Edit Index > Background Here is a patch to use the new Background tab for these: https://gerrit.libreoffice.org/#/c/55151/
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=94cb2ac3cb5f2c951f70c3bf6b28aad9e2c0bdb7 tdf#105225 A section background tab page based on the area tab page It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6a4db3a7a57926d586bb4e43ae2d77ea29847fcd tdf#105225 A TOX background tab page based on the area tab page It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 118151 has been marked as a duplicate of this bug. ***
Here is a patch to use the new background tab page in the Calc Page Style dialog: https://gerrit.libreoffice.org/#/c/56218/
I forgot to post a patch made a while back that uses the new background tab page in Calc Format Cells dialog: https://gerrit.libreoffice.org/#/c/55357/
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=76d9d6c9bf0167d4203d7e2f6867254687915caa tdf#105225 new background tab page for Calc Format Cells dialog It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
This patch is for Draw/Impress Highlighting tab page in the Character dialog https://gerrit.libreoffice.org/#/c/56574/
@Jim: With that change in Calc the old "No Fill" selection seems to have been replaced by the None button, but selecting that None and OK applies some blueish background instead of none/nofill.
And invoked on a not-filled cell the Active colour shouldn't be represented as White.
Hi Eike, I'm at bit of a loss how that got by me. Need the XATTR_FILLSTYLE attribute in the passed itemset here to let the area tab page know what background/area sub tab page to select on invocation. Thanks for letting me know. Here is the patch: https://gerrit.libreoffice.org/#/c/56983/
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f432d96eb30c91578f11491778a7c3fb823f166a tdf#105225 fix new background tab page in calc format cells dialog It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 143317 [details] Backtrace for crash after Enter for OK Thanks. There's a crash though: 1. invoke dialog on not-filled cell 2. None is selected (nice) 3. click Color button 4. click a color 5. hit Enter for OK => crash does not happen when clicking OK Same happens in Writer for a table cell or page background, so looks like a generic problem of this dialog tabpage, apparently a widget is notified too late after disposed. Crash is deep down in weld::CustomWeld::DoLoseFocus(), see attached backtrace.
Indeed, I can reproduce it in Version: 6.2.0.0.alpha0+ Build ID: 0e83efbccc180c957f77291fc0fdc6dd74eae0f4 CPU threads: 4; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: ca-ES (ca_ES.UTF-8); Calc: group threaded
@Eike, related to bug 115950 ??
Crash reported in comment 60 reported in bug 118549
Hi All, I've sent in a patch that replaces the old background tab page with the new background tab page for all uses except a couple I found in the Report code that I don't know how to test or what it is. Here is the patch: https://gerrit.libreoffice.org/#/c/57102/
In Calc still the selection of palettes is missing under MainMenu > cells > Background > Background Color Version: 6.1.0.3 (x64) Build-ID: efb621ed25068d70781dc026f7e9c5187a4decd1
(In reply to HKR from comment #65) > In Calc still the selection of palettes is missing under > > MainMenu > cells > Background > Background Color > > Version: 6.1.0.3 (x64) > Build-ID: efb621ed25068d70781dc026f7e9c5187a4decd1 As of now this won't be available until 6.2.0
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/0dfb0f09f5582a33d16c5ad8659fab198d530b31%5E%21 tdf#105225 new background tab page It will be available in 6.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 121261 has been marked as a duplicate of this bug. ***
Calc: Sheet > Sheet Tab Color... (or context menu on the tab: Tab Color...)
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/73616a273d9aa0e0bb3c7a7babc87479680a78b5%5E%21 tdf#105225 Use derived background tab page in Paragraph Style dialog It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Heiko Tietze from comment #69) > Calc: Sheet > Sheet Tab Color... > > (or context menu on the tab: Tab Color...) Here is one for this: https://gerrit.libreoffice.org/#/c/64329/
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/0a139d98477c116f14041b3c4ebb7bb6204808d3%5E%21 tdf#105225 Add palette choice to calc tab background color dialog It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-6-2": https://git.libreoffice.org/core/+/45b030a3e219bc2876472e1ada12cff602ec6549%5E%21 tdf#105225 Add palette choice to calc tab background color dialog It will be available in 6.2.0.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Regina Henschel from comment #1) > And another one: Tools > Options > Charts > Default Colors Here is a patch to add palette selection for this: https://gerrit.libreoffice.org/#/c/64980/
Hi All, Here is a patch for the remaining two places, AFAIK, where color palette cannot be chosen: https://gerrit.libreoffice.org/#/c/64991/ The usefulness of these two background settings seem dubious to me.
(In reply to Jim Raykowski from comment #75) > The usefulness of these two background settings seem dubious to me. After adding some needed things for new background use to the Writer/Web portion of the patch only the uno background command portion is dubious of use to me.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/82df20eeb8f071aaf3780b111aaa27fbc1b2dc9a%5E%21 tdf#105225 Add palette selection to options charts default colors It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Running 6.1.4.2, palette selection is also missing in: Calc: Styles > Manage Styles > Styles and Formatting > (right click on a style) > Modify... > Background I think this fits into this bug?
(In reply to Jean DELVARE from comment #78) > Running 6.1.4.2, palette selection is also missing in: > > Calc: > Styles > Manage Styles > Styles and Formatting > (right click on a style) > > Modify... > Background Is present in Version: 6.3.0.0.alpha0+ Build ID: 082144fa0fb2021cfb41494bb6eb5bf417e58ab1 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2018-12-31_03:11:43 Locale: nl-NL (nl_NL.UTF-8); UI-Language: en-US Calc: threaded and 6.2.0.1 too, I see. So fixed in the mean time. > I think this fits into this bug? In principle: yes - thanks for your comment!
Is "Search for formatting" dialog covered by this? See https://ask.libreoffice.org/en/question/179827
(In reply to Mike Kaganski from comment #80) > Is "Search for formatting" dialog covered by this? > > See https://ask.libreoffice.org/en/question/179827 Here is a patch for review: https://gerrit.libreoffice.org/#/c/66578/
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/7eedbd6380d30de82427c159b05b9545bb57336d%5E%21 tdf#105225 New background tab page for Search for formatting dialog It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
So the only place in the codebase where SvxBackgroundTabPage is still added seems to be cui/source/tabpages/bbdlg.cxx?
(In reply to Mike Kaganski from comment #83) > So the only place in the codebase where SvxBackgroundTabPage is still added > seems to be cui/source/tabpages/bbdlg.cxx? patch for review is here: https://gerrit.libreoffice.org/#/c/64016/ also reportdesign/source/ui/dlg/dlgpage.cxx https://gerrit.libreoffice.org/#/c/64991/ and sw/source/ui/frmdlg/pattern.cxx sw/source/uibase/app/appopt.cxx https://gerrit.libreoffice.org/#/c/64673/
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/5439b1e4d504c9afa71a707743d219222790d6ac%5E%21 tdf#105225 New background tab page for header and footer Border It will be available in 6.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Could someone write what was resolved and what remained?
(In reply to Timur from comment #86) > Could someone write what was resolved and what remained? I believe the only background tab pages that have not been changed are the Base:Report Builder and the UNO and Writer Web background. There are patches ready for these but never received review so went into abandoned state. Use new background tab page in Base:Report Builder https://gerrit.libreoffice.org/#/c/64673/ New UNO and Writer Web background tab pages https://gerrit.libreoffice.org/#/c/64991/
Changing priority to 'high' since the number of duplicates is 5 or higher
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/48e8c03710a540341a0d901273c42acfe0189498 tdf#105225 Use new background tab page in Base:Report Builder It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/03facb4bb75e4283c91de6f081ee96137ca4346c tdf#105225 New UNO and Writer Web background tab pages It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
All uses of background/highlighting tab page have been replaced with the new background tab page. I know of no other places where color palette cannot be chosen so I have set this to resolved fixed.
Thank you Jim! Could you please create a follow-up change to cleanup RID_SVXPAGE_BACKGROUND and relevant tab page?
(In reply to Jim Raykowski from comment #91) > All uses of background/highlighting tab page have been replaced with the new > background tab page. I know of no other places where color palette cannot be > chosen so I have set this to resolved fixed. Great work! Some bits are still missing, tools > options > chart > colors come in my min, though it's not a color picker (and likely not so simple to change).
(In reply to Mike Kaganski from comment #92) > Thank you Jim! > > Could you please create a follow-up change to cleanup RID_SVXPAGE_BACKGROUND > and relevant tab page? Thank you Mike for your reviews! I greatly appreciate them. Here is a patch that removes the old background page code and renames all uses of RID_SVXPAGE_BACKGROUND to RID_SVXPAGE_BKG: https://gerrit.libreoffice.org/#/c/85194/
(In reply to Heiko Tietze from comment #93) > Great work! Some bits are still missing, tools > options > chart > colors > come in my min, though it's not a color picker (and likely not so simple to > change). Thanks Heiko! A pallet drop down was added for the Options - Charts - Default Colors (see Comment 74). I will look at using the background tab page for this.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c5f593d68b7f6d8a2f2adc75d5bcb795822efeac Related tdf#105225: Remove old background tab page code It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks to everybody involved in fixing this. I realize it was a huge amount of work because there were so many different places where changes had to be made. Kudos!
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e8ac78d3afdeb0302eaea34a50f1ca912d5fe897 Related tdf#105225 Remove unused backgroundpage.ui It will be available in 6.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 137399 has been marked as a duplicate of this bug. ***