Bug 129061 - FILEOPEN PPTX: equation not displayed because Impress doesn't support inline formulas
Summary: FILEOPEN PPTX: equation not displayed because Impress doesn't support inline ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: highest normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, dataLoss, filter:pptx, implementationError
: 81494 105886 124976 125123 130026 132692 133232 133239 134001 134068 136910 138633 138971 (view as bug list)
Depends on:
Blocks: PPTX-Equations
  Show dependency treegraph
 
Reported: 2019-11-27 14:28 UTC by Ofir
Modified: 2021-05-07 07:45 UTC (History)
17 users (show)

See Also:
Crash report or crash signature:


Attachments
PPTX with text, equation and animations (33.95 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2019-11-27 14:29 UTC, Ofir
Details
PDF exported from PowerPoint 2013 (183.47 KB, application/pdf)
2019-11-27 14:30 UTC, Ofir
Details
Minimal sample document (37.39 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2019-11-27 14:44 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ofir 2019-11-27 14:28:40 UTC
Description:
The attached PPTX has 2 lines of text and a third line with equation.
Each line has on-click animation.
The text is duplicated and the animation is wrong. This is somehow caused by the equation.

Steps to Reproduce:
1. Open the attached PPTX in Impress
2. Compare with the PDF exported from PowerPoint 2013.
3. Try to play the animations.

Actual Results:
The text is duplicated. The animations don't play one by one on click.

Expected Results:
No duplicate text.
Separate animations on click.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.3.3.2 (x86)
Build ID: a64200df03143b798afd1ec74a12ab50359878ed
CPU threads: 8; OS: Windows 6.1; UI render: default; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL
Comment 1 Ofir 2019-11-27 14:29:38 UTC
Created attachment 156147 [details]
PPTX with text, equation and animations
Comment 2 Ofir 2019-11-27 14:30:15 UTC
Created attachment 156148 [details]
PDF exported from PowerPoint 2013
Comment 3 Xisco Faulí 2019-11-27 14:43:31 UTC
Hello,
So the duplicate equation is fixed in https://cgit.freedesktop.org/libreoffice/core/commit/?id=4038d6c393c3cf6330671124ba69cdba98b24960
However, the same commit has caused the equation x to disappear... I believe we can consider that a regression...

author	Miklos Vajna <vmiklos@collabora.com>	2019-11-13 17:41:45 +0100
committer	Miklos Vajna <vmiklos@collabora.com>	2019-11-13 18:43:57 +0100
commit	4038d6c393c3cf6330671124ba69cdba98b24960 (patch)
tree	79dbbc062df6fb3acd544e223b6b7cd036f1da54
parent	ae499df25c01a149dfbb387da17a7f8a232a6a4e (diff)
tdf#117658 PPTX import: fix duplicated math object handling

Bisected with: bibisect-linux64-6.5

Adding Cc: to Miklos Vajna
Comment 4 Xisco Faulí 2019-11-27 14:44:20 UTC
Created attachment 156149 [details]
Minimal sample document
Comment 5 Miklos Vajna 2019-11-27 17:31:15 UTC
This is how this "worked" in the past: The PPTX file contains both drawingML / mathML markup for the slide and also a replacement image. We used to read both: the OOXML markup missed the math formula and the replacement image did not.

This is how this is "broken" currently: we now only read the OOXML markup to avoid the duplication, but Impress doesn't support inline formulas (just math objects), so the import can't really do much more than just ignoring the math formula.

Considering this as a regression is fair enough, but I would say the root cause here is missing feature, it's not like I can sit down and just "fix this": if we read both versions, then we have duplication, if we read only the markup then we can have problems when Impress misses some PowerPoint feature and if we only read the replacement image, then we regress because the formula is not editable.

To sum up, the root cause here is really a missing feature, let me tag this as an implementation error, rather than a regression.

This Impress core limitation is even documented in a debug warning in commit 332a796366b7cb91dff41de4b9ffb17843112a3e (oox: import Math objects from PPTX files, 2016-01-21):

warn:oox.drawingml:2141:2141:oox/source/drawingml/shape.cxx:667: losing a Math object...
Comment 6 Ofir 2019-11-28 09:00:17 UTC
Miklos, can you please give an example of OOXML element representing inline formula that Impress doesn't support and Math object that Impress does support?
Maybe I can preprocess the pptx and replace inline formulas with math objects.
Comment 7 Miklos Vajna 2019-12-02 08:55:01 UTC
This bug has an example of a PPTX shape which has both text and math markup, Impress can't handle this.

E.g. bug 117658 has an example PPTX shape which has only math markup, so we can map that to Impress math objects.
Comment 8 Timur 2019-12-07 19:06:32 UTC
*** Bug 125123 has been marked as a duplicate of this bug. ***
Comment 9 Timur 2019-12-07 20:28:28 UTC
*** Bug 105886 has been marked as a duplicate of this bug. ***
Comment 10 Timur 2019-12-07 20:32:35 UTC
Inline math examples in:
- PPTX attachment 131045 [details] from bug 105886, PDF as attachment 131046 [details].
- attachment 113333 [details] from bug 81494, equation𝑡ℎ𝑒 is shown as equation.
- slide 3 of attachment 151079 [details] from bug 124976
Comment 11 Timur 2019-12-07 20:33:09 UTC
*** Bug 81494 has been marked as a duplicate of this bug. ***
Comment 12 Timur 2019-12-07 20:34:19 UTC
*** Bug 124976 has been marked as a duplicate of this bug. ***
Comment 13 Timur 2019-12-07 20:43:15 UTC
Further examples in https://web.archive.org/web/20160721184553/http://www.mmds.org/mmds/v2.1/ch10-graphs1.pptx from bug 102200.
I didn't close as duplicate because it needs to be thoroughly checked.
Comment 14 Timur 2020-01-20 13:47:41 UTC
*** Bug 130026 has been marked as a duplicate of this bug. ***
Comment 15 Timur 2020-05-04 21:05:44 UTC
*** Bug 132692 has been marked as a duplicate of this bug. ***
Comment 16 raal 2020-05-21 21:20:57 UTC
*** Bug 133232 has been marked as a duplicate of this bug. ***
Comment 17 Xisco Faulí 2020-06-15 14:18:45 UTC
*** Bug 134001 has been marked as a duplicate of this bug. ***
Comment 18 Xisco Faulí 2020-06-17 14:11:45 UTC
*** Bug 134068 has been marked as a duplicate of this bug. ***
Comment 19 Xisco Faulí 2020-09-15 16:02:46 UTC
Still reproducible in

Version: 7.1.0.0.alpha0+
Build ID: 6f1e02c96b887750f974c187a82ecd6236e6a435
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 20 Xisco Faulí 2020-10-12 17:32:24 UTC
*** Bug 136910 has been marked as a duplicate of this bug. ***
Comment 21 Xisco Faulí 2020-12-16 11:57:17 UTC
*** Bug 138971 has been marked as a duplicate of this bug. ***
Comment 22 Xisco Faulí 2020-12-16 12:00:13 UTC
Increasing importance due to the number of duplicates
Comment 23 Ming Hua 2020-12-18 07:32:23 UTC
Can someone (Timur?) who knows what to check have a look at bug 138633 and see if that's also a duplicate?  Thanks.
Comment 24 Xisco Faulí 2020-12-18 08:55:23 UTC
*** Bug 138633 has been marked as a duplicate of this bug. ***
Comment 25 thomas.mitterfellner 2020-12-19 19:55:33 UTC
I just wanted to mention that https://bugs.documentfoundation.org/show_bug.cgi?id=138971 contains kind of minimal test files of the same document (one line of text, one formula) in odp, pptx and pdf format (all saved with some version of PP Office 365).
Comment 26 NISZ LibreOffice Team 2021-01-22 07:41:54 UTC
*** Bug 133239 has been marked as a duplicate of this bug. ***