Bug 35568 - QuickStarter setting not remembered after upgrade (win only)
Summary: QuickStarter setting not remembered after upgrade (win only)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
3.3.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:25.2.0 target:24.8.0.0.beta2
Keywords:
: 57783 93965 141670 144213 149167 154594 (view as bug list)
Depends on:
Blocks: Win-Installer-MAB Quickstarter
  Show dependency treegraph
 
Reported: 2011-03-22 15:09 UTC by Zack
Modified: 2024-07-23 13:00 UTC (History)
15 users (show)

See Also:
Crash report or crash signature:


Attachments
Script - remove quickstarter (1.71 KB, text/plain)
2013-11-11 08:47 UTC, Timur
Details
Script - add quickstarter (2.93 KB, text/plain)
2013-11-11 08:48 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zack 2011-03-22 15:09:37 UTC
I've noticed this with nearly all upgrades, from the first Beta until this most recent release (3.3.2).  When upgrading, all my options in LO are remembered except the check box which loads LO during system startup.  I have to go in and re-enable this feature after every upgrade.

Steps to reproduce:  Install an older version of LO and enable the "Load LO during system startup" option.  Upgrade to a newer version of LO and the option will no longer be selected.
Comment 1 Don't use this account, use tml@iki.fi 2011-03-23 00:26:32 UTC
Please note that the description of this option is severely misleading. It has nothing at all to do with "System Startup." What it means is simply when the user in question logs in. And the name of the feature is QuickStarter. (The "quick" part is mostly marketing, in my opinion, see below.)

Personally I think this feature is fairly pointless. Are you aware that all it means is that LibreOffice is running constantly, even if you have no document open in it? You can achieve the same effect by simply not quitting LibreOffice.

My thoughts go like this: We can divide LibreOffice users into three groups:

- The people who benefit from this option are presumably such that keep editing  documents in LibreOffice all the time, opening several documents per hour. Well, why not just then keep LibreOffice running *visibly* all the time?

- For people who don't use LibreOffice except occasionally, on old machines that are low on resources (slow CPU, little memory), keeping LibreOffice running all the time *invisibly* (i.e. QuickStarter) is surely just aggravating the resource problem and making other applications appear even slower.

- And finally, people who use LibreOffice only occasionally, but on powerful current machines, its startup time is not that bad, is it? And if you use it once or twice a day, does it really matter if the time it takes to open the document you want to edit is a couple of seconds longer if you don't use QuickStarter?
Comment 2 Zack 2011-03-23 10:50:26 UTC
Then I guess my question is, why continue to have a feature that is relatively pointless?
Comment 3 Don't use this account, use tml@iki.fi 2011-03-23 10:57:04 UTC Comment hidden (obsolete)
Comment 4 Zack 2011-03-23 11:35:19 UTC
(In reply to comment #3)
> Good question. But I can imagine the whining that would ensue if it was
> removed. We just need somebody with the will and courage to do it.

Are you volunteering? :p

Fair enough.  This bug can be closed if need be.
Comment 5 Zoran 2011-10-14 09:46:32 UTC
Please do not kill QuickStarter :)

On the contrary, it would be great to have this bug SOLVED.

We use LibreOffice also for processing and printing documents from our internal systems. When QuickStarter is off, it takes about 6-10 seconds to process one single document, with QuickStarter is running it is < 1s. The documents are processed in batches, so the difference is multiplied and very very obvious.

And we cannot ask users - please open blank LO document before running this or that... so QuickStarter is perfect solution.


And it would be great to keep the setting to use it between upgrades. Now we need to reenable it manualy each time on each machine for each user...
Comment 6 Björn Michaelsen 2011-12-23 11:48:05 UTC Comment hidden (obsolete)
Comment 7 Pedro 2012-01-05 08:48:19 UTC
I can confirm that when updating from LO 3.4.4 to 3.4.5RC2 the Quickstarter option is disabled.
Comment 8 Timur 2012-07-23 08:00:14 UTC
I'd like to point you to the discussion in Bug 46510:  Turn on Quickstarter by silent install. Now that it's solved, it works only if there is no user profile. 
If there is a user profile already, nothing happens. But, there should be a possibility to turn on the QuickStarter with the silent install also if a profile already exists. 
I think this is not a minor issue, but of the same importance as bug 46510 and other bug for silent installation, so I changed to "normal".
Comment 9 Michael Meeks 2012-10-05 11:16:22 UTC
Soo ... the code for this issue (if people want to poke at it is) is here:

http://cgit.freedesktop.org/libreoffice/core/tree/sfx2/source/appl/shutdowniconw32.cxx#n767

The status of that check-box is not a setting that is stored in the normal way - in the configuration of LibreOffice; but instead is something that relies on the existence (or not) of a shortcut in a magic place on your desktop:

http://cgit.freedesktop.org/libreoffice/core/tree/sfx2/source/appl/shutdowniconw32.cxx#n821

Shows how IsQuickStarterInstalled - (better named 'is it enabled') is implemented; and I guess (somehow) when we remove / update the version then - we remove the old version of that link during some MSI cleanup phase, and then don't restore it (?) or something.

Andras - any ideas ?
Comment 10 Andras Timar 2012-10-05 11:28:39 UTC
(In reply to comment #9)
I can come up with a hack, in fact I planned to solve this bug along with bug 46510, but I forgot about it. First, I need to know, if it is worth the effort. From time to time Tor comes up with te idea to kill QuickStarter, and even you, Michael tend to agree.
Comment 11 Michael Meeks 2012-10-05 11:40:14 UTC
IMHO it'd be painful to kill the quickstarter on Windows - I imagine it still has a real impact for older machines; and (beyond this sort of thing) it's a really small amount of extra code so ...
Comment 12 Rainer Bielefeld Retired 2012-11-26 15:20:36 UTC
Comparing this one with other Bugs with the MAB label I decided to remove it from the MAB list. This is something of course annoying some people, but it has been under discussion whether to fix and if yes how. I don't see urgency.
Comment 13 Timur 2012-12-06 11:07:25 UTC Comment hidden (obsolete)
Comment 14 Andras Timar 2012-12-06 11:12:39 UTC
(In reply to comment #13)
> Now that's removed from MAB, I hope it won't be forgotten and that Andras
> will come up with the fix.

Oh yes. A good candidate for 4.0. I'm fully booked for December, but I'll try to get back to this soon.
Comment 15 Timur 2013-02-26 09:28:54 UTC
This is of major importance to us, so we use a workaround: 
 Run the Script before Installing Software
   cscript removeOOLOquickstarter.vbs
AND
 Run the Script after Installing Software
   cscript addLOquickstarter.vbs
Comment 16 Michael Meeks 2013-03-06 14:27:20 UTC
Hi Timur, of course hopefully Timar will get some time soon too ;-)
Comment 17 Timur 2013-03-08 08:57:31 UTC
*** Bug 57783 has been marked as a duplicate of this bug. ***
Comment 18 Claude 2013-06-04 01:43:10 UTC
I confirm the behavior as described in Bug 57783 on both XP and Win 7.  Gui Install. Every upgrade since the selection option was offered at install time up to 4.0.4.1.
Comment 19 Winfried Donkers 2013-11-08 08:38:44 UTC
(In reply to comment #15)
> This is of major importance to us, so we use a workaround: 
>  Run the Script before Installing Software
>    cscript removeOOLOquickstarter.vbs
> AND
>  Run the Script after Installing Software
>    cscript addLOquickstarter.vbs

Hi Timur,
Any chance of obtaining these scripts? As long as the bug isn't solved and with the continuing flow of updates, I spend quite some time removing and installing the startup option to load QuickStarter on the machines in our office...
Comment 20 Timur 2013-11-11 08:47:45 UTC
Created attachment 88999 [details]
Script - remove quickstarter
Comment 21 Timur 2013-11-11 08:48:27 UTC
Created attachment 89000 [details]
Script - add quickstarter
Comment 22 Winfried Donkers 2013-11-11 08:55:32 UTC
(In reply to comment #21)
> Created attachment 89000 [details]
> Script - add quickstarter

@Timur:
Thank you very much! Adjusting these takes a lot less time than creating them from scratch.
They are just in time for the last batch of 4.1.3 updates :)
Comment 23 QA Administrators 2016-02-21 08:34:27 UTC Comment hidden (obsolete)
Comment 24 Frank Fuchs 2016-03-02 15:30:00 UTC
Dear QA Team,

the bug is still present, in fact it consists of two parts:

situation before LO upgrade:
OS: Win 10, V. 1511, all updates, 32-bit
LO: 5.1.1.1 Win 32-bit
The LO quickstarter is enabled and LO is running

installation:
LO 5.1.1.3 Win 32-bit
use "customized" install option
part 1 of the bug: the installation dialog in which you can enable the LO quickstarter shows the relevant checkbox as disabled. In my opinion, this checkbox should be presented enabled in case you already use the quickstarter prior to the LO upgrade installation.

after installation:
part 2 of the bug: the optional LO quickstarter is not enabled, even though it was enabled prior to the LO upgrade and even though it was explicitly enabled during "customized" install.
Comment 25 Kumāra 2016-10-14 07:09:09 UTC
The issue now is this: Ticking the "Load LO during system startup" option has no effect. You can tick it, you can even already have quickstarter loaded during startup, it will be removed upon upgrading. If you like to have it back, you'll just have to re-enable it at Options.

Tip: You can also re-enable by having the quickstarter loaded manually, right-click on the icon and enable "Load LO during system startup".

It's amazing that I've been living with this for more than 5 years. :-)
Comment 26 Xisco Faulí 2017-07-13 11:20:24 UTC
Setting Assignee back to default. Please assign it back to yourself if you're
still working on this issue
Comment 27 QA Administrators 2018-11-28 03:48:38 UTC Comment hidden (obsolete)
Comment 28 Frank Fuchs 2018-11-29 08:13:07 UTC
The bug is still present with:
LibO 6.1.3.2
run on Windows 10 (1809) 32bit
Comment 29 stavrosm125@bugzilla.com 2020-09-09 08:15:50 UTC
Comment on attachment 88999 [details]
Script - remove quickstarter

>'removes quickstarter for a given version of OpenOffice'
>
>option explicit
>On Error Resume Next
>
>Dim oShell, objFSO, lnk
>Dim strStartup
>Dim exitCode, strRemoveQuickstarter1, strRemoveQuickstarter2
>                          
>Set oShell = CreateObject( "WScript.Shell" )
>Set objFSO = CreateObject("Scripting.FileSystemObject")
>exitCode = 0
>
>
>strStartup    = WScript.Arguments.Item(0) ' "$ShellStartup" (za User) i "$allusersstartup" (za Comp)
>
>'''
>Wscript.echo "removing quickstarter"
>'''
>  
>  'REMOVE all old shortcuts for OO from Desktopa and from Startup'
>  ''''
>  strRemoveQuickstarter1 = strStartup & "\OpenOffice.org*.lnk"
>  strRemoveQuickstarter2 = strStartup & "\LibreOffice*.lnk"
>    
>  Wscript.echo "strRemoveQuickstarter: " & strRemoveQuickstarter1
>  Err.Number = 0
>  objFSO.DeleteFile strRemoveQuickstarter1, true
>  If Err.Number <> 0 Then
>      Wscript.echo "Error in removing quickstarter" & Err.Description
>  End If
>  
>  Wscript.echo "strRemoveQuickstarter: " & strRemoveQuickstarter2
>  Err.Number = 0
>  objFSO.DeleteFile strRemoveQuickstarter2, true
>  If Err.Number <> 0 Then
>      Wscript.echo "Error in removing quickstarter" & Err.Description
>  End If
>  
>Wscript.Quit 0
>
>
>  if Right(oShell.ExpandEnvironmentStrings("%AllUsersProfile%"), 11) = "ProgramData" then
>   ' WIn 7 - C:\Users\Public\Desktop'
>    strRemoveQuickstarter = "C:\Users\Public\Desktop" & "\" & strRemoveShortcut & "*.lnk"
>  Else 
>    'Win XP'
>    strRemoveQuickstarter = oShell.ExpandEnvironmentStrings("%AllUsersProfile%") & "\Desktop" & "\" & strRemoveShortcut & "*.lnk"
>  End If  
>    
>  objFSO.DeleteFile strRemoveQuickstarter, true
>  If Err.Number <> 0 Then
>      Wscript.echo "Error in removing shortcut from Desktop" & Err.Description
>  End If
>  
>Wscript.Quit 0
>
Comment 30 QA Administrators 2022-09-10 03:50:50 UTC Comment hidden (obsolete)
Comment 31 Stéphane Guillou (stragu) 2023-04-18 08:52:19 UTC
*** Bug 154594 has been marked as a duplicate of this bug. ***
Comment 32 Stéphane Guillou (stragu) 2023-04-18 09:02:05 UTC
(In reply to Kumāra from comment #25)
> The issue now is this: Ticking the "Load LO during system startup" option
> has no effect.

This is tracked in bug 88212.
Comment 33 Jérôme 2023-11-30 18:03:10 UTC
As a workaround, the file name of the shortcut could be composed with the path of the quick start program.
For example : c_program_files_libreoffice_program_quickstart

Next the quickstart user setting will be remembered after upgrade.
Comment 34 OdinWill 2024-01-25 05:52:09 UTC Comment hidden (spam)
Comment 35 Mike Kaganski 2024-06-15 07:24:30 UTC
*** Bug 149167 has been marked as a duplicate of this bug. ***
Comment 36 Mike Kaganski 2024-06-15 07:24:36 UTC
*** Bug 144213 has been marked as a duplicate of this bug. ***
Comment 37 Mike Kaganski 2024-06-15 07:24:41 UTC
*** Bug 141670 has been marked as a duplicate of this bug. ***
Comment 38 Mike Kaganski 2024-06-15 07:24:47 UTC
*** Bug 93965 has been marked as a duplicate of this bug. ***
Comment 39 Mike Kaganski 2024-06-15 07:42:13 UTC
So there are three different, but related, issues:

1. The installer does *not* make LibreOffice start itself. What it does is set a registry setting, that tells LibreOffice, *when it is manually started the first time*, that it needs to add itself to system autostart. Thus, with a *clean* install (most important is no pre-existing user profile), enabling "load during system start-up" in the installer, then rebooting after installation - does *not* start LibreOffice automatically. Launching LibreOffice manually in this case launches quickstart and creates the system autostart shortcut, so the next reboot will be OK. This is bug 75767.

2. The *upgrades* disable quicktart, and do not re-enable. After an upgrade, even with double-ckecked "load during system start-up" is checked in installer, the quickstart will not run after reboot, and even after manual program start; the respective checkbox in options is unchecked, and needs manual re-check to work. This happens because the system autostart shortcut gets removed in the beginning of the upgrade, then the registry setting telling to enable quickstart is written (see #1); but that registry setting is *only ever checked when LibreOffice is started without a previous profile* (first time *ever*). This is this bug 35568. It will be fixed by https://gerrit.libreoffice.org/c/core/+/168902.

3. The system autostart shortcuts that gets created to actually enable quickstart is created in the user's system profile, and is named including LibreOffice version. This makes it impossible to remove such a shortcut on an administrative uninstallation, when the uninstaller is run by an account other than the user's: the uninstaller will try to remove the shortcut, but that will happen in that user's system profile. Thus, in the administrative install case, the old shortcuts are kept, and then new shortcuts will be added when user enables the checkbox in options. This is bug 123413.
Comment 40 Commit Notification 2024-06-15 11:19:41 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f1e4a97b03e1eacd679c3ef1dcb7ab4b577dd928

tdf#35568 Repeat "first run" procedure on upgrade

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 41 Commit Notification 2024-06-17 11:32:14 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/e3563cd274ce3f1c1b514c5f63f9f8fc73b5aee6

tdf#35568 Repeat "first run" procedure on upgrade

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 42 lal 2024-07-23 11:35:19 UTC
Tested with LO 24.2.5.2 in Windows 11. Sadly, it did not work. Same behavior as before. (as response to comment #40)

Version: 24.2.5.2 (X86_64) / LibreOffice Community
Build ID: bffef4ea93e59bebbeaf7f431bb02b1a39ee8a59
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: sv-SE (da_DK); UI: en-US
Calc: threaded(In reply to Commit Notification from comment #40)
> Mike Kaganski committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/
> f1e4a97b03e1eacd679c3ef1dcb7ab4b577dd928
> 
> tdf#35568 Repeat "first run" procedure on upgrade
> 
> It will be available in 25.2.0.
> 
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.
Comment 43 Mike Kaganski 2024-07-23 11:38:56 UTC
(In reply to lal from comment #42)
> Tested with LO 24.2.5.2 in Windows 11.
> ...
> (In reply to Commit Notification from comment #40)
> > Mike Kaganski committed a patch related to this issue.
> > ...
> > It will be available in 25.2.0.

Comment 40 tells about version 25.2; comment 41 tells about version 24.8. You tested using version 24.2. It's not expected that a version older than those which have the fix would heal itself :-)
Comment 44 lal 2024-07-23 11:54:29 UTC
apologies. Let's call it a wet brain fart on my part 💩
Comment 45 Mike Kaganski 2024-07-23 13:00:34 UTC
Let me quote important bit from the commit message, to establish correct expectations:

> This will not make installer itself create the quickstart shortcut: it
> will happen on the program's first run after an upgrade. But users now
> won't have to enable the option manually each time.