Bug 41466 - VML Callout shapes are incorrectly imported for 2007 DOCX (OK if resaved in MSO to newer DOCX)
Summary: VML Callout shapes are incorrectly imported for 2007 DOCX (OK if resaved in M...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.4.3 release
Hardware: All All
: medium normal
Assignee: Balázs Regényi
URL:
Whiteboard: target:7.2.0 target:7.1.0.0.beta2
Keywords: filter:docx
: 75277 77044 78484 79267 101737 104385 123347 132945 (view as bug list)
Depends on:
Blocks: VML-Textbox
  Show dependency treegraph
 
Reported: 2011-10-04 16:04 UTC by anonm
Modified: 2023-05-30 09:32 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments
Open Office 3.2.1 (77.37 KB, image/png)
2011-10-04 16:04 UTC, anonm
Details
Google docs (136.46 KB, image/png)
2011-10-04 16:05 UTC, anonm
Details
Libre Office 3.4.3 final (80.23 KB, image/png)
2011-10-04 16:06 UTC, anonm
Details
test3.docx (75.59 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2011-11-02 05:47 UTC, anonm
Details
Compare View (296.33 KB, application/x-zip-compressed)
2011-11-27 00:10 UTC, Rainer Bielefeld Retired
Details
Minimized test document in docx format (21.14 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-09-28 12:48 UTC, Balázs Regényi
Details
The minimized example file in Word and Writer (69.50 KB, image/png)
2020-09-28 12:52 UTC, Balázs Regényi
Details
Reference file in doc format with all callout types (27.50 KB, application/msword)
2020-11-02 15:49 UTC, NISZ LibreOffice Team
Details
Reference file in compatibility docx format with all callout types (13.48 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-11-02 15:50 UTC, NISZ LibreOffice Team
Details
Reference file in non-compatibility docx format with all callout types (31.65 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-11-02 15:50 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description anonm 2011-10-04 16:04:27 UTC
Created attachment 51981 [details]
Open Office 3.2.1

Hallo,
  please look to attachements. I've got .docx file, I can show it using three diferent methods with three different results (I guess no one looks as original):

(1) OpenOfice 3.2.1, where picture is missing, but comments to this picture are shown as text in rectangles. Header of page is shown fine (green components)

(2) Google Docs - shown almost fine, but comments are not visible (black elements in picture)

(3) Libre Office 3.4.3 final .... page header is broken (overlapping green elements), picture is visible, but comments disappears. New problem is that numbering of pages do not work properly (see bottom of first page).

Could you please as main problem make comments visible? Header and numbering are not so important for me, but it will be good bonus.

Thank you for your help,
  Plamen
Comment 1 anonm 2011-10-04 16:05:54 UTC
Created attachment 51982 [details]
Google docs
Comment 2 anonm 2011-10-04 16:06:31 UTC
Created attachment 51983 [details]
Libre Office 3.4.3 final
Comment 3 Rainer Bielefeld Retired 2011-10-04 22:14:08 UTC
Modified Version due to report

@anonm@volny.cz:
We need a sample.docx 

May I ask you to read  hints on <http://wiki.documentfoundation.org/BugReport> carefully?
Comment 4 anonm 2011-10-12 03:37:18 UTC Comment hidden (obsolete)
Comment 5 Rainer Bielefeld Retired 2011-10-18 10:59:47 UTC Comment hidden (obsolete)
Comment 6 anonm 2011-10-19 03:53:35 UTC Comment hidden (obsolete)
Comment 7 Rainer Bielefeld Retired 2011-10-29 08:59:29 UTC
I checked the sample documents I received from reporter by PM and saw that callouts are lost in 3.4.4RC1 and mutated to text frames in Master.

@anonm@volny.cz:
Any chance to get a new, more simple sample document only showing the problems, but not the confidential contents?
Comment 8 anonm 2011-11-01 01:57:48 UTC
Created attachment 53047 [details]
test3.docx

Hi,
I do not own MS Ofice, so I cannot modify this document using
original tool. I can try to delete some parts by LO or OO, and then
test if modified version is shown as described in original bug, but
I think that after modification some fields from this file will be
lost and bug will not be reproducible. Give me few days to try it.
Comment 9 anonm 2011-11-02 05:47:45 UTC
Hi,
I've tried to edit and then zip original document - both Open Office
and Libre Offfice opens it and show the bugs described in my
original mail.

Regards,
P.
Comment 10 Rainer Bielefeld Retired 2011-11-27 00:10:05 UTC
Created attachment 53877 [details]
Compare View

[Reproducible] with reporter's "test2" and "LibreOffice 3.4.4  - WIN7 Home Premium (64bit) German UI [OOO340m1 (Build:402)]": no callout notes visible

[Reproducible] with reporter's "test2" and Server installation of MSVC Master "LibO-dev 3.5.0 – WIN7 Home Premium (64bit) ENGLISH UI [(Build ID:  4f11d0a-adcf6d5-c4bb9bd)]" Windows_2008R8 - 111118): Callouts cruelly damaged.

Please see attached PDF documents comparing 344 view and master view with result in MS WORD Viewer.
Comment 11 Rainer Bielefeld Retired 2011-11-27 00:10:51 UTC Comment hidden (no-value)
Comment 12 anonm 2012-02-23 00:28:39 UTC Comment hidden (obsolete)
Comment 13 anonm 2012-04-25 13:56:44 UTC Comment hidden (no-value)
Comment 14 QA Administrators 2015-04-01 14:41:53 UTC Comment hidden (obsolete)
Comment 15 Buovjaga 2015-04-24 10:46:50 UTC
(In reply to Rainer Bielefeld Retired from comment #10)
> Created attachment 53877 [details]
> Compare View

The only remaining problem is that the comment boxes do not have the triangles protruding from them.

Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64)
Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9
TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50
Locale: fi_FI
Comment 16 QA Administrators 2016-09-20 09:32:23 UTC Comment hidden (obsolete)
Comment 17 Telesto 2016-12-07 14:20:24 UTC
Callout shapes are incorrect: 
Version: 5.4.0.0.alpha0+
Build ID: a9f56091b6422ec8c42f09b8472200ae4ab12548
CPU Threads: 4; OS Version: Windows 6.19; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-12-05_23:12:26
Locale: nl-NL (nl_NL); Calc: CL
Comment 18 Luke 2018-02-13 03:42:17 UTC
This is likely a VML issue. When attachment 53047 [details] is upgraded to OOXML, the Callout shapes are correctly imported.
Comment 19 QA Administrators 2019-02-14 03:48:59 UTC Comment hidden (obsolete)
Comment 20 Luke 2019-02-28 22:28:12 UTC
Still reproducible in Version: 6.3.0.0.alpha0+ (x64)
Build ID: 205e2d6c31b1861111b70a704516580761a75099
Comment 21 Timur 2020-09-07 14:02:05 UTC
*** Bug 79267 has been marked as a duplicate of this bug. ***
Comment 22 Timur 2020-09-07 14:02:09 UTC
*** Bug 77044 has been marked as a duplicate of this bug. ***
Comment 23 Balázs Regényi 2020-09-28 12:48:20 UTC
Created attachment 165916 [details]
Minimized test document in docx format
Comment 24 Balázs Regényi 2020-09-28 12:52:56 UTC
Created attachment 165918 [details]
The minimized example file in Word and Writer
Comment 25 Balázs Regényi 2020-09-28 13:35:45 UTC
I think we do not handle the "v:formulas" XML element for VML shapes (/w:document/w:body/w:p/w:r/w:pict/v:shapetype/v:formulas).

<w:pict>
  <v:shapetype id="_x0000_t61" ...>
    <v:stroke joinstyle="miter"/>
    <v:formulas>
      <v:f eqn="sum 10800 0 #0"/>
      <v:f eqn="sum 10800 0 #1"/>
      <v:f eqn="sum #0 0 #1"/>
      <v:f eqn="sum @0 @1 0"/>
      <v:f eqn="sum 21600 0 #0"/>
      <v:f eqn="sum 21600 0 #1"/>
      <v:f eqn="if @0 3600 12600"/>
      <v:f eqn="if @0 9000 18000"/>
      <v:f eqn="if @1 3600 12600"/>
      <v:f eqn="if @1 9000 18000"/>
      <v:f eqn="if @2 0 #0"/>
      <v:f eqn="if @3 @10 0"/>
      <v:f eqn="if #0 0 @11"/>
      <v:f eqn="if @2 @6 #0"/>
      <v:f eqn="if @3 @6 @13"/>
      <v:f eqn="if @5 @6 @14"/>
      <v:f eqn="if @2 #0 21600"/>
      <v:f eqn="if @3 21600 @16"/>
      <v:f eqn="if @4 21600 @17"/>
      <v:f eqn="if @2 #0 @6"/>
      <v:f eqn="if @3 @19 @6"/>
      <v:f eqn="if #1 @6 @20"/>
      <v:f eqn="if @2 @8 #1"/>
      <v:f eqn="if @3 @22 @8"/>
      <v:f eqn="if #0 @8 @23"/>
      <v:f eqn="if @2 21600 #1"/>
      <v:f eqn="if @3 21600 @25"/>
      <v:f eqn="if @5 21600 @26"/>
      <v:f eqn="if @2 #1 @8"/>
      <v:f eqn="if @3 @8 @28"/>
      <v:f eqn="if @4 @8 @29"/>
      <v:f eqn="if @2 #1 0"/>
      <v:f eqn="if @3 @31 0"/>
      <v:f eqn="if #1 0 @32"/>
      <v:f eqn="val #0"/>
    </v:formulas>
    <v:f eqn="val #1"/>
    <v:path o:connecttype="custom" .../>
    <v:handles>
      <v:h position="#0,#1"/>
    </v:handles>
  </v:shapetype>
  .
  .
  .
</w:pict>
Comment 26 NISZ LibreOffice Team 2020-11-02 15:49:12 UTC
Created attachment 166947 [details]
Reference file in doc format with all callout types
Comment 27 NISZ LibreOffice Team 2020-11-02 15:50:26 UTC
Created attachment 166948 [details]
Reference file in compatibility docx format with all callout types
Comment 28 NISZ LibreOffice Team 2020-11-02 15:50:53 UTC
Created attachment 166949 [details]
Reference file in non-compatibility docx format with all callout types
Comment 29 Commit Notification 2020-12-10 09:27:57 UTC
Regényi Balázs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bda05ba17362222b74727872579b65b3fa14e3d8

tdf#41466 DOCX import: fix VML v:shape/v:textbox

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 30 Commit Notification 2020-12-10 11:04:34 UTC
Regényi Balázs committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/aefb6aaf6475b71668bab7e11ce51b0fdc34f299

tdf#41466 DOCX import: fix VML v:shape/v:textbox

It will be available in 7.1.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 31 Balázs Regényi 2020-12-10 11:32:30 UTC
*** Bug 101737 has been marked as a duplicate of this bug. ***
Comment 32 Balázs Regényi 2020-12-10 11:38:19 UTC
*** Bug 104385 has been marked as a duplicate of this bug. ***
Comment 33 Balázs Regényi 2020-12-10 11:44:55 UTC
*** Bug 123347 has been marked as a duplicate of this bug. ***
Comment 34 Balázs Regényi 2020-12-10 11:50:12 UTC
*** Bug 132945 has been marked as a duplicate of this bug. ***
Comment 35 Buovjaga 2020-12-10 13:22:59 UTC
Verified, thanks

Arch Linux 64-bit
Version: 7.2.0.0.alpha0+
Build ID: 2cccdfbb618004b7a122259707cbff3daf31db3f
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 10 December 2020
Comment 36 Balázs Regényi 2020-12-10 14:48:11 UTC
*** Bug 75277 has been marked as a duplicate of this bug. ***
Comment 37 NISZ LibreOffice Team 2021-01-05 14:51:52 UTC
Verified in:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 96bafa464ebdbce3ef04bec9beae5e745bb37794
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Thanks for fixing!
Comment 38 Xisco Faulí 2021-04-13 10:16:18 UTC
*** Bug 78484 has been marked as a duplicate of this bug. ***