Bug 138051 - UI Picker dialog height follows the selected mode, subsequent calls can leave button actions blocked by text description
Summary: UI Picker dialog height follows the selected mode, subsequent calls can leave...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.2.0 target:7.1.1
Keywords:
: 137423 138042 139333 139698 140153 140213 140230 140455 (view as bug list)
Depends on:
Blocks: 117463
  Show dependency treegraph
 
Reported: 2020-11-07 15:21 UTC by V Stuart Foote
Modified: 2021-02-27 00:31 UTC (History)
12 users (show)

See Also:
Crash report or crash signature:


Attachments
UI Picker dialog height depending on active mode -- master/7.1.0alpha1+ of 20201107 (118.36 KB, image/png)
2020-11-07 15:33 UTC, V Stuart Foote
Details
master/7.2.0 (20201129 TB77) (33.36 KB, image/png)
2020-11-29 18:02 UTC, V Stuart Foote
Details
clip of UI Picker from 2021-01-18 TB77 master (32.83 KB, image/png)
2021-01-18 16:21 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2020-11-07 15:21:00 UTC
Current master
Version: 7.1.0.0.alpha1+ (x64)
Build ID: 5a96093f0ecee53432bdf35f247edd6deb501baf
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

The height of the new UI Picker dialog is not fixed. First 'default' opening on the 'Standard' mode fits all mode descriptions.  But if a mode with shorter description is selected active, on next launch of the picker (View -> User Interface...) the height of the dialog can be too short--descriptive text over laid on the buttons--making them difficult to select.
Comment 1 V Stuart Foote 2020-11-07 15:33:56 UTC
Created attachment 167079 [details]
UI Picker dialog height depending on active mode -- master/7.1.0alpha1+ of 20201107

On left is dialog launched with default Standard had been active, on left is dialog launched after Single Contextual mode had been selected active. Notice the reduced height of the dialog and descriptive text overlapping the action buttons.
Comment 2 V Stuart Foote 2020-11-07 15:48:28 UTC
by shorter description meaning both its image and its text block.

=-=-=

p.s. the new "generic" graphics for the UI Picker dialog are much better cross os/DE
Comment 3 V Stuart Foote 2020-11-07 18:02:12 UTC
(In reply to V Stuart Foote from comment #1)
> Created attachment 167079 [details]

> On left is dialog launched with default Standard had been active, on left is

s/active, on left/active, on right/
Comment 4 Commit Notification 2020-11-09 16:17:26 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/88a66f73f0182baffded6190f969bf7088236949

Resolves tdf#138051 - Text expands beyond dialog height

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 V Stuart Foote 2020-11-09 23:25:40 UTC
*** Bug 138042 has been marked as a duplicate of this bug. ***
Comment 6 V Stuart Foote 2020-11-29 18:02:03 UTC
Created attachment 167648 [details]
master/7.2.0 (20201129 TB77)

@Heiko, *

Sorry, this needs another look. 

In general your fix seems fine, except when setting and entering 'Contextual Single' UI mode. 

For some reason, using the dialog again still positions the descriptions overtop of  button controls ('Apply to all', 'Apply to <module>', 'Close'). 

Blocked for the 'Standard toolbar', 'Tabbed', and 'Sidebar' UI modes with their tall graphics and descriptive text boxes. The others don't their block controls, but text seems misplaced/centered rather than top.

=-=-=
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 5abb1890ffafe5a2212076208a1c6e226f1ffa4e
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 7 V Stuart Foote 2020-11-29 18:11:06 UTC
Nope, blocked controls happen also for 'Grouped Compact', and 'Tabbed Compact' UI modes.

Default GDI, and both Skia modes alike (didn't check OpenGL).

> =-=-=
> Version: 7.2.0.0.alpha0+ (x64)
> Build ID: 5abb1890ffafe5a2212076208a1c6e226f1ffa4e
> CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
> Locale: en-US (en_US); UI: en-US
> Calc: threaded
Comment 8 V Stuart Foote 2020-12-31 16:42:00 UTC
@Heiko, the blocked buttons as in attachment 167648 [details] still need a tweak...

current 20201231 TB77 master

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 90668f3473f4e52cec823ad39c6fcb44ba7c089b
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 9 V Stuart Foote 2020-12-31 19:02:21 UTC
*** Bug 139333 has been marked as a duplicate of this bug. ***
Comment 10 Heiko Tietze 2021-01-05 10:13:36 UTC
(In reply to V Stuart Foote from comment #8)
> @Heiko, the blocked buttons as in attachment 167648 [details] still need a
> tweak...

The text is now in a scrolled window and will not cover the buttons. Neither with RC1 on Windows nor master on Linux for me.

Version: 7.1.0.1 (x64)
Build ID: b585d7d90ab863bf29b2d110c174c0c2a98f3ee4
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 11 Heiko Tietze 2021-01-18 12:38:31 UTC
*** Bug 139698 has been marked as a duplicate of this bug. ***
Comment 12 V Stuart Foote 2021-01-18 16:21:54 UTC
Created attachment 168994 [details]
clip of UI Picker from 2021-01-18 TB77 master

@Heiko, this remains an issue. Do not see a scroll bar.

Clip is UI change from Contextual Single --> Tabbed

Still getting just the smallest sliver of active button to click on, the rest remains blocked.
Comment 13 Heiko Tietze 2021-01-18 16:33:00 UTC
(In reply to V Stuart Foote from comment #12)
> Still getting just the smallest sliver of active button to click on, the
> rest remains blocked.

Submitted a patch about an hour ago at https://gerrit.libreoffice.org/c/core/+/109545
Comment 14 Commit Notification 2021-01-19 06:52:14 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4388e24cbdcf5824a7ef59545688d6fd057a79aa

Resolves tdf#138051 - UI picker text blocks buttons

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Aron Budea 2021-02-06 16:58:48 UTC
*** Bug 140213 has been marked as a duplicate of this bug. ***
Comment 16 V Stuart Foote 2021-02-07 18:29:58 UTC
*** Bug 140230 has been marked as a duplicate of this bug. ***
Comment 17 V Stuart Foote 2021-02-07 18:30:48 UTC
*** Bug 140153 has been marked as a duplicate of this bug. ***
Comment 18 V Stuart Foote 2021-02-07 18:32:58 UTC
being addressed for the 7.1.1 release with

https://gerrit.libreoffice.org/c/core/+/109529
Comment 19 Heiko Tietze 2021-02-09 14:36:04 UTC
*** Bug 137423 has been marked as a duplicate of this bug. ***
Comment 20 Commit Notification 2021-02-11 14:37:09 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/08b6d409b2b5228c14e8b94eddbb8987ec6e9c78

Resolves tdf#138051 - UI picker text blocks buttons

It will be available in 7.1.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Ming Hua 2021-02-16 20:36:35 UTC
*** Bug 140455 has been marked as a duplicate of this bug. ***
Comment 22 Commit Notification 2021-02-17 15:35:11 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-7-1-1":

https://git.libreoffice.org/core/commit/43eda7e273048d4deebad3224e289cf6603fa42b

Resolves tdf#138051 - UI picker text blocks buttons

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Gerhard Weydt 2021-02-27 00:25:55 UTC
It works now in 7.1.1.1:
Version: 7.1.1.1 (x64) / LibreOffice Community
Build ID: 575c5867c4cc13d7ae78f9ce39a54a52ed38c769
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded