Bug 45617 - Make Impress Master Slides copyable
Summary: Make Impress Master Slides copyable
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyInteresting, easyHack, skillCpp
: 41573 51551 85966 87669 113407 115006 115678 (view as bug list)
Depends on:
Blocks: Context-Menu UNO-Command-New Matters-to-Caolan Master-Slide-View
  Show dependency treegraph
 
Reported: 2012-02-04 04:05 UTC by Thorsten Behrens (CIB)
Modified: 2019-08-18 20:28 UTC (History)
26 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Behrens (CIB) 2012-02-04 04:05:06 UTC
Open Impress, select View->Master->Slide Master from the menu. Try to copy the master page on your left, in the slide sorter - and see it fail.

Look into 

BOOL SdDrawDocument::InsertBookmarkAsPage()

It's called on Paste.

555 LoC – refactor it, add a unit test in sd/qa/unit, find & separate all ~6 use cases, and fix the style/name merging.
Comment 1 Florian Reisinger 2012-05-18 09:16:17 UTC
Deteted "Easyhack" from summary
Comment 2 Rob Snelders 2012-11-09 21:20:20 UTC
*** Bug 41573 has been marked as a duplicate of this bug. ***
Comment 3 Rob Snelders 2013-02-16 18:03:01 UTC
*** Bug 51551 has been marked as a duplicate of this bug. ***
Comment 4 Rob Snelders 2013-03-24 10:43:52 UTC
Hi Babati,

Are you still looking into this. Otherwise I'll look into this.
Comment 5 Björn Michaelsen 2013-10-04 18:47:17 UTC
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 6 Rishabh 2015-03-11 05:31:06 UTC
I have started working on the bug. I may need help for adding a unit test
Comment 7 Joel Madero 2015-03-12 02:55:25 UTC
@Rishabh - going to assign this to you since you said you've started. If this changes please set it back to NEW. Thanks!
Comment 8 Robinson Tryon (qubit) 2015-12-14 05:02:04 UTC Comment hidden (obsolete)
Comment 9 Robinson Tryon (qubit) 2016-02-18 14:51:41 UTC Comment hidden (obsolete)
Comment 10 kolAflash 2016-06-29 22:23:48 UTC
Still open after three years :-/


Workaround:

1. Save presentation and make a copy of the file.

2. Change the name of one (or more) master page(s).

3. If not already the case, apply the changed master page(s each) to at least one normal page.

4. Open the original file.

5. Copy one of the normal pages with the changed master page(s) applied to the original presentation.

6. Now there should be a copy of that master with the changed name.
Comment 11 Reuben Thomas 2016-06-30 07:06:25 UTC
Thanks very much for the workaround.
Comment 12 kolAflash 2016-07-01 00:44:51 UTC
By the way:

It's also not possible to change the order of master pages. There is no actual need for this in creating a presentation. But it may be convenient to be able to change the order.

E.g. putting the master pages into the order, by which they are used in the presentation pages.

And I don't really see a reason why the order isn't adjustable!?
Comment 13 jan d 2016-11-22 13:21:23 UTC
Added "needsUXEval" – there seem to be several related bugs, all concerning the missing function/an UI for it, but UX did not seem to be involved in any of them.
Comment 14 Yousuf Philips (jay) (retired) 2016-11-22 13:40:29 UTC
*** Bug 85966 has been marked as a duplicate of this bug. ***
Comment 15 Yousuf Philips (jay) (retired) 2016-11-22 13:59:50 UTC
So we need a solution to both possibilities that users use to duplicate a slide - copy (.uno:Copy) & paste (.uno:Paste) and duplicate (.uno:DuplicatePage) - both of which are disabled in master slide mode.

I would assume creating a .uno:DuplicateMasterPage command to work in master slide view should be the priority, as the uno command would be accessible in the master view toolbar, as well as the slides pane context menu (bug 87669).
Comment 16 Heiko Tietze 2017-01-14 09:30:16 UTC
As suggested in comment 15 the best solution from the UX POV is to have the same interaction as on normal slides. Meaning right click offers Copy (and paste) as well as Duplicate. 

The menu contains today New/Duplicate/Delete Slide and New/Delete Master. Since we switch the context it's okay to change the menu and hide slide entries or master (btw. New Master in Normal mode adds another slide and not a master, the same is true for delete).

Regarding the toolbar users expect copy and paste to work (copy is enabled today in master mode but not functional). We also have the Insert toolbar which provides a New (slide) function. This one could remain for normal slides.

Putting all together the recommendation is to make the copy/paste and duplicate function for slides working on master too. Either with new .uno commands or by changing label and tooltips.

Removing UX, but we should take a look when the implementation has started.
Comment 17 Xisco Faulí 2017-10-27 11:20:33 UTC
*** Bug 113407 has been marked as a duplicate of this bug. ***
Comment 18 Xisco Faulí 2017-10-27 11:20:37 UTC
*** Bug 87669 has been marked as a duplicate of this bug. ***
Comment 19 Regina Henschel 2018-01-14 21:13:12 UTC
*** Bug 115006 has been marked as a duplicate of this bug. ***
Comment 20 Buovjaga 2018-03-06 14:57:53 UTC
*** Bug 115678 has been marked as a duplicate of this bug. ***
Comment 21 Steve 2018-11-07 17:47:16 UTC
Just came across this issue, really would be nice to have it fixed
Comment 22 samtuke 2019-08-16 13:14:44 UTC
This is still high priority from my perspective
Comment 23 Cor Nouws 2019-08-18 20:28:27 UTC
(In reply to Steve from comment #21)
> Just came across this issue, really would be nice to have it fixed

(In reply to samtuke from comment #22)
> This is still high priority from my perspective

Keywords and initial description give a hint ;)